RFR: 8368754: runtime/cds/appcds/SignedJar.java log regex is to strict
Ioi Lam
iklam at openjdk.org
Fri Sep 26 16:38:28 UTC 2025
On Fri, 26 Sep 2025 09:06:40 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> Any logging which gets enabled (via `-verbose:class` which the test uses, or externally from JTREG) and logs before the line this test is checking for with a tag set which is longer than `class,load` makes the test fail.
> Example:
> Test expects:
> * `"[class,load] Hello source: [...]"`
>
> What it gets when logging with `class,unload` prior to this specific log line:
> * `"[class,load ] Hello source: [...]"`
>
> I suggest we simply allow for any whitespace after the log tags and before the `.`. Unclear why we use `.` and not `]`. But think it works just as well.
Looks good to me. The original code used `.` to avoid quoating the `[` character.
-------------
Marked as reviewed by iklam (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27517#pullrequestreview-3273004033
More information about the hotspot-runtime-dev
mailing list