RFR: 8368818: Remove duplicate dtrace macros

Francesco Andreuzzi fandreuzzi at openjdk.org
Mon Sep 29 14:10:02 UTC 2025


On Mon, 29 Sep 2025 04:34:11 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I propose to move the following macros and constants definition to `objectMonitor.hpp`:
>> 
>> DTRACE_MONITOR_PROBE_COMMON
>> DTRACE_MONITOR_WAIT_PROBE
>> DTRACE_MONITOR_PROBE
>> HOTSPOT_MONITOR_notify
>> HOTSPOT_MONITOR_notifyAll
>> 
>> They are defined both in `objectMonitor.cpp` and `synchronizer.cpp`.
>> 
>> Passes tier1 (fastdebug) with `--enable-jvm-feature-dtrace`.
>
> Also `objectMonitor.hpp` should now be including all the headers needed to actually compile these macros - which also seems undesirable.

Hi @dholmes-ora, thanks for the feedback. Makes sense to me, I'll close the PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27538#issuecomment-3347182744


More information about the hotspot-runtime-dev mailing list