RFR: 8367981: Update CompactHashtable for readability [v5]
Matias Saavedra Silva
matsaave at openjdk.org
Mon Sep 29 14:46:24 UTC 2025
On Wed, 24 Sep 2025 08:34:33 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Hi,
>> Can you help to review this patch?
>>
>> The comments of CompactHashtable and related classes are out of date, and some comments are unclear, wrong or misleading.
>> As the related classes are used in more and more scenarios, it's helpful to update the comments.
>>
>> To improve readability (of both the source code and the comments), we should also rename some of the field/parameters to distinguish between the type V (the "value " stored inside the table; it could be a 64-bit pointer) vs "encoded value" (the 32-bit representation of V in the CompactHashtable storage).
>>
>> Thanks
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>
> rename 2
LGTM!
-------------
Marked as reviewed by matsaave (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27360#pullrequestreview-3280249043
More information about the hotspot-runtime-dev
mailing list