RFR: 8368818: Remove duplicate dtrace macros
David Holmes
dholmes at openjdk.org
Tue Sep 30 07:20:16 UTC 2025
On Mon, 29 Sep 2025 15:05:38 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/runtime/synchronizer.cpp line 218:
>>
>>> 216: // TODO-FIXME: probes should not fire when caller is _blocked. assert() accordingly.
>>> 217:
>>> 218: #define DTRACE_MONITOR_PROBE_COMMON(obj, thread) \
>>
>> I agree that these shouldn't be in objectMonitor.hpp file. With Legacy locking removed, are these still needed in synchronizer.cpp ?
>
> It would be nice to understand why these are used in general.
These are the DTrace probe points. Whether anyone still uses them ...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27538#discussion_r2390119031
More information about the hotspot-runtime-dev
mailing list