Integrated: 8367981: Update CompactHashtable for readability
Hamlin Li
mli at openjdk.org
Tue Sep 30 08:14:44 UTC 2025
On Thu, 18 Sep 2025 10:53:25 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this patch?
>
> The comments of CompactHashtable and related classes are out of date, and some comments are unclear, wrong or misleading.
> As the related classes are used in more and more scenarios, it's helpful to update the comments.
>
> To improve readability (of both the source code and the comments), we should also rename some of the field/parameters to distinguish between the type V (the "value " stored inside the table; it could be a 64-bit pointer) vs "encoded value" (the 32-bit representation of V in the CompactHashtable storage).
>
> Thanks
This pull request has now been integrated.
Changeset: c0a4c0ba
Author: Hamlin Li <mli at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/c0a4c0ba97284d55cfdf857eb5d41fd6189e6c2d
Stats: 83 lines in 2 files changed: 22 ins; 16 del; 45 mod
8367981: Update CompactHashtable for readability
Reviewed-by: iklam, matsaave
-------------
PR: https://git.openjdk.org/jdk/pull/27360
More information about the hotspot-runtime-dev
mailing list