RFR: 8292984: Refactor internal container-related interfaces for clarity [v2]
Casper Norrbin
cnorrbin at openjdk.org
Tue Sep 30 09:58:55 UTC 2025
On Tue, 30 Sep 2025 09:46:48 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Casper Norrbin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' into linux-container-mem-restructure
>> - keep cgroupsubsystem separate
>> - keep os::linux separate
>
> src/hotspot/os/linux/cgroupSubsystem_linux.cpp line 674:
>
>> 672: return memory_limit->value();
>> 673: }
>> 674: jlong mem_limit = contrl->controller()->read_memory_limit_in_bytes(upper_bound);
>
> This removes the logging at the trace level for the upper bound. Intentional?
Yes, it was intentional. Both cgroup v1/v2 already log the upper bound in `read_memory_limit_in_bytes()` at debug level, along with more information. It felt unnecessary logging the same value twice.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27470#discussion_r2390652794
More information about the hotspot-runtime-dev
mailing list