RFR: 8370314: Update signals_posix with new Linux signal codes [v2]
David Holmes
dholmes at openjdk.org
Thu Jan 8 07:47:25 UTC 2026
On Thu, 8 Jan 2026 07:30:19 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Looks reasonable, thanks.
Thanks for the review @shipilev
> I wish we could check the hard-coded values with the actual exported values (when available in building with newer GCC), but that is likely hard to do at preprocessor level.
`static_assert` in the else of the `#ifndef`? I can try that - though we make assumptions about these sorts of things anyway e.g. SYS_call values. And I don't think these are values that can ever be changed once glibc is exporting them, so we have captured the right value.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29105#issuecomment-3722524674
More information about the hotspot-runtime-dev
mailing list