RFR: 8325108: POSIX map_memory_to_file calls release_memory unnecessarily [v2]

Coleen Phillimore coleenp at openjdk.org
Thu Jan 8 23:21:47 UTC 2026


On Thu, 8 Jan 2026 18:29:06 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/os/posix/os_posix.cpp line 460:
>> 
>>> 458:     return nullptr;
>>> 459:   }
>>> 460:   if (base != nullptr && addr != base) {
>> 
>> Can you turn this into an assert with a comment in the assert string why this isn't possible?
>
> Fixed!

I like the assert!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29081#discussion_r2674225286


More information about the hotspot-runtime-dev mailing list