RFR: 8374721: containers/docker/ShareTmpDir.java timed out after 8362087

SendaoYan syan at openjdk.org
Fri Jan 9 02:10:52 UTC 2026


On Thu, 8 Jan 2026 15:36:17 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Hi all,
>> 
>> Sorry for the regression issue introduced by JDK-8362087. 
>> 
>> In the original code of JDK-8362087, before starting the first thread, a parameter was added to the global `DockerRunOptions` object, then the first Java thread was started, and within that thread, the first test Java process was launched. Immediately afterwards, a second parameter was added, and then a second Java thread was started, also launching a second test Java process. It was possible that when starting the second test Java process, the global `DockerRunOptions` object had already been assigned the second parameter, resulting in both test Java processes having identical parameters (two parameters each); whereas the original expectation was that the first Java process would have only one parameter, and the second would have two.
>> 
>> This PR fixed this bug. Adding the second parameter to the global `DockerRunOptions` object only after the first Java process has fully started ensures that both processes will have identical parameters.
>> 
>> Change has been verified locally on linux-x64 by run the test 100 times and all passed.
>
> Marked as reviewed by sgehwolf (Reviewer).

Thanks for the reviews @jerboaa @caspernorrbin

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29093#issuecomment-3726737162


More information about the hotspot-runtime-dev mailing list