RFR: 8373366: HandshakeState should disallow suspend ops for disabler threads [v8]
Serguei Spitsyn
sspitsyn at openjdk.org
Sat Jan 10 08:15:59 UTC 2026
> An asynchronous handshake operation (`ThreadSelfSuspensionHandshakeClosure`) can be installed when the target thread is not in a `MountUnmountDisabler` scope. But the target thread can enter such scope by the time the operation is self-processed by the target thread.
>
> This is fixed by a small tweak in the function
> `HandshakeOperation* HandshakeState::get_op_for_self(bool allow_suspend, bool check_async_exception)`.
> The tweak is to skip a `HandshakeOperation` if `_handshakee->is_vthread_transition_disabler() == true`, so the same temporary suspension disabling mechanism would be used as for `_handshakee->is_disable_suspend() == true`.
>
> All other changes are to move the `is_vthread_transition_disabler()` out of DEBUG to product.
>
> Testing:
> - In progress: mach5 tiers 1-6
Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
review: add a test reproducing the bug
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28740/files
- new: https://git.openjdk.org/jdk/pull/28740/files/0405cb63..052a04cd
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28740&range=07
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28740&range=06-07
Stats: 251 lines in 2 files changed: 251 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/28740.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28740/head:pull/28740
PR: https://git.openjdk.org/jdk/pull/28740
More information about the hotspot-runtime-dev
mailing list