RFR: 8370112: Remove VM_Version::supports_fast_class_init_checks() in platform-specific code

Aleksey Shipilev shade at openjdk.org
Mon Jan 19 08:17:14 UTC 2026


On Mon, 19 Jan 2026 04:34:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Please review this simple enhancement to remove runtime checks for `VM_Version::supports_fast_class_init_checks()` in platform specific code, and replace them with asserts - as we know statically whether a given platform supports it.
> 
> The changes are the same for each platform.
> 
> Testing
>  - building all platforms via GHA
>  - tiers 1-3 (sanity)
> 
> Thanks

Looks reasonable, and similar to C1/C2 does.

src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 728:

> 726:   Label L_skip_barrier;
> 727: 
> 728:   { // Bypass the barrier for non-static methods

Not entirely sure what extra `{ ... }` block is supposed to do here. Since you are changing these lines, maybe collapse it one indenting level down?

-------------

PR Review: https://git.openjdk.org/jdk/pull/29293#pullrequestreview-3676807568
PR Review Comment: https://git.openjdk.org/jdk/pull/29293#discussion_r2703674670


More information about the hotspot-runtime-dev mailing list