RFR: 8366659: ObjectMonitor::wait() liveness problem with a suspension request [v26]
David Holmes
dholmes at openjdk.org
Wed Jan 21 05:25:58 UTC 2026
On Wed, 21 Jan 2026 04:48:00 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> src/hotspot/share/runtime/objectMonitor.cpp line 1933:
>>
>>> 1931: // Post monitor waited event. Note that this is past-tense, we are done waiting.
>>> 1932: // A thread which should post monitor_waited event is never in TS_ENTER state.
>>> 1933: if (JvmtiExport::should_post_monitor_waited()) {
>>
>> Is it worth asserting that `node.TState != ObjectWaiter::TS_ENTER` inside the if-statement?
>
> I think we will have to add it as a branch condition since the event could have been enabled after notification.
If the event can be enabled (and disabled?) dynamically then that changes a lot! We can't use the event state as a proxy for TS_RUN state (nor vice-versa).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27040#discussion_r2711012799
More information about the hotspot-runtime-dev
mailing list