RFR: 8374998: Failing os::write - remove bad file

Lutz Schmidt lucy at openjdk.org
Wed Jan 21 13:59:58 UTC 2026


On Wed, 14 Jan 2026 11:15:35 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> In filemap.cpp there is error - handling for os::write and in case of failure a 'bad' potentially incomplete file is removed.
> https://github.com/openjdk/jdk/blob/1b6c2bdd7b57891ed35e3c067871d2c0bf282824/src/hotspot/share/cds/filemap.cpp#L1059-L1062
> This should probably be done also in other coding.

Looks good for transient files.
For files containing "real" data, I would require verification that it's a file corruption issue and not just a (temporary) access issue.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29228#pullrequestreview-3687381555


More information about the hotspot-runtime-dev mailing list