<i18n dev> &lt; i18n dev&gt; Request for review: Crash on XIM server restart

Naoto Sato naoto.sato at oracle.com
Tue Sep 21 10:40:21 PDT 2010

Looks good to me.


(9/20/10 7:33 AM), Omair Majid wrote:
> Hi,
> Naoto Sato<naoto.sato at ...>  writes:
>> Thank you for catching the error. I think your fix is fine but would
>> like some comments noting that the extra call to getX11InputMethodData()
>> in DestroyXIMCallback is merely to free up the pX11IMData, otherwise,
>> the call is kind of cryptic.
> Thanks for reviewing the patch! Updated webrev is available at:
> http://cr.openjdk.java.net/~omajid/webrevs/crash-on-xim-server-restart/webrev.01/
> Thanks,
> Omair

More information about the i18n-dev mailing list