<i18n dev> &lt; i18n dev&gt; Request for review: Crash on XIM server restart

[Naoto Sato]

(9/22/10 7:09 AM), Omair Majid wrote:
> Hi,
>
> On 09/21/2010 01:40 PM, Naoto Sato wrote:
>> Looks good to me.
>>
>> Naoto
>
> Thanks for the review. Should I use the swing forest to push this change
> (which I believe is what the i18n group uses) or the awt forest?

Swing forest is just fine.

>
> Also, is it possible to get a bug id for this?

I am not familiar with this process, but according to this page 
(http://openjdk.java.net/contribute/), you can create a new bug report 
in the OpenJDK Bugzilla.

Naoto

>
> Thanks,
> Omair
>
>>
>> (9/20/10 7:33 AM), Omair Majid wrote:
>>> Hi,
>>>
>>> Naoto Sato<naoto.sato at ...> writes:
>>>>
>>>> Thank you for catching the error. I think your fix is fine but would
>>>> like some comments noting that the extra call to
>>>> getX11InputMethodData()
>>>> in DestroyXIMCallback is merely to free up the pX11IMData, otherwise,
>>>> the call is kind of cryptic.
>>>>
>>>
>>> Thanks for reviewing the patch! Updated webrev is available at:
>>> http://cr.openjdk.java.net/~omajid/webrevs/crash-on-xim-server-restart/webrev.01/
>>>
>>>
>>>
>>> Thanks,
>>> Omair
>>>
>>
>