<i18n dev> Maybe some not useful code in sun.awt.im.InputContext

Naoto Sato naoto.sato at oracle.com
Tue Dec 6 16:59:27 PST 2011


The code in question was introduced with this RFE:

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4293626

I don't think we have automated regression tests for this one. Test team 
might have some manual tests, but not sure as this is very old code. Sorry.

Naoto

On 12/5/11 6:33 PM, Charles Lee wrote:
> On 12/06/2011 03:16 AM, Naoto Sato wrote:
>> Hi Charles,
>>
>> Even though your finding below sounds right, I would not remove that
>> piece of code, unless we are sure that it would not cause any regression.
>>
>> Naoto
>>
>> On 12/2/11 9:45 AM, Neil Richards wrote:
>>> On Fri, 2011-12-02 at 16:53 +0800, Charles Lee wrote:
>>>> Hi guys,
>>>>
>>>> I am doing some code reading through the input method framework. Once I
>>>> meet sun.awt.im.InputContext, I find the code (line 228), it says:
>>>>
>>>> // Ignore focus events that relate to the InputMethodWindow of this
>>>> context.
>>>> // This is a workaround. Should be removed after 4452384 is fixed.
>>>>
>>>> Does 4452384 mean:
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4452384 ?
>>>>
>>>> If it is, 4452384 has been fixed.
>>>>
>>>> Should the code below be removed?
>>>>
>>>
>>> Hi Charles,
>>> Judging by the ownership list held by the '2d' group [1],
>>> sun.awt.im.InputContext is owned by the 'i18n' group.
>>>
>>> Based on this, I'm moving this conversation across to the 'i18n-dev'
>>> mailing list, so the folk there can consider your observation.
>>>
>>> Regards, Neil
>>>
>>> [1] http://openjdk.java.net/groups/2d/2dawtfiles.html
>>>
>>
> Hi Naoto,
>
> Do we have some regression test for this issue? I can help to test it.
>



More information about the i18n-dev mailing list