From masayoshi.okutsu at oracle.com  Sun Dec  2 21:23:26 2012
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Mon, 03 Dec 2012 14:23:26 +0900
Subject: <i18n dev> [8] Code review request: 8000983 and 8003267
Message-ID: <50BC374E.6050908@oracle.com>

Hi,

This is a review request for two RFEs.

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267

http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/

I haven't added generic time zone names to the JRE resources except for 
the "en" resources. I've filed another RFE for this item (JDK-8004278).

Thanks,
Masayoshi


From masayoshi.okutsu at oracle.com  Wed Dec  5 21:06:20 2012
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Thu, 06 Dec 2012 14:06:20 +0900
Subject: <i18n dev>  [8] Code review request: 8000983 and 8003267
Message-ID: <50C027CC.9060002@oracle.com>

Resending in order to include build-dev at openjdk.java.net and 
build-infra at openjdk.dev.java.net.

Hi,

This is a review request for two RFEs.

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267

http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/

I haven't added generic time zone names to the JRE resources except for 
the "en" resources. I've filed another RFE for this item (JDK-8004278).

Thanks,
Masayoshi


From erik.joelsson at oracle.com  Thu Dec  6 03:36:35 2012
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Thu, 06 Dec 2012 12:36:35 +0100
Subject: <i18n dev> [8] Code review request: 8000983 and 8003267
In-Reply-To: <50C027CC.9060002@oracle.com>
References: <50C027CC.9060002@oracle.com>
Message-ID: <50C08343.80305@oracle.com>

(resending to all recepients)

I don't see any changes to the build except for java classes in the 
cldrconverter build tool. This shouldn't affect the new build, so it's 
ok with the build group.

/Erik

On 2012-12-06 06:06, Masayoshi Okutsu wrote:
> Resending in order to include build-dev at openjdk.java.net and 
> build-infra at openjdk.dev.java.net.
>
> Hi,
>
> This is a review request for two RFEs.
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
>
> http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/
>
> I haven't added generic time zone names to the JRE resources except 
> for the "en" resources. I've filed another RFE for this item 
> (JDK-8004278).
>
> Thanks,
> Masayoshi
>

From naoto.sato at oracle.com  Thu Dec  6 12:49:39 2012
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 06 Dec 2012 12:49:39 -0800
Subject: <i18n dev> [8] Code review request: 8000983 and 8003267
In-Reply-To: <50C027CC.9060002@oracle.com>
References: <50C027CC.9060002@oracle.com>
Message-ID: <50C104E3.5030503@oracle.com>

Here are my comments:

- Bundle.java

Line 277,297: Do we need two separate iteration loops here? Two 
iteration loops look like the same.

Line 303: typo "paris"

Line 606: typo "Someting"

Line 728: Could use foreach here.

- CLDRConverter.java

Line 388: The FormatData bundle is now "OPEN", which used to be "PLAIN"?

- FormatData_xx.java

Line: xxx: In some resource bundles, the array for DayNarrows duplicates 
other array. Can be combined with it like in FormatData.java 
buddhist/japanese ones.

- CalendarNameProviderImpl.java

Line 84: The int[] can be statically created.

- LocaleResources.java

Line 74: Variable name "olrb" stands for OpenListResourceBundle, so 
"tznb" would better fit here.

Naoto

On 12/5/12 9:06 PM, Masayoshi Okutsu wrote:
> Resending in order to include build-dev at openjdk.java.net and
> build-infra at openjdk.dev.java.net.
>
> Hi,
>
> This is a review request for two RFEs.
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
>
> http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/
>
> I haven't added generic time zone names to the JRE resources except for
> the "en" resources. I've filed another RFE for this item (JDK-8004278).
>
> Thanks,
> Masayoshi
>


From masayoshi.okutsu at oracle.com  Fri Dec  7 08:05:45 2012
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Sat, 08 Dec 2012 01:05:45 +0900
Subject: <i18n dev> [8] Code review request: 8000983 and 8003267
In-Reply-To: <50C104E3.5030503@oracle.com>
References: <50C027CC.9060002@oracle.com> <50C104E3.5030503@oracle.com>
Message-ID: <50C213D9.60007@oracle.com>

Thank you for your review comments.

On 12/7/2012 5:49 AM, Naoto Sato wrote:
> Here are my comments:
>
> - Bundle.java
>
> Line 277,297: Do we need two separate iteration loops here? Two 
> iteration loops look like the same.

These loops need to be separated to make inheritance work correctly.

> Line 303: typo "paris"
> Line 606: typo "Someting"

Fixed.

> Line 728: Could use foreach here.

I'm hoping it can avoid one assignment. But probably no difference after 
optimization.

>
> - CLDRConverter.java
>
> Line 388: The FormatData bundle is now "OPEN", which used to be "PLAIN"?

Fixed.

> - FormatData_xx.java
>
> Line: xxx: In some resource bundles, the array for DayNarrows 
> duplicates other array. Can be combined with it like in 
> FormatData.java buddhist/japanese ones.

Yes, but it's a lot of work. And that change may make test data 
maintenance difficult. Unchanged (for now).

>
> - CalendarNameProviderImpl.java
>
> Line 84: The int[] can be statically created.

Fixed.

>
> - LocaleResources.java
>
> Line 74: Variable name "olrb" stands for OpenListResourceBundle, so 
> "tznb" would better fit here.

Fixed.

In addition, GenericTimeZoneNamesTest.sh and NarrowNamesTest.sh were 
fixed to detect failures correctly. No other changes.

Updated webrev:

http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.01/

Thanks,
Masayoshi

>
> Naoto
>
> On 12/5/12 9:06 PM, Masayoshi Okutsu wrote:
>> Resending in order to include build-dev at openjdk.java.net and
>> build-infra at openjdk.dev.java.net.
>>
>> Hi,
>>
>> This is a review request for two RFEs.
>>
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
>>
>> http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/
>>
>> I haven't added generic time zone names to the JRE resources except for
>> the "en" resources. I've filed another RFE for this item (JDK-8004278).
>>
>> Thanks,
>> Masayoshi
>>
>


From masayoshi.okutsu at oracle.com  Fri Dec  7 08:08:24 2012
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Sat, 08 Dec 2012 01:08:24 +0900
Subject: <i18n dev> [8] Code review request: 8000983 and 8003267
In-Reply-To: <50C08343.80305@oracle.com>
References: <50C027CC.9060002@oracle.com> <50C08343.80305@oracle.com>
Message-ID: <50C21478.7030001@oracle.com>

Thank you for your review. I thought so too, but I followed the rule for 
make/* changes.

Masayoshi

On 12/6/2012 8:36 PM, Erik Joelsson wrote:
> (resending to all recepients)
>
> I don't see any changes to the build except for java classes in the 
> cldrconverter build tool. This shouldn't affect the new build, so it's 
> ok with the build group.
>
> /Erik
>
> On 2012-12-06 06:06, Masayoshi Okutsu wrote:
>> Resending in order to include build-dev at openjdk.java.net and 
>> build-infra at openjdk.dev.java.net.
>>
>> Hi,
>>
>> This is a review request for two RFEs.
>>
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
>>
>> http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/
>>
>> I haven't added generic time zone names to the JRE resources except 
>> for the "en" resources. I've filed another RFE for this item 
>> (JDK-8004278).
>>
>> Thanks,
>> Masayoshi
>>


From naoto.sato at oracle.com  Fri Dec  7 08:18:47 2012
From: naoto.sato at oracle.com (Naoto Sato)
Date: Fri, 07 Dec 2012 08:18:47 -0800
Subject: <i18n dev> [8] Code review request: 8000983 and 8003267
In-Reply-To: <50C213D9.60007@oracle.com>
References: <50C027CC.9060002@oracle.com> <50C104E3.5030503@oracle.com>
	<50C213D9.60007@oracle.com>
Message-ID: <50C216E7.6070601@oracle.com>

Thank you, Okutsu-san. It looks good to me now.

Naoto

On 12/7/12 8:05 AM, Masayoshi Okutsu wrote:
> Thank you for your review comments.
>
> On 12/7/2012 5:49 AM, Naoto Sato wrote:
>> Here are my comments:
>>
>> - Bundle.java
>>
>> Line 277,297: Do we need two separate iteration loops here? Two
>> iteration loops look like the same.
>
> These loops need to be separated to make inheritance work correctly.
>
>> Line 303: typo "paris"
>> Line 606: typo "Someting"
>
> Fixed.
>
>> Line 728: Could use foreach here.
>
> I'm hoping it can avoid one assignment. But probably no difference after
> optimization.
>
>>
>> - CLDRConverter.java
>>
>> Line 388: The FormatData bundle is now "OPEN", which used to be "PLAIN"?
>
> Fixed.
>
>> - FormatData_xx.java
>>
>> Line: xxx: In some resource bundles, the array for DayNarrows
>> duplicates other array. Can be combined with it like in
>> FormatData.java buddhist/japanese ones.
>
> Yes, but it's a lot of work. And that change may make test data
> maintenance difficult. Unchanged (for now).
>
>>
>> - CalendarNameProviderImpl.java
>>
>> Line 84: The int[] can be statically created.
>
> Fixed.
>
>>
>> - LocaleResources.java
>>
>> Line 74: Variable name "olrb" stands for OpenListResourceBundle, so
>> "tznb" would better fit here.
>
> Fixed.
>
> In addition, GenericTimeZoneNamesTest.sh and NarrowNamesTest.sh were
> fixed to detect failures correctly. No other changes.
>
> Updated webrev:
>
> http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.01/
>
> Thanks,
> Masayoshi
>
>>
>> Naoto
>>
>> On 12/5/12 9:06 PM, Masayoshi Okutsu wrote:
>>> Resending in order to include build-dev at openjdk.java.net and
>>> build-infra at openjdk.dev.java.net.
>>>
>>> Hi,
>>>
>>> This is a review request for two RFEs.
>>>
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
>>>
>>> http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/
>>>
>>> I haven't added generic time zone names to the JRE resources except for
>>> the "en" resources. I've filed another RFE for this item (JDK-8004278).
>>>
>>> Thanks,
>>> Masayoshi
>>>
>>
>


From michael.fang at oracle.com  Sun Dec  9 21:23:36 2012
From: michael.fang at oracle.com (Michael Fang)
Date: Sun, 09 Dec 2012 21:23:36 -0800
Subject: <i18n dev> [8] Code review request: 8000983 and 8003267
In-Reply-To: <50C027CC.9060002@oracle.com>
References: <50C027CC.9060002@oracle.com>
Message-ID: <50C571D8.7050606@oracle.com>

Hi Okutsu-san,

Do you have a way to provide some sort of converter to make time zone 
name translation that can be handled by WPTG translation team? They 
currently cannot translate the file in existing format (they can 
translate properties files or basic java resource bundles).

thanks,

-michael

On 12?12?05? 09:06 ??, Masayoshi Okutsu wrote:
> Resending in order to include build-dev at openjdk.java.net and 
> build-infra at openjdk.dev.java.net.
>
> Hi,
>
> This is a review request for two RFEs.
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
>
> http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/
>
> I haven't added generic time zone names to the JRE resources except 
> for the "en" resources. I've filed another RFE for this item 
> (JDK-8004278).
>
> Thanks,
> Masayoshi
>


From masayoshi.okutsu at oracle.com  Sun Dec  9 22:36:50 2012
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Mon, 10 Dec 2012 15:36:50 +0900
Subject: <i18n dev> [8] Code review request: 8000983 and 8003267
In-Reply-To: <50C571D8.7050606@oracle.com>
References: <50C027CC.9060002@oracle.com> <50C571D8.7050606@oracle.com>
Message-ID: <50C58302.3030006@oracle.com>

Hi Michael,

I do remember your request about the translatable format, but I haven't 
had a chance to address it. The format hasn't changed. Sorry about this.

Masayoshi

On 12/10/2012 2:23 PM, Michael Fang wrote:
> Hi Okutsu-san,
>
> Do you have a way to provide some sort of converter to make time zone 
> name translation that can be handled by WPTG translation team? They 
> currently cannot translate the file in existing format (they can 
> translate properties files or basic java resource bundles).
>
> thanks,
>
> -michael
>
> On 12?12?05? 09:06 ??, Masayoshi Okutsu wrote:
>> Resending in order to include build-dev at openjdk.java.net and 
>> build-infra at openjdk.dev.java.net.
>>
>> Hi,
>>
>> This is a review request for two RFEs.
>>
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
>>
>> http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/
>>
>> I haven't added generic time zone names to the JRE resources except 
>> for the "en" resources. I've filed another RFE for this item 
>> (JDK-8004278).
>>
>> Thanks,
>> Masayoshi
>>
>


From michael.fang at oracle.com  Tue Dec 11 19:07:53 2012
From: michael.fang at oracle.com (Michael Fang)
Date: Tue, 11 Dec 2012 19:07:53 -0800
Subject: <i18n dev> [8] Code review request: 8000983 and 8003267
In-Reply-To: <50C58302.3030006@oracle.com>
References: <50C027CC.9060002@oracle.com> <50C571D8.7050606@oracle.com>
	<50C58302.3030006@oracle.com>
Message-ID: <50C7F509.4070202@oracle.com>

Hi Masayoshi,

I see. Are you able to think of some solution by 1/30 (next jdk8 
translation drop)?

Without a supported translation format, the l10n files will just sit 
there without update...

thanks,

-michael

On 2012/12/9 ?? 10:36, Masayoshi Okutsu wrote:
> Hi Michael,
>
> I do remember your request about the translatable format, but I 
> haven't had a chance to address it. The format hasn't changed. Sorry 
> about this.
>
> Masayoshi
>
> On 12/10/2012 2:23 PM, Michael Fang wrote:
>> Hi Okutsu-san,
>>
>> Do you have a way to provide some sort of converter to make time zone 
>> name translation that can be handled by WPTG translation team? They 
>> currently cannot translate the file in existing format (they can 
>> translate properties files or basic java resource bundles).
>>
>> thanks,
>>
>> -michael
>>
>> On 12?12?05? 09:06 ??, Masayoshi Okutsu wrote:
>>> Resending in order to include build-dev at openjdk.java.net and 
>>> build-infra at openjdk.dev.java.net.
>>>
>>> Hi,
>>>
>>> This is a review request for two RFEs.
>>>
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
>>>
>>> http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.00/
>>>
>>> I haven't added generic time zone names to the JRE resources except 
>>> for the "en" resources. I've filed another RFE for this item 
>>> (JDK-8004278).
>>>
>>> Thanks,
>>> Masayoshi
>>>
>>
>


From yuka.kamiya at oracle.com  Thu Dec 27 01:01:07 2012
From: yuka.kamiya at oracle.com (Yuka Kamiya)
Date: Thu, 27 Dec 2012 18:01:07 +0900
Subject: <i18n dev> Code Review request (8005277)
Message-ID: <50DC0E53.9010708@oracle.com>

Hello,

This is a review request for:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005277

http://cr.openjdk.java.net/~peytoia/8005277/webrev.00/

Thanks,
--
Yuka

From masayoshi.okutsu at oracle.com  Thu Dec 27 06:39:12 2012
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Thu, 27 Dec 2012 23:39:12 +0900
Subject: <i18n dev> Code Review request (8005277)
In-Reply-To: <50DC0E53.9010708@oracle.com>
References: <50DC0E53.9010708@oracle.com>
Message-ID: <50DC5D90.60803@oracle.com>

Looks good to me.

Thanks,
Masayoshi

On 12/27/2012 6:01 PM, Yuka Kamiya wrote:
> Hello,
>
> This is a review request for:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005277
>
> http://cr.openjdk.java.net/~peytoia/8005277/webrev.00/
>
> Thanks,
> --
> Yuka


From masayoshi.okutsu at oracle.com  Thu Dec 27 19:26:30 2012
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Fri, 28 Dec 2012 12:26:30 +0900
Subject: <i18n dev> [8] Code review request: 8005471
Message-ID: <50DD1166.7050909@oracle.com>

Hi,

This is a code review request for:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005471

Webrev:
http://cr.openjdk.java.net/~okutsu/8/8005471/webrev.00/

Thanks,
Masayoshi


From yuka.kamiya at oracle.com  Thu Dec 27 20:30:12 2012
From: yuka.kamiya at oracle.com (Yuka Kamiya)
Date: Fri, 28 Dec 2012 13:30:12 +0900
Subject: <i18n dev> [8] Code review request: 8005471
In-Reply-To: <50DD1166.7050909@oracle.com>
References: <50DD1166.7050909@oracle.com>
Message-ID: <50DD2054.7050105@oracle.com>

Hi,

It looks ok to me.

Thanks,
--
Yuka

(12/12/28 12:26), Masayoshi Okutsu wrote:
> Hi,
>
> This is a code review request for:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005471
>
> Webrev:
> http://cr.openjdk.java.net/~okutsu/8/8005471/webrev.00/
>
> Thanks,
> Masayoshi
>


From masayoshi.okutsu at oracle.com  Thu Dec 27 23:30:11 2012
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Fri, 28 Dec 2012 16:30:11 +0900
Subject: <i18n dev> [8] Code review request: 8005561
Message-ID: <50DD4A83.5040301@oracle.com>

Hi,

This is a code review request for:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005561
(This CR isn't viewable on bugs.sun.com yet.)

Webrev:
http://cr.openjdk.java.net/~okutsu/8/8005561/webrev.00/

Thanks,
Masayoshi


From yuka.kamiya at oracle.com  Thu Dec 27 23:40:06 2012
From: yuka.kamiya at oracle.com (Yuka Kamiya)
Date: Fri, 28 Dec 2012 16:40:06 +0900
Subject: <i18n dev> [8] Code review request: 8005561
In-Reply-To: <50DD4A83.5040301@oracle.com>
References: <50DD4A83.5040301@oracle.com>
Message-ID: <50DD4CD6.5080705@oracle.com>

Hi,

It looks good to me.

Thanks,
--
Yuka

(12/12/28 16:30), Masayoshi Okutsu wrote:
> Hi,
>
> This is a code review request for:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005561
> (This CR isn't viewable on bugs.sun.com yet.)
>
> Webrev:
> http://cr.openjdk.java.net/~okutsu/8/8005561/webrev.00/
>
> Thanks,
> Masayoshi
>