From youdwei at linux.vnet.ibm.com  Sun Mar  4 21:52:35 2012
From: youdwei at linux.vnet.ibm.com (Deven)
Date: Mon, 05 Mar 2012 13:52:35 +0800
Subject: <i18n dev> Locale patch for Slovenian date format data: dots are
 missed in the datetime for Slovanian
Message-ID: <4F5454A3.6060907@linux.vnet.ibm.com>

Hi i18n-devs,

I find there is a problem in Slovenian Locale. In Slovenian Locale, days 
in a date must with a dot '.', like Oct 23rd 2011 will be 23. oktober 
2011. Without the '.', 23 oktober 2011 basically means Twenty-three of 
October, instead of the Twenty-third of October.

Current oracle 6/7/8 all miss the dot '.', so this patch [1] will add 
dot after the days to correct the date expression in Slovenian Locale.

The attached test case [2] shows the the diffrence with/without this 
patch. The output of this test case are:

without this patch:
Ponedeljek, 5 marec 2012

with this patch:
Ponedeljek, 5. marec 2012

This test case may not be very useful, so I hope anyone can give me some 
suggestions about how to refine the test case?

[1] http://cr.openjdk.java.net/~youdwei/slovenian_formatData/webrev.00/ 
<http://cr.openjdk.java.net/%7Eyoudwei/slovenian_formatData/webrev.00/>

[2] SlovenianFormatDataTest.java

Thanks a lot!

-- 
Best Regards
Deven

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SlovenianFormatDataTest.java
Type: text/x-java
Size: 402 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/i18n-dev/attachments/20120305/b7b1df32/SlovenianFormatDataTest.java 

From mark.reinhold at oracle.com  Mon Mar  5 14:25:05 2012
From: mark.reinhold at oracle.com (mark.reinhold at oracle.com)
Date: Mon,  5 Mar 2012 14:25:05 -0800 (PST)
Subject: <i18n dev> JEP 151: Compress Time-Zone Data
Message-ID: <20120305222505.1F9C85DE@eggemoggin.niobe.net>

Posted: http://openjdk.java.net/jeps/151

- Mark

From darryl.mocek at oracle.com  Mon Mar  5 15:04:59 2012
From: darryl.mocek at oracle.com (Darryl Mocek)
Date: Mon, 05 Mar 2012 15:04:59 -0800
Subject: <i18n dev> JEP 151: Compress Time-Zone Data
In-Reply-To: <20120305222505.1F9C85DE@eggemoggin.niobe.net>
References: <20120305222505.1F9C85DE@eggemoggin.niobe.net>
Message-ID: <4F55469B.6080106@oracle.com>

Mark,

   this JEP has been canceled in favor of JSR-310, which will reduce 
the time zone data in a different way.

Darryl

On Mon 05 Mar 2012 02:25:05 PM PST, mark.reinhold at oracle.com wrote:
> Posted: http://openjdk.java.net/jeps/151
>
> - Mark

From mark.reinhold at oracle.com  Tue Mar  6 08:07:08 2012
From: mark.reinhold at oracle.com (mark.reinhold at oracle.com)
Date: Tue, 06 Mar 2012 08:07:08 -0800
Subject: <i18n dev> JEP 151: Compress Time-Zone Data
In-Reply-To: darryl.mocek@oracle.com; Mon, 05 Mar 2012 15:04:59 PST;
	<4F55469B.6080106@oracle.com>
Message-ID: <20120306160708.CFB6B4A3@eggemoggin.niobe.net>

2012/3/5 15:04 -0800, darryl.mocek at oracle.com:
>   this JEP has been canceled in favor of JSR-310, which will reduce the time
> zone data in a different way.

Okay.  I've moved 151 to withdrawn.

- Mark

From Alan.Bateman at oracle.com  Mon Mar 12 04:04:03 2012
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Mon, 12 Mar 2012 11:04:03 +0000
Subject: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on
 linux when symbolic links to non default location used.
In-Reply-To: <4F5A2901.2050404@oracle.com>
References: <4F5A2901.2050404@oracle.com>
Message-ID: <4F5DD823.50309@oracle.com>

On 09/03/2012 16:00, Se?n Coffey wrote:
> Issue seen on somewhat irregular linux system configuration where 
> /etc/localtime is a symbolic link to a directory outside of 
> /usr/share/zoneinfo.
>
> In past, when a symbolic link was seen, the end target file was 
> assumed to be under /usr/share/zoneinfo and a string comparison match 
> was attempted. We need to factor in the case where symbolic link 
> points to any other location and match the end target file with a TZ 
> file from
> /usr/share/zoneinfo via findZoneinfoFile function.
>
> webrev : http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8/
> bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7149608
>
> regards,
> Sean.
>
cc'ing i18n-dev as that is where the TZ code is maintained.

The changes look okay but I think it would be more efficient to fstat 
the zone info file after opening it.

-Alan


From sean.coffey at oracle.com  Mon Mar 12 07:31:05 2012
From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=)
Date: Mon, 12 Mar 2012 14:31:05 +0000
Subject: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on
 linux when symbolic links to non default location used.
In-Reply-To: <4F5DD823.50309@oracle.com>
References: <4F5A2901.2050404@oracle.com> <4F5DD823.50309@oracle.com>
Message-ID: <4F5E08A9.7050507@oracle.com>

Ok - good point on the stat change Alan. I think this is what you're after :

http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.2/

regards,
Sean.

On 12/03/12 11:04, Alan Bateman wrote:
> On 09/03/2012 16:00, Se?n Coffey wrote:
>> Issue seen on somewhat irregular linux system configuration where 
>> /etc/localtime is a symbolic link to a directory outside of 
>> /usr/share/zoneinfo.
>>
>> In past, when a symbolic link was seen, the end target file was 
>> assumed to be under /usr/share/zoneinfo and a string comparison match 
>> was attempted. We need to factor in the case where symbolic link 
>> points to any other location and match the end target file with a TZ 
>> file from
>> /usr/share/zoneinfo via findZoneinfoFile function.
>>
>> webrev : http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8/
>> bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7149608
>>
>> regards,
>> Sean.
>>
> cc'ing i18n-dev as that is where the TZ code is maintained.
>
> The changes look okay but I think it would be more efficient to fstat 
> the zone info file after opening it.
>
> -Alan
>

From Alan.Bateman at oracle.com  Mon Mar 12 07:34:07 2012
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Mon, 12 Mar 2012 14:34:07 +0000
Subject: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on
 linux when symbolic links to non default location used.
In-Reply-To: <4F5E08A9.7050507@oracle.com>
References: <4F5A2901.2050404@oracle.com> <4F5DD823.50309@oracle.com>
	<4F5E08A9.7050507@oracle.com>
Message-ID: <4F5E095F.7030506@oracle.com>

On 12/03/2012 14:31, Se?n Coffey wrote:
> Ok - good point on the stat change Alan. I think this is what you're 
> after :
>
> http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.2/
>
At L295 then I assume itshould open DEFAULT_ZONEINFO_FILE, otherwise if 
the sym link is a relative path then it would be opened relative to the 
working directory rather than the link.

-Alan.

From sean.coffey at oracle.com  Mon Mar 12 08:11:39 2012
From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=)
Date: Mon, 12 Mar 2012 15:11:39 +0000
Subject: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on
 linux when symbolic links to non default location used.
In-Reply-To: <4F5E095F.7030506@oracle.com>
References: <4F5A2901.2050404@oracle.com> <4F5DD823.50309@oracle.com>
	<4F5E08A9.7050507@oracle.com> <4F5E095F.7030506@oracle.com>
Message-ID: <4F5E122B.5040004@oracle.com>

Yes - good catch. I hadn't tested the sym link being a relative path. We 
should always open whatever is pointed to from DEFAULT_ZONEINFO_FILE. 
This simplifies the code. Tested and looks good.

regards,
Sean.


On 12/03/12 14:34, Alan Bateman wrote:
> On 12/03/2012 14:31, Se?n Coffey wrote:
>> Ok - good point on the stat change Alan. I think this is what you're 
>> after :
>>
>> http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.2/
>>
> At L295 then I assume itshould open DEFAULT_ZONEINFO_FILE, otherwise 
> if the sym link is a relative path then it would be opened relative to 
> the working directory rather than the link.
>
> -Alan.

From Alan.Bateman at oracle.com  Mon Mar 12 08:22:39 2012
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Mon, 12 Mar 2012 15:22:39 +0000
Subject: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on
 linux when symbolic links to non default location used.
In-Reply-To: <4F5E122B.5040004@oracle.com>
References: <4F5A2901.2050404@oracle.com> <4F5DD823.50309@oracle.com>
	<4F5E08A9.7050507@oracle.com> <4F5E095F.7030506@oracle.com>
	<4F5E122B.5040004@oracle.com>
Message-ID: <4F5E14BF.8000809@oracle.com>

On 12/03/2012 15:11, Se?n Coffey wrote:
> Yes - good catch. I hadn't tested the sym link being a relative path. 
> We should always open whatever is pointed to from 
> DEFAULT_ZONEINFO_FILE. This simplifies the code. Tested and looks good.
I assume this is the latest:
   http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.3/

and it looks fine to me.

-Alan.



From masayoshi.okutsu at oracle.com  Mon Mar 12 22:59:35 2012
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Tue, 13 Mar 2012 14:59:35 +0900
Subject: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on
 linux when symbolic links to non default location used.
In-Reply-To: <4F5E14BF.8000809@oracle.com>
References: <4F5A2901.2050404@oracle.com> <4F5DD823.50309@oracle.com>
	<4F5E08A9.7050507@oracle.com> <4F5E095F.7030506@oracle.com>
	<4F5E122B.5040004@oracle.com> <4F5E14BF.8000809@oracle.com>
Message-ID: <4F5EE247.5000601@oracle.com>

fd needs to be closed when fstat or malloc failed?

Thanks,
Masayoshi

On 3/13/2012 12:22 AM, Alan Bateman wrote:
> On 12/03/2012 15:11, Se?n Coffey wrote:
>> Yes - good catch. I hadn't tested the sym link being a relative path. 
>> We should always open whatever is pointed to from 
>> DEFAULT_ZONEINFO_FILE. This simplifies the code. Tested and looks good.
> I assume this is the latest:
>   http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.3/
>
> and it looks fine to me.
>
> -Alan.
>
>

From sean.coffey at oracle.com  Tue Mar 13 02:38:16 2012
From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=)
Date: Tue, 13 Mar 2012 09:38:16 +0000
Subject: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on
 linux when symbolic links to non default location used.
In-Reply-To: <4F5EE247.5000601@oracle.com>
References: <4F5A2901.2050404@oracle.com> <4F5DD823.50309@oracle.com>
	<4F5E08A9.7050507@oracle.com> <4F5E095F.7030506@oracle.com>
	<4F5E122B.5040004@oracle.com> <4F5E14BF.8000809@oracle.com>
	<4F5EE247.5000601@oracle.com>
Message-ID: <4F5F1588.3030005@oracle.com>

Update made. Hopefully the last iteration ;)

http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.4/

regards,
Sean.

On 13/03/2012 05:59, Masayoshi Okutsu wrote:
> fd needs to be closed when fstat or malloc failed?
>
> Thanks,
> Masayoshi
>
> On 3/13/2012 12:22 AM, Alan Bateman wrote:
>> On 12/03/2012 15:11, Se?n Coffey wrote:
>>> Yes - good catch. I hadn't tested the sym link being a relative 
>>> path. We should always open whatever is pointed to from 
>>> DEFAULT_ZONEINFO_FILE. This simplifies the code. Tested and looks good.
>> I assume this is the latest:
>>   http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.3/
>>
>> and it looks fine to me.
>>
>> -Alan.
>>
>>

From masayoshi.okutsu at oracle.com  Tue Mar 13 02:51:20 2012
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Tue, 13 Mar 2012 18:51:20 +0900
Subject: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on
 linux when symbolic links to non default location used.
In-Reply-To: <4F5F1588.3030005@oracle.com>
References: <4F5A2901.2050404@oracle.com> <4F5DD823.50309@oracle.com>
	<4F5E08A9.7050507@oracle.com> <4F5E095F.7030506@oracle.com>
	<4F5E122B.5040004@oracle.com> <4F5E14BF.8000809@oracle.com>
	<4F5EE247.5000601@oracle.com> <4F5F1588.3030005@oracle.com>
Message-ID: <4F5F1898.3030606@oracle.com>

Looks good to me.

Masayoshi

On 3/13/2012 6:38 PM, Se?n Coffey wrote:
> Update made. Hopefully the last iteration ;)
>
> http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.4/
>
> regards,
> Sean.
>
> On 13/03/2012 05:59, Masayoshi Okutsu wrote:
>> fd needs to be closed when fstat or malloc failed?
>>
>> Thanks,
>> Masayoshi
>>
>> On 3/13/2012 12:22 AM, Alan Bateman wrote:
>>> On 12/03/2012 15:11, Se?n Coffey wrote:
>>>> Yes - good catch. I hadn't tested the sym link being a relative 
>>>> path. We should always open whatever is pointed to from 
>>>> DEFAULT_ZONEINFO_FILE. This simplifies the code. Tested and looks 
>>>> good.
>>> I assume this is the latest:
>>>   http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.3/
>>>
>>> and it looks fine to me.
>>>
>>> -Alan.
>>>
>>>

From Alan.Bateman at oracle.com  Tue Mar 13 02:54:42 2012
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Tue, 13 Mar 2012 09:54:42 +0000
Subject: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on
 linux when symbolic links to non default location used.
In-Reply-To: <4F5F1588.3030005@oracle.com>
References: <4F5A2901.2050404@oracle.com> <4F5DD823.50309@oracle.com>
	<4F5E08A9.7050507@oracle.com> <4F5E095F.7030506@oracle.com>
	<4F5E122B.5040004@oracle.com> <4F5E14BF.8000809@oracle.com>
	<4F5EE247.5000601@oracle.com> <4F5F1588.3030005@oracle.com>
Message-ID: <4F5F1962.3040806@oracle.com>

On 13/03/2012 09:38, Se?n Coffey wrote:
> Update made. Hopefully the last iteration ;)
>
> http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.4/
Looks okay to me. For bonus points, open, fstat and read should be 
restarted if interrupted (EINTR).

-Alan.

From sean.coffey at oracle.com  Tue Mar 13 03:43:01 2012
From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=)
Date: Tue, 13 Mar 2012 10:43:01 +0000
Subject: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on
 linux when symbolic links to non default location used.
In-Reply-To: <4F5F1962.3040806@oracle.com>
References: <4F5A2901.2050404@oracle.com> <4F5DD823.50309@oracle.com>
	<4F5E08A9.7050507@oracle.com> <4F5E095F.7030506@oracle.com>
	<4F5E122B.5040004@oracle.com> <4F5E14BF.8000809@oracle.com>
	<4F5EE247.5000601@oracle.com> <4F5F1588.3030005@oracle.com>
	<4F5F1962.3040806@oracle.com>
Message-ID: <4F5F24B5.40108@oracle.com>

I'll push changes as are Alan. You've a good point on how we should 
handle EINTR for such system calls. I think it's something that's 
relevant to more than just this file and have filed bug 7153347 to 
follow that.

regards,
Sean.

On 13/03/2012 09:54, Alan Bateman wrote:
> On 13/03/2012 09:38, Se?n Coffey wrote:
>> Update made. Hopefully the last iteration ;)
>>
>> http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.4/
> Looks okay to me. For bonus points, open, fstat and read should be 
> restarted if interrupted (EINTR).
>
> -Alan.