<i18n dev> Locale patch for Slovenian date format data: dots are missed in the datetime for Slovanian

[Yong Jeffrey Huang]

Hi Daven,

In FormatData_sl.java, the data are

  134                     "EEEE, dd. MMMM yyyy", // full date pattern
  135                     "EEEE, dd. MMMM yyyy", // long date pattern

I think they should be changed to

                     "EEEE, dd. MMMM y", // full date pattern
                     "dd. MMMM y", // long date pattern

the same as what in test file LocaleData.

The change in LocaleData and LocaleDataTest.java are good.

thanks for fixing the CR.
Yong

On 2012/5/24 13:51, Deven You wrote:
> Hi Jeffrey,
>
> I have updated the webrev[1] according to your comments. Please review it.
>
> [1] http://cr.openjdk.java.net/~littlee/OJDK-126/webrev.00/ 
> <http://cr.openjdk.java.net/%7Elittlee/OJDK-126/webrev.00/>
>
> Thanks a lot!
>
> On 05/21/2012 05:27 PM, Yong Jeffrey Huang wrote:
>> Hi Daven,
>>
>> We use the format data in CLDR as the standard. Attached is the 
>> sl.xml in CLDR. In your fix, it's better to be
>>                     "EEEE, dd. MMMM y", // full date pattern
>>                     "dd. MMMM y", // long date pattern
>>
>> Blow is the format defined in CLDR:
>>
>> - <dateFormatLength type="full">
>> - <dateFormat type="standard">
>> <pattern type="standard">EEEE, dd. MMMM y</pattern>
>> </dateFormat>
>> </dateFormatLength>
>> - <dateFormatLength type="long">
>> - <dateFormat type="standard">
>> <pattern type="standard">dd. MMMM y</pattern>
>> </dateFormat>
>> </dateFormatLength>
>>
>> For test case:
>>
>> To fix format data of one locale, you must modify corresponding 
>> regression test:
>>
>> jdk/test/sun/text/resources/LocaleData:
>> In the end of the file,  add
>> #bug xxxxxx
>> FormatData/sl/DateTimePatterns/4=EEEE, dd. MMMM y
>> FormatData/sl/DateTimePatterns/5=dd. MMMM y
>>
>> jdk/test/sun/text/resources/LocaleDataTest.java:
>> In the end of comments @bug, add the bug number.
>>
>> thanks,
>> Yong
>>
>>
>> On 2012/5/21 15:41, Deven You wrote:
>>> Hi All,
>>>
>>> I think this patch is simple and straight forward, is anyone 
>>> interested in taking a look?
>>>
>>> Thanks a lot!
>>>
>>> On 03/05/2012 01:52 PM, Deven wrote:
>>>> Hi i18n-devs,
>>>>
>>>> I find there is a problem in Slovenian Locale. In Slovenian Locale, 
>>>> days in a date must with a dot '.', like Oct 23rd 2011 will be 23. 
>>>> oktober 2011. Without the '.', 23 oktober 2011 basically means 
>>>> Twenty-three of October, instead of the Twenty-third of October.
>>>>
>>>> Current oracle 6/7/8 all miss the dot '.', so this patch [1] will 
>>>> add dot after the days to correct the date expression in Slovenian 
>>>> Locale.
>>>>
>>>> The attached test case [2] shows the the diffrence with/without 
>>>> this patch. The output of this test case are:
>>>>
>>>> without this patch:
>>>> Ponedeljek, 5 marec 2012
>>>>
>>>> with this patch:
>>>> Ponedeljek, 5. marec 2012
>>>>
>>>> This test case may not be very useful, so I hope anyone can give me 
>>>> some suggestions about how to refine the test case?
>>>>
>>>> [1] 
>>>> http://cr.openjdk.java.net/~youdwei/slovenian_formatData/webrev.00/ 
>>>> <http://cr.openjdk.java.net/%7Eyoudwei/slovenian_formatData/webrev.00/> 
>>>>
>>>>
>>>> [2] SlovenianFormatDataTest.java
>>>>
>>>> Thanks a lot!
>>>>
>>>
>>>
>>
>
>
> -- 
> Best Regards,
>
> Deven

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/i18n-dev/attachments/20120524/1e4c966f/attachment.html