<i18n dev> <AWT Dev> [8] Review request for 6789984: JPasswordField can not receive keyboard input

[Naoto Sato]

Hi Anton,

What's the reason for adding endComposition() in the shared code? 
endComposition() is supposed to end the unfinished composed string that 
is currently in composition, and the bug does not mention anything 
regarding the composition. Also, it looks like the bug is localized only 
to SCIM on Unix platforms, and calling resetXIC() looks just enough in 
XIM handling code to me.

Naoto

On 11/2/12 5:43 AM, Anthony Petrov wrote:
> Hi Anton,
>
> I'm not an expert in IM code, but generally the changes look good to me.
> I'm also CC'ing i18n-dev@ to take a look at this fix.
>
> My only concern is that you're changing shared code here. Did you run
> any IM tests on other platforms to make sure no regressions are introduced?
>
> Also, could you please add a comment to the bug report explaining the
> root cause of the issue and how the proposed solution helps resolve it?
>
> --
> best regards,
> Anthony
>
> On 11/1/2012 8:40 PM, Anton Litvinov wrote:
>> Hello,
>>
>> Please review the following fix for a bug.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6789984
>> Webrev: http://cr.openjdk.java.net/~alitvinov/6789984/webrev.00
>>
>> This bug consists in inability of JPasswordField to react on any
>> keyboard events under certain conditions on Linux OS. The webrev does
>> not contain any new "jtreg" test, because a particular Linux OS
>> distribution with additionally installed packages are required for
>> reproduction of the bug.
>>
>> Requirements to the environment:
>> 1. Oracle Enterprise Linux (OEL) 5.6 x86 64/Oracle Enterprise Linux
>> (OEL) 5.5 x86 64
>> 2. Package "scim-anthy-1.2.0-6.el5.x86_64" and its all dependent
>> packages installed on the OS.
>> 3. JDK 8.
>> 4. A simple Java Swing application, where a dialog with both
>> JTextField and JPasswordField is displayed.
>>
>> Thank you,
>> Anton