<i18n dev> [8] Request for review: 8000986: Split java.util.spi.CalendarDataProvider into week parameters and field names portions

[Naoto Sato]

Thanks. The change looks good to me.

Naoto

On 11/9/12 5:08 PM, Masayoshi Okutsu wrote:
> Thanks. I added CalendarNameProviderImpl to GenericTest.java. The test
> passed.
>
> I've updated webrev. No other changes.
>
> http://cr.openjdk.java.net/~okutsu/8/8000986/webrev.01/
>
> Masayoshi
>
> On 11/10/2012 4:41 AM, Naoto Sato wrote:
>> I have just one comment. Although it won't affect the test result,
>> test/java/util/PluggableLocale/GenericTest.java should include the
>> available locales from CalendarNameProviderImpl for consistency.
>>
>> Naoto
>>
>> On 11/9/12 7:59 AM, Masayoshi Okutsu wrote:
>>> Hello,
>>>
>>> Please review the changes for:
>>>
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000986
>>>
>>> In addition to the split, I've improved CalendarDataUtility which now
>>> gets the week parameters through the Pool mechanism.
>>>
>>> This one should fix the following concrete problem:
>>>
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000964
>>>
>>> I've manually tested this one, but I didn't take the test case because
>>> it depends on localization data. We need to rely on the test case
>>> developed by the SQE team.
>>>
>>> Webrev:
>>>
>>> http://cr.openjdk.java.net/~okutsu/8/8000986/webrev.00/
>>>
>>> Thanks,
>>> Masayoshi
>>>
>>>
>>>
>>>
>>
>