<i18n dev> [8] Review request for CR 7196799: CLDR adapter can not be invoked when region code is specified in Locale

[Naoto Sato]

Hi Masayoshi,

Thank you for the review. I updated LocaleProviderAdapter.java according 
to your comments. Also I fixed two instances of "if (locale == 
Locale.ROOT)" statements in LocaleProviderAdapter.java and 
CalendarDataProviderImpl.java (this is irrelevant to the bug, but fixed 
it anyway for precaution).

http://cr.openjdk.java.net/~naoto/7196799/webrev.03/

Naoto

On 10/2/12 10:02 PM, Masayoshi Okutsu wrote:
> Hi Naoto,
>
> Here are my comments.
>
> LocaleProviderAdapter.java:
>
> - After parsing the java.locale.providers value, if typeList is empty,
> the default list (JRE,SPI) should be used.
>
> - I don't think the following lines are necessary in getAdapter().
>
> Otherwise, the fix looks good to me.
>
> Thanks,
> Masayoshi
>
> On 9/21/2012 7:25 AM, Naoto Sato wrote:
>> I revised the fix again to catch up with the internal comments, i.e.,
>> correcting the behavior when a bogus adapter is specified, it won't
>> fall back to JRE locale data. The revised webrev is located here:
>>
>> http://cr.openjdk.java.net/~naoto/7196799/webrev.02/
>>
>> Naoto
>>
>> On 9/12/12 2:55 PM, Naoto Sato wrote:
>>> I updated the webrev to include another fix to a test bug:
>>>
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7197573
>>>
>>> Since the fix is to correct some wrong assumption on the platform
>>> default locale in the same test case with 7196799, I just combined two
>>> fixes in one changeset. The code changes for 7197573 remain intact.
>>>
>>> The combined new webrev is located at:
>>>
>>> http://cr.openjdk.java.net/~naoto/7196799/webrev.01/
>>>
>>> Naoto
>>>
>>> On 9/10/12 4:50 PM, Naoto Sato wrote:
>>>> Hello,
>>>>
>>>> Please review the proposed fix for the subject bug:
>>>>
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7196799
>>>>
>>>> The webrev for the fix is located at:
>>>>
>>>> http://cr.openjdk.java.net/~naoto/7196799/webrev.00/
>>>>
>>>> The fix is basically limit the implicit fallback to JRE's locale data
>>>> only for the root locale, in order to honor the CLDR's fallback.
>>>>
>>>> Naoto
>>>
>>
>