<i18n dev> [8] Request for review: 8000245/8000273/8000615

Masayoshi Okutsu masayoshi.okutsu at oracle.com
Sun Oct 14 12:14:33 PDT 2012

Here are my comments.


- pool is no longer used and should be removed.

- Should contains(key) be retained? It should be faster than try-catch.

Otherwise, the fix looks good to me.


On 10/12/2012 6:45 AM, Naoto Sato wrote:
> Hello,
> Please review the changes for the subject bugs:
> 8000245: SimpleDateFormat.format(date, StringBuffer, FieldPosition) 
> doesn't work as expected with custom extensions
> 8000273: java.util.Locale.getDisplayVariant(Locale l) isn't 
> transferred to the custom service provider
> 8000615: JRE adapter: timezone name of en_US is changed when extension 
> directory is added
> All of these bugs are regressions caused by the JEP 127 change, where 
> locale providers are invoked not with the originally requested locale. 
> Now it is invoked with the original locale as in 
> LocaleServiceProviderPool.java. With this change, resource bundle 
> locale check in JRE's 
> LocaleNameProvider/CurrencyNameProvider/TimeZoneNameProvider 
> implementations are no longer needed.
> The webrev for these changes are located at:
> http://cr.openjdk.java.net/~naoto/8000245.8000273.8000615/webrev.00/
> Naoto

More information about the i18n-dev mailing list