<i18n dev> hg: jdk8/tl/jdk: 7180362: RFE: Implement date cutover functionality for currency.properties file

Alan Bateman Alan.Bateman at oracle.com
Sat Sep 8 02:14:28 PDT 2012


On 07/09/2012 21:19, sean.coffey at oracle.com wrote:
> Changeset: fffbb33df102
> Author:    coffeys
> Date:      2012-09-07 21:22 +0100
> URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fffbb33df102
>
> 7180362: RFE: Implement date cutover functionality for currency.properties file
> Reviewed-by: naoto
>
> ! src/share/classes/java/util/Currency.java
> ! test/java/util/Currency/PropertiesTest.java
> ! test/java/util/Currency/PropertiesTest.sh
> ! test/java/util/Currency/currency.properties
>
A post push comment but this looks very strange:

private static boolean isPastCutoverDate(String s)
        throws IndexOutOfBoundsException, NullPointerException, 
ParseException {

I assume this should declare ParseException only as the other two are 
runtime exceptions.

Also shouldn't the parsing be made more robust so that 
replaceCurrencyData doesn't need to catch and ignore IOOBE and NPE?

-Alan.









More information about the i18n-dev mailing list