<i18n dev> [8] Request for Review: 8013903: Japanese calendar field names are not displayed with -Djava.locale.providers=HOST on Windows

Masayoshi Okutsu masayoshi.okutsu at oracle.com
Mon Jun 3 22:21:26 PDT 2013


Looks good to me.

Masayoshi

On 6/4/2013 6:28 AM, Naoto Sato wrote:
> Thanks. I should have known. Here is the revised webrev:
>
> http://cr.openjdk.java.net/~naoto/8013903/webrev.02/
>
> Naoto
>
> On 6/3/13 1:56 AM, Masayoshi Okutsu wrote:
>> I'd suggest use of Collections.singleton(T o) for
>> FallbackLocaleProviderAdapter.rootTagSet. Otherwise, the changes look
>> good to me.
>>
>> Thanks,
>> Masayoshi
>>
>> On 6/1/2013 8:58 AM, Naoto Sato wrote:
>>> Hello,
>>>
>>> I updated the fix according to an internal comment, which added a
>>> paragraph in java.util.spi.LocaleServiceProvider.java's class
>>> description. Other changes remain the same with the prior webrev.
>>>
>>> Please review the following updated one:
>>>
>>> http://cr.openjdk.java.net/~naoto/8013903/webrev.01/
>>>
>>> Naoto
>>>
>>> On 5/16/13 2:59 PM, Naoto Sato wrote:
>>>> Please review the fix for the following bug:
>>>>
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013903
>>>>
>>>> The webrev is located at:
>>>>
>>>> http://cr.openjdk.java.net/~naoto/8013903/webrev.00/
>>>>
>>>> Here's the summary of the changes:
>>>> - Removed CalendarNameProvider implementation in Windows HOST adapter.
>>>> - Fixed FALLBACK provider to only work in the case of ROOT locale.
>>>>
>>>> Naoto
>>>
>>
>



More information about the i18n-dev mailing list