<i18n dev> Review Request - 8013836 : getFirstDayOfWeek reports wrong day for pt-BR locale

[Jeff Dinkins]

I'm pretty sure we generally don't remove the original copyright.


On Jun 17, 2013, at 7:42 PM, Yong Huang <yong.huang at oracle.com> wrote:

> Hi Michael,
> 
> Since you are more familiar with the copyright in resource files, I'd like to get your help first. :-)
> 
> I copy CalendarData_pt.properties to CalendarData_pt_BR.properties and make some modification on it. Do I still need to keep Taligent/IBM copyright in the new file? If you are also not sure, do you know how to get help from legal about this?
> 
> thanks,
> Yong
> 
> On 2013/6/18 1:37, Naoto Sato wrote:
>> IANAL, but I am not sure whether the Taligent/IBM copyright notice is needed, since you've created it. Can you please check it with the legal?
>> 
>> Naoto
>> 
>> On 6/16/13 8:20 PM, Yong Huang wrote:
>>> Hi Naoto,
>>> 
>>> Thanks for the review.
>>> 
>>> The revised webrev is at
>>> http://cr.openjdk.java.net/~yhuang/8013836/webrev.01/
>>> 
>>> thanks,
>>> Yong
>>> 
>>> On 2013/6/15 3:10, Naoto Sato wrote:
>>>> Hi Yong,
>>>> 
>>>> Changing the "pt" resource file would affect all the countries with
>>>> Portuguese language, not only Brazil. It could result in the correct
>>>> behavior for some countries, but could regress for others (haven't
>>>> checked each of them). I think we need to create
>>>> CalendarData_pt_BR.properties to explicitly change the first day for
>>>> Brazil.
>>>> 
>>>> Naoto
>>>> 
>>>> On 6/13/13 11:51 PM, Yong Huang wrote:
>>>>> Hello,
>>>>> 
>>>>> This is the review request for
>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013836
>>>>> 
>>>>> Webrev:
>>>>> http://java-g11n.us.oracle.com/j2se/ws/1.8.0/ws/yonhuang/8013836/webrev.00/ 
>>>>> 
>>>>> 
>>>>> thanks,
>>>>> Yong
>>>> 
>>> 
>> 
>