<i18n dev> [8]Request for review: 8010521: jdk8 l10n resource file translation update

[Naoto Sato]

On 3/25/13 12:50 PM, Michael Fang wrote:
> Hi Naoto,
>
> Thank you so much for your review. Please see my comments inline below.
>
> thanks,
>
> -michael
>
> On 13年03月25日 11:37 上午, Naoto Sato wrote:
>> Hi Michael,
>>
>> I haven't looked into the actual translations, but here are my
>> comments to your changes. All are in the jdk repository:
>>
>> -
>> src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_TW.properties:
>> There seems to be no change in this file.
> I looked at hg history of the English synth.properties file. There
> wasn't any changes to the English resource file. The l10n file changes
> are all related to translation corrections from translation team and
> there wasn't any correction for zh_TW.

OK, then can you please remove this file from the changeset?

>>
>> -
>> src/share/classes/sun/tools/jconsole/resources/messages_[ja|zh_CN].properties:
>> On the other hand, in these files, there are too many changes that
>> looked the same. Are these correct?
> There also wasn't English file change for messages.properties. The diffs
> are related to changing the case of the letters. Ex:
> -ONE_DAY=\ 1\u65e5
> +ONE_DAY=\ 1\u65E5
>
> The translation team returns the translation with upper case letters in
> the \uxxxx notation. But because the previous version of l10n files were
> manually edited by dev team to fix 7017818, the casing is most of the
> lines are different.

Got it.

>
>>
>> - src/share/classes/sun/util/logging/resources/logging_*.properties:
>> The comment says, "# The following ALL CAPS words should be
>> translated." But some of them are translated, and others aren't. Need
>> to figure out the correct way.
> I will work with translation team offline on this. The translation team
> said they would refer to the comments, but technically, they have a rule
> about *not* translating words that are made out of all capital letters.
> I believe their automated translation tool have automatically filtered
> out those resources during translation process.
>
> Another option is to ask dev team not to use these ALL CAPS words in
> order to meet the t13y (translatability) requirements.

I think the rule of the translation team would only apply to plain 
English (or whatever language) sentences. In this case, they are log 
levels defined here 
(http://download.java.net/jdk8/docs/api/java/util/logging/Level.html), 
so both options of applying all caps rule or change them into lower 
cases would be wrong to me.

Anyway, if you need to integrate this changeset to keep the dead line, I 
am fine with the current one (without the empty change above). Please 
file a bug for the above logging issue for following up.

Naoto

>>
>> Naoto
>>
>> On 3/22/13 4:18 PM, Michael Fang wrote:
>>> Hello,
>>>
>>> Please help to review the changes for the following CR:
>>> http://bugs.sun.com/view_bug.do?bug_id=8010521
>>>
>>> A list of English resource files are sent to translation group for
>>> translation update periodically that's why these l10n resource files
>>> have been updated.
>>>
>>> You do not need to review the translation content at this time. We just
>>> need to make sure they do not break the build (which has been ensured
>>> with full test builds). Follow up i18n/l10n testing will be performed in
>>> promotion builds and i18n/l10n bugs will be reported and addressed.
>>>
>>> The webrev is available here:
>>> http://cr.openjdk.java.net/~mfang/8010521/
>>>
>>> thanks,
>>>
>>> -michael
>>>
>>
>