<i18n dev> [8]: diff patch for jdk test on a non US platform

Naoto Sato naoto.sato at oracle.com
Wed Nov 6 16:33:25 PST 2013


Thank you for the review, Stuart.

I just wanted to get rid of "Control" in front of "FORMAT_DEFAULT", but 
silly me, I did not do that! And it does not seem to make much sense 
using static import just for that purpose. I will remove "static" from 
the proposed fix.

Naoto

On 11/6/13 4:11 PM, Stuart Marks wrote:
> Hi Naoto,
>
> The changes look sensible, though I'm not an expert in the
> ResourceBundle API.
>
> I did notice though that in ResourceBundleTest.java there is a static
> import of java.util.ResourceBundle.Control. Does it need to be a static
> import? Surprisingly, it seems to compile either way.
>
> s'marks
>
>
> On 11/6/13 2:36 PM, Naoto Sato wrote:
>> And here is the proposed webrev. Please review:
>>
>> http://cr.openjdk.java.net/~naoto/8027930/webrev.00/
>>
>> Naoto
>>
>> On 11/6/13 9:47 AM, Naoto Sato wrote:
>>> Thank you, Francis. I created the following CR for those ResourceBundle
>>> test failures:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8027930
>>>
>>> Naoto
>>>
>>> On 11/5/13 10:31 PM, Francis ANDRE wrote:
>>>> HI
>>>>
>>>> To add a little bit more of clarity for the i18n problems in the
>>>> ResourceBundle tests, joined is an extract from the log of their
>>>> failures before I fixed them for the non US Locale case. Sorry for not
>>>> having joined this log before.
>>>>
>>>> HTH
>>>>
>>>> Francis


More information about the i18n-dev mailing list