<i18n dev> RFR: JDK-8025712, , (props) Possible memory leak in java_props_md.c / ParseLocale

Chris Hegarty chris.hegarty at oracle.com
Thu Oct 10 02:22:18 PDT 2013


Dan,

Your changes look fine to me.

While looking at this I notice that there is another potential leak. If 
the malloc for temp fails, then we need to free lc ( for MAC only ), right?

-Chris.

On 10/09/2013 07:51 PM, Dan Xu wrote:
> Hi All,
>
> This fix is to solve the memory leak issue in ParseLocale() function of
> jdk/src/solaris/native/java/lang/java_props_md.c. Because the locale,
> lc, is copied into temp, it is not necessary to do the strdup(), which
> leads to the memery leak. The fix simply removes the line of strdup
> operation. Thanks!
>
> Webrev: http://cr.openjdk.java.net/~dxu/8025712/webrev/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8025712
>
> -Dan


More information about the i18n-dev mailing list