<i18n dev> RFR: 8025255: (tz) Support tzdata2013g

Aleksej Efimov aleksej.efimov at oracle.com
Fri Oct 11 02:37:20 PDT 2013


Hi Masayoshi,
Thank you for your comments. Replies are below.

On 10/11/2013 08:54 AM, Masayoshi Okutsu wrote:
> Hi Aleksej,
>
> Here are my review comments.
>
> - The copyright header of the data files shouldn't be removed.
The copyright header is absent in raw tzdata2013g release (in 
tzdata2013g.tar.gz). I didn't do any modification to it.
>
> - TimeZoneNames.java:
> -                                  "Middle Europe Time", "MET"}},
> +                                  "MET", "MET"}},
> I don't think the long name should be changed.

Agree, will change it back.

>
> I didn't review the localized TimeZoneNames_*.java files. If L10N Team 
> is OK with them, I'm fine.
>
> Thanks,
> Masayoshi
>
> On 10/10/2013 10:30 PM, Aleksej Efimov wrote:
>> Hi,
>>
>> Please, review the changes [1] needed to address the tz data update 
>> in JDK 8 from tzdata2013d to tzdata2013g.
>>
>> The brief list of changes:
>> 1. tzdata2013g data was integrated to tzdb data files 
>> (make/sun/javazic/tzdata/* changes) and to sun/util/calendar test 
>> data files (test/sun/util/calendar/zi/tzdata/* changes).
>> 2. a) Updates to long time zone names
>>     b) Updates to short name changes to address corresponding changes 
>> in tzdata2013e(WIT/CIT/EIT/WARST -> WIB/WITA/WIT/ART)
>>     c) Removed unused ACT[] array
>>     d) Added "Europe/Busingen" time zone name
>>     All this changes a)->d) relates to 
>> src/share/classes/sun/util/resources/TimeZoneNames*.java files
>>
>> The following tests were executed on JDK 8 with fix:
>> test/java/util/TimeZone
>> test/java/util/Calendar
>> test/java/util/Formatter
>> test/sun/util/calendar
>> test/java/time
>>
>> Testing result: All test passed
>>
>> Thanks!
>> Aleksej
>>
>> [1] http://cr.openjdk.java.net/~aefimov/8025255/8/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Eaefimov/8025255/8/webrev.00/>
>>
>



More information about the i18n-dev mailing list