<i18n dev> RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

Michael Fang michael.fang at oracle.com
Thu Oct 24 08:16:46 PDT 2013


Agreed. It was unnecessary, but it was the practice at that time.

thanks,

-michael

On 13?10?24? 01:55 ??, Masayoshi Okutsu wrote:
> The test detected the translation changes as regression, but that was 
> unnecessary? I prefer to remove this test rather than changing the data.
>
> Thanks,
> Masayoshi
>
> On 10/24/2013 12:12 AM, Michael Fang wrote:
>> Hi Masayoshi,
>>
>> At that time I was asked to have regression test to validate each 
>> translation changes.
>>
>> With our new translation process for TimeZoneNames and new planned 
>> regression tests from Aleksej for JDK-8025051 
>> <https://bugs.openjdk.java.net/browse/JDK-8025051>, I believe we can 
>> remove those unnecessary tests in the future (probably together with 
>> JDK-8025051 <https://bugs.openjdk.java.net/browse/JDK-8025051>).
>>
>> For now,  webrev [2] looks fine to take care of the short term 
>> regression failure.
>>
>> thanks,
>>
>> -michael
>>
>> On 13?10?22? 09:29 ??, Masayoshi Okutsu wrote:
>>> Hi Michael,
>>>
>>>   27  *@summary Test case for tzdata2005m support for 9 locales
>>>
>>> What's the purpose of this test? Do we really need to keep this one?
>>>
>>> Thanks,
>>> Masayoshi
>>>
>>> On 10/22/2013 8:13 PM, Aleksej Efimov wrote:
>>>> Hi,
>>>> Can I have a review for 8026772 [1] fix.
>>>> The webrev link: [2]
>>>> The timezone test is failed because of the changed TimeZone names 
>>>> introduced in 8025255 [3].
>>>> This timezone names were changed according to updated translation 
>>>> resource files introduced by 8025215 [4].
>>>>
>>>> The fix changes the hard-coded time zone names for 
>>>> "Australia/Currie" to the values specified in 8025215.
>>>>
>>>> Thanks in Advance,
>>>> Aleksej
>>>>
>>>> [1] http://bugs.sun.com/view_bug.do?bug_id=8026772
>>>> [2] http://cr.openjdk.java.net/~aefimov/8026772/webrev.00/
>>>> [3] http://bugs.sun.com/view_bug.do?bug_id=8025255
>>>> [4] http://bugs.sun.com/view_bug.do?bug_id=8025215
>>>>
>>>>
>>>
>


More information about the i18n-dev mailing list