<i18n dev> [8] Request for review: 6931564: Incorrect display name of Locale for south africa

Naoto Sato naoto.sato at oracle.com
Wed Oct 30 10:29:01 PDT 2013


Hi Michael,

I just skimmed through resource files, and found other instances that 
end with spaces. IIRC, build or release team will take care of them with 
some script execution (might be wrong). So first can you check with them 
whether they will do this kind of clean up at the end? If not, can you 
fix not only this instance but all other unnecessary spaces in resource 
files?

Naoto

On 10/29/13 11:59 PM, Michael Fang wrote:
> Hello,
>
> Please help to review the changes for the following CR:
> https://bugs.openjdk.java.net/browse/JDK-6931564
>
> The webrev is available here:
> http://cr.openjdk.java.net/~mfang/6931564/
> (Please ignore the part for 6192407 which shares the same regression
> test program)
>
> The diff is not very obvious from the webrev. There was an extra space
> at the end of the line and the fix is just to remove the extra space.
>
> % hg diff LocaleNames_sv.properties
> diff -r dd0deeb04933
> src/share/classes/sun/util/resources/sv/LocaleNames_sv.properties
> --- a/src/share/classes/sun/util/resources/sv/LocaleNames_sv.properties
> Mon Oct 14 22:09:15 2013 +0100
> +++ b/src/share/classes/sun/util/resources/sv/LocaleNames_sv.properties
> Tue Oct 29 23:16:53 2013 -0700
> @@ -1106,7 +1106,7 @@ WS=Samoa
> WS=Samoa
> YE=Jemen
> YT=Mayotte
> -ZA=Sydafrika[space]
> +ZA=Sydafrika
> ZM=Zambia
> ZW=Zimbabwe
>
> thanks,
>
> -michael


More information about the i18n-dev mailing list