<i18n dev> [8] Request for review: 8026570: NLS: jdk8 man page update

Naoto Sato naoto.sato at oracle.com
Tue Jan 7 10:53:52 PST 2014


Hi Michael,

jcmd.1 looks fine to me, however, what about the other two new ja man 
pages, i.e., jdeps and jjs? I could not find them in the artifact link 
you provided below.

Naoto

On 1/6/14, 8:06 PM, Michael Fang wrote:
> Found the source of the jcmd.1 corruption issue.
>
> jdk/make/Images.gmk
> 450 # Old build creates empty man page for this, mimicing behaviour.
> 451 $(JDK_IMAGE_DIR)/man/ja_JP.UTF-8/man1/jcmd.1
> $(JDK_IMAGE_DIR)/man/ja_JP.PCK/man1/jcmd.1 $(JDK_IMAGE_DIR)
> /man/ja/man1/jcmd.1:
> 452 $(ECHO) $(LOG_INFO) Creating dummy $(patsubst $(OUTPUT_ROOT)/%,%,$@)
> 453 $(MKDIR) -p $(@D)
> 454 $(TOUCH) $@
>
> I have corrected it (deleted the above lines) and updated the webrev:
> http://cr.openjdk.java.net/~mfang/8026570/webrev.01
>
> The jprt test build confirmed that jcmd.1 for Japanese works fine now.
> The built man page files can be found at:
> http://cr.openjdk.java.net/~mfang/8026570/solaris/ja_JP.UTF-8/man1/
> http://cr.openjdk.java.net/~mfang/8026570/linux/ja_JP.UTF-8/man1/
>
> thanks,
>
> -michael
>
> On 13年12月24日 11:15 上午, Michael Fang wrote:
>> Thank you Masayoshi and Naoto for looking into it.
>>
>> About the missing space, unfortunately, this is a "feature" of the
>> translation system. It's out of my control. I received the following
>> from translation team when copyright line was causing conversion error:
>>
>> When we translate the statement, "Copyright (c) xxxx, xxxx, Oracle
>> and&sol;or its affiliates. All rights reserved.", each single sentence
>> is handled as translatable string segment, then stored into Repository
>> as they are. However, when the Japanese contents are rebuild, the
>> spaces between two sentences are removed because these are also
>> treated as Japanese strings. In general, no space is required between
>> multiple sentences in Japanese, so this feature is implemented in the
>> current system.
>>
>> About the corruption of jcmd.1, in the current promotion, Japanese
>> jcmd.1 has size 0 as well. It's not a regression, but something still
>> to be investigated.
>>
>> thanks,
>>
>> -michael
>>
>> On 13年12月24日 10:02 上午, Naoto Sato wrote:
>>> Also, I would like to at least find out why the man page is corrupt
>>> before the push.
>>>
>>> Naoto
>>>
>>> On 12/24/13, 1:06 AM, Masayoshi Okutsu wrote:
>>>> Looks like all spaces between English words and Japanese characters
>>>> have
>>>> been removed. Why is that?
>>>>
>>>> I checked (OS native) man pages in Japanese on Solaris and Linux. They
>>>> have spaces. I do prefer to have spaces.
>>>>
>>>> Thanks,
>>>> Masayoshi
>>>>
>>>> On 12/23/2013 5:54 PM, Michael Fang wrote:
>>>>> Hi,
>>>>>
>>>>> Please help to review the changes for the following CR:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8026570
>>>>>
>>>>> The webrev is available here:
>>>>> http://cr.openjdk.java.net/~mfang/8026570/webrev.00/
>>>>>
>>>>> The built man page files can be found at:
>>>>> http://cr.openjdk.java.net/~mfang/8026570/solaris/ja_JP.UTF-8/man1/
>>>>> http://cr.openjdk.java.net/~mfang/8026570/linux/ja_JP.UTF-8/man1/
>>>>>
>>>>> The SQE team has tested the man pages and the following issues have
>>>>> been reported:
>>>>> JDK-8030947 jcmd.1 Japanese man page is corrupted after the build
>>>>> JDK-8030946 No jmc.1 for man page of JMC
>>>>> .sh "NAME" not translated - hardcoded and not included in the xml
>>>>> source file for translation
>>>>>
>>>>> thanks,
>>>>>
>>>>> -michael
>>>>
>>>
>>
>



More information about the i18n-dev mailing list