<i18n dev> [9] RFR: 8038092: Re-examine Bidi reflective dependency on java.awt.font

Naoto Sato naoto.sato at oracle.com
Wed Jul 2 00:42:02 UTC 2014

I further modified the fix:

- Made sure the SharedSecret is lazily evaluated.
- Added the missing JavaAWTFontAccessImpl file
- Added a test case


Please review.


On 7/1/14, 1:09 PM, Naoto Sato wrote:
> Thanks, Alan. Here is the revised webrev based on your suggestions:
> http://cr.openjdk.java.net/~naoto/8038092/webrev.1/
> Please review.
> Naoto
> On 7/1/14, 6:58 AM, Alan Bateman wrote:
>> On 30/06/2014 18:35, Naoto Sato wrote:
>>> Hello,
>>> Please review the fix for the subject bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8038092
>>> The proposed change is located at:
>>> http://cr.openjdk.java.net/~naoto/8038092/webrev.0/
>> Thanks for looking at this issue.
>> One part that doesn't look right is where Bidi is used before
>> TextAttribute or NumericShaper are initialized and then used later with
>> one of these as an attribute. Normally with SharedSecrets then
>> ensureClassInitialized is to used to initialize a class that is known to
>> register the secret but in this case then you can't do that because it
>> would create a dependency on java.awt. The simplest thing might be to
>> keep the Class.forName in both TextAttribtueConstants and
>> NumericShapings as that will ensure that those classes are initialized
>> (if they are present).
>> A minor comment is that there are probably a bunch of imports that can
>> be removed once the bulk of the core reflection usage goes away.
>> -Alan.

More information about the i18n-dev mailing list