<i18n dev> [9] RFR: 8039317: Read currency.data read as a resource

[Chris Hegarty]

On 26 Jun 2014, at 17:22, Naoto Sato <naoto.sato at oracle.com> wrote:

> Hi Alan, Chris,
> 
> Thank you for the review. I updated the fix (actually I forgot to add the changes to the tests the first time) according to your suggestions:
> 
> http://cr.openjdk.java.net/~naoto/8039317/webrev.1/

Looks good. Thanks Naoto.

-Chris.

> 
> I'd appreciate your reviews.
> 
> Naoto
> 
> On 6/26/14, 5:29 AM, Chris Hegarty wrote:
>> On 26 Jun 2014, at 13:08, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>> 
>>> On 26/06/2014 00:16, Naoto Sato wrote:
>>>> Hello,
>>>> 
>>>> Please review the proposed fix to the subject issue:
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8039317
>>>> 
>>>> The fix is to move "currency.data" file from "lib" directory into "resources.jar" file, as this file is merely a data file:
>>>> 
>>>> http://cr.openjdk.java.net/~naoto/8039317/webrev.0/
>>> I assume that jdk/make/profile-includes.txt will need to be updated too, otherwise it looks okay to me.
>> 
>> +1. Trivially, you could probably move homeDir down just below the try/catch where it is now first being used.
>> 
>> -Chris
>>