From yuka.kamiya at oracle.com Wed May 7 08:09:59 2014 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Wed, 07 May 2014 17:09:59 +0900 Subject: RFR: [9] 8042360: Subtag syntax check is incomplete in Locale.LanguageRange Message-ID: <5369EA57.5010403@oracle.com> Hello, Please review a simple fix for JDK 9: Bug description: https://bugs.openjdk.java.net/browse/JDK-8042360 Webrev: http://cr.openjdk.java.net/~peytoia/8042360/webrev.00/ Thanks, -- Yuka From naoto.sato at oracle.com Wed May 7 16:59:26 2014 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 07 May 2014 09:59:26 -0700 Subject: RFR: [9] 8042360: Subtag syntax check is incomplete in Locale.LanguageRange In-Reply-To: <5369EA57.5010403@oracle.com> References: <5369EA57.5010403@oracle.com> Message-ID: <536A666E.4020708@oracle.com> Looks good to me. Naoto On 5/7/14, 1:09 AM, Yuka Kamiya wrote: > Hello, > > Please review a simple fix for JDK 9: > > Bug description: https://bugs.openjdk.java.net/browse/JDK-8042360 > Webrev: http://cr.openjdk.java.net/~peytoia/8042360/webrev.00/ > > Thanks, > -- > Yuka > From masayoshi.okutsu at oracle.com Wed May 7 23:04:33 2014 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Thu, 08 May 2014 08:04:33 +0900 Subject: RFR: [9] 8042360: Subtag syntax check is incomplete in Locale.LanguageRange In-Reply-To: <5369EA57.5010403@oracle.com> References: <5369EA57.5010403@oracle.com> Message-ID: <536ABC01.1040109@oracle.com> Looks good. Masayoshi On 5/7/2014 5:09 PM, Yuka Kamiya wrote: > Hello, > > Please review a simple fix for JDK 9: > > Bug description: https://bugs.openjdk.java.net/browse/JDK-8042360 > Webrev: http://cr.openjdk.java.net/~peytoia/8042360/webrev.00/ > > Thanks, > -- > Yuka > From naoto.sato at oracle.com Mon May 12 17:51:46 2014 From: naoto.sato at oracle.com (Naoto Sato) Date: Mon, 12 May 2014 10:51:46 -0700 Subject: [9] RFR: 8041791 : String.toLowerCase regression (JDK-8020037) - violates Unicode Message-ID: <53710A32.1010407@oracle.com> Hello, Please review the fix for the following regression: https://bugs.openjdk.java.net/browse/JDK-8041791 The proposed change is located at: http://cr.openjdk.java.net/~naoto/8041791/webrev.00/ Now the new code lowercases the dotted capital I into a combining sequence in non-Turkic locales. Naoto From yuka.kamiya at oracle.com Wed May 14 03:06:04 2014 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Wed, 14 May 2014 12:06:04 +0900 Subject: [9] RFR: 8041791 : String.toLowerCase regression (JDK-8020037) - violates Unicode In-Reply-To: <53710A32.1010407@oracle.com> References: <53710A32.1010407@oracle.com> Message-ID: <5372DD9C.7000000@oracle.com> Looks good to me. Thanks, -- Yuka (5/13/14, 2:51), Naoto Sato wrote: > Hello, > > Please review the fix for the following regression: > > https://bugs.openjdk.java.net/browse/JDK-8041791 > > The proposed change is located at: > > http://cr.openjdk.java.net/~naoto/8041791/webrev.00/ > > Now the new code lowercases the dotted capital I into a combining sequence in non-Turkic locales. > > Naoto From aleksej.efimov at oracle.com Wed May 14 22:59:17 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Thu, 15 May 2014 02:59:17 +0400 Subject: RFR: 8043012: (tz) Support tzdata2014c Message-ID: <5373F545.6090406@oracle.com> Hello, Can I have a review for the tzdata2014c integration to JDK9. This is a standard release of tzdata (except the hurry with Egypt rules - the main part in this release). The following set of tests was executed with no failures: test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/sun/util/calendar test/java/util/TimeZone test/java/time test/java/util/Formatter test/closed/java/util/Calendar Webrev: http://cr.openjdk.java.net/~aefimov/8043012/9/webrev.00 Bug: https://bugs.openjdk.java.net/browse/JDK-8043012 Thank you, Aleksej From yuka.kamiya at oracle.com Thu May 15 01:54:56 2014 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Thu, 15 May 2014 10:54:56 +0900 Subject: RFR: 8043012: (tz) Support tzdata2014c In-Reply-To: <5373F545.6090406@oracle.com> References: <5373F545.6090406@oracle.com> Message-ID: <53741E70.7070205@oracle.com> Hi, The fix looks good to me. Thanks, -- Yuka (5/15/14, 7:59), Aleksej Efimov wrote: > Hello, > > Can I have a review for the tzdata2014c integration to JDK9. This is a standard release of tzdata (except the hurry with Egypt rules - the main part in this release). > The following set of tests was executed with no failures: > test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/sun/util/calendar test/java/util/TimeZone > test/java/time test/java/util/Formatter test/closed/java/util/Calendar > > Webrev: http://cr.openjdk.java.net/~aefimov/8043012/9/webrev.00 > Bug: https://bugs.openjdk.java.net/browse/JDK-8043012 > > Thank you, > Aleksej From Alan.Bateman at oracle.com Thu May 15 07:37:35 2014 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 15 May 2014 08:37:35 +0100 Subject: 8037343 Ready for review In-Reply-To: References: Message-ID: <53746EBF.5090900@oracle.com> Forwarding to i18n-dev as that it usually the list where changes to the locale and resources are maintained. -Alan On 15/05/2014 04:45, Sandipan Razzaque wrote: > Hi all, > > Please find below the webrev for bug 8037343. > > http://www.sandipan.net/public/webrevs/8037343/webrev.00 > > Thanks in advance - > > Cheers, > SR > > Sandipan Razzaque | www.sandipan.net From masayoshi.okutsu at oracle.com Thu May 15 07:54:48 2014 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Thu, 15 May 2014 16:54:48 +0900 Subject: RFR: 8043012: (tz) Support tzdata2014c In-Reply-To: <5373F545.6090406@oracle.com> References: <5373F545.6090406@oracle.com> Message-ID: <537472C8.3010803@oracle.com> Looks good to me. Masayoshi On 5/15/2014 7:59 AM, Aleksej Efimov wrote: > Hello, > > Can I have a review for the tzdata2014c integration to JDK9. This is a > standard release of tzdata (except the hurry with Egypt rules - the > main part in this release). > The following set of tests was executed with no failures: > test/sun/util/calendar test/java/util/Calendar > test/sun/util/resources/TimeZone test/sun/util/calendar > test/java/util/TimeZone > test/java/time test/java/util/Formatter test/closed/java/util/Calendar > > Webrev: http://cr.openjdk.java.net/~aefimov/8043012/9/webrev.00 > Bug: https://bugs.openjdk.java.net/browse/JDK-8043012 > > Thank you, > Aleksej From me at sandipan.net Sun May 18 17:13:03 2014 From: me at sandipan.net (Sandipan Razzaque) Date: Sun, 18 May 2014 13:13:03 -0400 Subject: 8037343 Ready for review Message-ID: Hi all - Not a huge priority by any means - but curious if anyone's had the chance to review the above yet? This would be my first contribution so just interested in getting any feedback. Cheers, SR Sandipan Razzaque | www.sandipan.net From masayoshi.okutsu at oracle.com Sun May 18 23:10:16 2014 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Mon, 19 May 2014 08:10:16 +0900 Subject: 8037343 Ready for review In-Reply-To: <53746EBF.5090900@oracle.com> References: <53746EBF.5090900@oracle.com> Message-ID: <53793DD8.4070202@oracle.com> Looks good to me. Thanks, Masayoshi On 5/15/2014 4:37 PM, Alan Bateman wrote: > > Forwarding to i18n-dev as that it usually the list where changes to > the locale and resources are maintained. > > -Alan > > On 15/05/2014 04:45, Sandipan Razzaque wrote: >> Hi all, >> >> Please find below the webrev for bug 8037343. >> >> http://www.sandipan.net/public/webrevs/8037343/webrev.00 >> >> Thanks in advance - >> >> Cheers, >> SR >> >> Sandipan Razzaque | www.sandipan.net > From masayoshi.okutsu at oracle.com Mon May 19 08:10:01 2014 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Mon, 19 May 2014 17:10:01 +0900 Subject: [9] RFR: 8032650: jdk/src/share/native/java/util: jni exception pending Message-ID: <5379BC59.3010003@oracle.com> Hello, Could you please review the fix for 8032650? The bug report isn't visible outside Oracle. The problem is that the second call to JNU_GetStringPlatformChars() in Java_java_util_TimeZone_getSystemTimeZoneID() in src/share/native/java/util/TimeZone.c ignores possible exceptions. I decided to eliminate the `country' argument from the function, which eliminates the call. `country' used to be used in old Windows to distinguish combined time zones, but it's no longer useful. (bestMatch in src/windows/native/java/util/TimeZone_md.c doesn't work well.) bug report: https://bugs.openjdk.java.net/browse/JDK-8032650 Webrev: http://cr.openjdk.java.net/~okutsu/9/8032650/webrev.00/ Thanks, Masayoshi From xueming.shen at oracle.com Mon May 19 18:12:16 2014 From: xueming.shen at oracle.com (Xueming Shen) Date: Mon, 19 May 2014 11:12:16 -0700 Subject: RFR: JDK-8042369 Remove duplicated java.time classes in build.tools.tzdb In-Reply-To: <53672CB4.3050708@oracle.com> References: <53672CB4.3050708@oracle.com> Message-ID: <537A4980.5050603@oracle.com> Hi, I've not got any feedback so far, so I assume it's good:-) Anyway, I'm going a little further to throw in a TarInputStream so now we just build the tzdb data directly on the tzdata201xy.tar.gz from iana site. I'm not sure if it is OK to check in the original .tar.gz file into the jdk repository though. There are also more improvements in this version, it is much faster now. It might not matter as it is only used during build time, though:-) http://cr.openjdk.java.net/~sherman/8042369/webrev -Sherman Btw, I'm still trying to sell the idea of checking in a second tzdb provider implementation into the jdk, which directly loads in the tzdb data by using the iana original source data, with the assumption that this might be useful at least in certain circumstance (such as one gov pushes a tz change, and some of your big jdk customers need their apps run with the new data in next 24 hrs...) in the future. http://cr.openjdk.java.net/~sherman/tzdbProvider/webrev On 05/04/2014 11:16 PM, Xueming Shen wrote: > Hi > > Please help review the change for #8042369 > > Issue: https://bugs.openjdk.java.net/browse/JDK-8042369 > Webrev: http://cr.openjdk.java.net/~sherman/8042369/webrev > > In jdk8 we had to duplicate dozen java.time classes in build.tools to build the timezone data > for the new JSR310 timezone data compiler, which uses the new jdk8 java.time classes (these > classes don't exit in the < 8 boot jdk). JDK9 has switched to use the jdk8 as the boot jdk, so > most of these duplicated classes are no longer needed, with ZoneRules as the only exception. > The ZoneRules is still needed to help the tzdb compiler to output the tzdb data in the > serialization forms of those transitions and rules. The proposed change here is to remove > those unneeded duplicated classes. > > I also took the opportunity to re-organize/re-wrote the "builder" classes to have a faster, simpler > and and straightforward implementation, with the goal of migrating it into a second default > ZoneRulesProvider later to plug it into jdk, so jdk/jre can uses the tzdb source data from the > IANA directly. One of the benefits of such a provider is that the end user may just drop the latest > timezone data file into the jdk/jre and go, without waiting for the latest timezone binary bits from > Oracle. > > Here is the webrev for the idea > http://cr.openjdk.java.net/~sherman/tzdbProvider/webrev/ > > The only disadvantage appears to be the possible "slowdown" of startup time because of > the reading and compiling of the 200k tzdb source data...(we need another new "bridge" for > j.u.TimeZone, if we go with this direction) > > Thanks! > -Sherman > > From naoto.sato at oracle.com Mon May 19 22:20:19 2014 From: naoto.sato at oracle.com (Naoto Sato) Date: Mon, 19 May 2014 15:20:19 -0700 Subject: [9] RFR: 8032650: jdk/src/share/native/java/util: jni exception pending In-Reply-To: <5379BC59.3010003@oracle.com> References: <5379BC59.3010003@oracle.com> Message-ID: <537A83A3.9020605@oracle.com> The fix itself looks good to me. However, there are pieces of code that deal with Windows releases that are no longer supported. Should we remove those dead code? Naoto On 5/19/26 H, 1:10 AM, Masayoshi Okutsu wrote: > Hello, > > Could you please review the fix for 8032650? The bug report isn't > visible outside Oracle. The problem is that the second call to > JNU_GetStringPlatformChars() in > Java_java_util_TimeZone_getSystemTimeZoneID() in > src/share/native/java/util/TimeZone.c ignores possible exceptions. I > decided to eliminate the `country' argument from the function, which > eliminates the call. `country' used to be used in old Windows to > distinguish combined time zones, but it's no longer useful. (bestMatch > in src/windows/native/java/util/TimeZone_md.c doesn't work well.) > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8032650 > > Webrev: > http://cr.openjdk.java.net/~okutsu/9/8032650/webrev.00/ > > Thanks, > Masayoshi > From masayoshi.okutsu at oracle.com Wed May 21 09:01:32 2014 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Wed, 21 May 2014 18:01:32 +0900 Subject: [9] RFR: 8032650: jdk/src/share/native/java/util: jni exception pending In-Reply-To: <537A83A3.9020605@oracle.com> References: <5379BC59.3010003@oracle.com> <537A83A3.9020605@oracle.com> Message-ID: <537C6B6C.4040705@oracle.com> Yes, we should. But it's a lot of work if we clean up old tools as well. I'd like to fix this one first. Masayoshi On 5/20/2014 7:20 AM, Naoto Sato wrote: > The fix itself looks good to me. However, there are pieces of code > that deal with Windows releases that are no longer supported. Should > we remove those dead code? > > Naoto > > On 5/19/26 H, 1:10 AM, Masayoshi Okutsu wrote: >> Hello, >> >> Could you please review the fix for 8032650? The bug report isn't >> visible outside Oracle. The problem is that the second call to >> JNU_GetStringPlatformChars() in >> Java_java_util_TimeZone_getSystemTimeZoneID() in >> src/share/native/java/util/TimeZone.c ignores possible exceptions. I >> decided to eliminate the `country' argument from the function, which >> eliminates the call. `country' used to be used in old Windows to >> distinguish combined time zones, but it's no longer useful. (bestMatch >> in src/windows/native/java/util/TimeZone_md.c doesn't work well.) >> >> bug report: >> https://bugs.openjdk.java.net/browse/JDK-8032650 >> >> Webrev: >> http://cr.openjdk.java.net/~okutsu/9/8032650/webrev.00/ >> >> Thanks, >> Masayoshi >> From me at sandipan.net Wed May 21 12:06:23 2014 From: me at sandipan.net (Sandipan Razzaque) Date: Wed, 21 May 2014 08:06:23 -0400 Subject: 8037343 Ready for merge Message-ID: Hi all, Patch 8037343 has been reviewed and is ready for merge. Please find it attached to this email. Cheers, SR Sandipan Razzaque | www.sandipan.net From me at sandipan.net Wed May 21 13:18:38 2014 From: me at sandipan.net (Sandipan Razzaque) Date: Wed, 21 May 2014 09:18:38 -0400 Subject: 8037343 Ready for merge In-Reply-To: References: Message-ID: Hi all, Take 2 - inlined into the email this time. Cheers, SR --- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java 2014-05-14 22:28:33.393717389 -0400 +++ new/src/share/classes/sun/text/resources/es/FormatData_es_DO.java 2014-05-14 22:28:33.277717384 -0400 @@ -75,8 +75,8 @@ new String[] { "EEEE d' de 'MMMM' de 'yyyy", // full date pattern "d' de 'MMMM' de 'yyyy", // long date pattern - "MM/dd/yyyy", // medium date pattern - "MM/dd/yy", // short date pattern + "dd/MM/yyyy", // medium date pattern + "dd/MM/yy", // short date pattern } }, { "DateTimePatterns", --- /dev/null 2014-05-11 05:40:37.233580026 -0400 +++ new/test/sun/text/resources/Format/Bug8037343.java 2014-05-14 22:28:33.713717403 -0400 @@ -0,0 +1,71 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8037343 + * @summary updating dateformat for es_DO + */ + +import java.text.DateFormat; +import java.util.Calendar; +import java.util.Locale; + +public class Bug8037343 +{ + + public static void main(String[] arg) + { + final Locale esDO = new Locale("es", "DO"); + final String expectedShort = "31/03/12"; + final String expectedMedium = "31/03/2012"; + + int errors = 0; + DateFormat format; + String result; + + Calendar cal = Calendar.getInstance(esDO); + cal.set(Calendar.DAY_OF_MONTH, 31); + cal.set(Calendar.MONTH, Calendar.MARCH); + cal.set(Calendar.YEAR, 2012); + + format = DateFormat.getDateInstance(DateFormat.SHORT, esDO); + result = format.format(cal.getTime()); + if (!expectedShort.equals(result)) { + System.out.println(String.format("Short Date format for es_DO is not as expected. Expected: [%s] Actual: [%s]", expectedShort, result)); + errors++; + } + + format = DateFormat.getDateInstance(DateFormat.MEDIUM, esDO); + result = format.format(cal.getTime()); + if (!expectedMedium.equals(result)) { + System.out.println(String.format("Medium Date format for es_DO is not as expected. Expected: [%s] Actual: [%s]", expectedMedium, result)); + errors++; + } + + if (errors > 0) { + throw new RuntimeException(); + } + } + +} Sandipan Razzaque | www.sandipan.net On Wed, May 21, 2014 at 8:06 AM, Sandipan Razzaque wrote: > Hi all, > > Patch 8037343 has been reviewed and is ready for merge. Please find it > attached to this email. > > Cheers, > SR > > Sandipan Razzaque | www.sandipan.net From naoto.sato at oracle.com Wed May 21 16:32:36 2014 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 21 May 2014 09:32:36 -0700 Subject: [9] RFR: 8032650: jdk/src/share/native/java/util: jni exception pending In-Reply-To: <537C6B6C.4040705@oracle.com> References: <5379BC59.3010003@oracle.com> <537A83A3.9020605@oracle.com> <537C6B6C.4040705@oracle.com> Message-ID: <537CD524.3070609@oracle.com> OK. Fair enough. Naoto On 5/21/26 H, 2:01 AM, Masayoshi Okutsu wrote: > Yes, we should. But it's a lot of work if we clean up old tools as well. > I'd like to fix this one first. > > Masayoshi > > On 5/20/2014 7:20 AM, Naoto Sato wrote: >> The fix itself looks good to me. However, there are pieces of code >> that deal with Windows releases that are no longer supported. Should >> we remove those dead code? >> >> Naoto >> >> On 5/19/26 H, 1:10 AM, Masayoshi Okutsu wrote: >>> Hello, >>> >>> Could you please review the fix for 8032650? The bug report isn't >>> visible outside Oracle. The problem is that the second call to >>> JNU_GetStringPlatformChars() in >>> Java_java_util_TimeZone_getSystemTimeZoneID() in >>> src/share/native/java/util/TimeZone.c ignores possible exceptions. I >>> decided to eliminate the `country' argument from the function, which >>> eliminates the call. `country' used to be used in old Windows to >>> distinguish combined time zones, but it's no longer useful. (bestMatch >>> in src/windows/native/java/util/TimeZone_md.c doesn't work well.) >>> >>> bug report: >>> https://bugs.openjdk.java.net/browse/JDK-8032650 >>> >>> Webrev: >>> http://cr.openjdk.java.net/~okutsu/9/8032650/webrev.00/ >>> >>> Thanks, >>> Masayoshi >>> > From michael.fang at oracle.com Wed May 21 18:02:04 2014 From: michael.fang at oracle.com (Michael Fang) Date: Wed, 21 May 2014 11:02:04 -0700 Subject: 8037343 Ready for merge In-Reply-To: References: Message-ID: <537CEA1C.4030004@oracle.com> Thanks Sandipan. I will work with our team to import, test, and push it to jdk9. thanks, -michael On 14?05?21? 06:18 ??, Sandipan Razzaque wrote: > Hi all, > > Take 2 - inlined into the email this time. > > Cheers, > SR > > --- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java > 2014-05-14 22:28:33.393717389 -0400 > +++ new/src/share/classes/sun/text/resources/es/FormatData_es_DO.java > 2014-05-14 22:28:33.277717384 -0400 > @@ -75,8 +75,8 @@ > new String[] { > "EEEE d' de 'MMMM' de 'yyyy", // full date pattern > "d' de 'MMMM' de 'yyyy", // long date pattern > - "MM/dd/yyyy", // medium date pattern > - "MM/dd/yy", // short date pattern > + "dd/MM/yyyy", // medium date pattern > + "dd/MM/yy", // short date pattern > } > }, > { "DateTimePatterns", > --- /dev/null 2014-05-11 05:40:37.233580026 -0400 > +++ new/test/sun/text/resources/Format/Bug8037343.java 2014-05-14 > 22:28:33.713717403 -0400 > @@ -0,0 +1,71 @@ > +/* > + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. > + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > + * > + * This code is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License version 2 only, as > + * published by the Free Software Foundation. > + * > + * This code is distributed in the hope that it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > + * version 2 for more details (a copy is included in the LICENSE file that > + * accompanied this code). > + * > + * You should have received a copy of the GNU General Public License version > + * 2 along with this work; if not, write to the Free Software Foundation, > + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. > + * > + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA > + * or visit www.oracle.com if you need additional information or have any > + * questions. > + */ > + > +/* > + * @test > + * @bug 8037343 > + * @summary updating dateformat for es_DO > + */ > + > +import java.text.DateFormat; > +import java.util.Calendar; > +import java.util.Locale; > + > +public class Bug8037343 > +{ > + > + public static void main(String[] arg) > + { > + final Locale esDO = new Locale("es", "DO"); > + final String expectedShort = "31/03/12"; > + final String expectedMedium = "31/03/2012"; > + > + int errors = 0; > + DateFormat format; > + String result; > + > + Calendar cal = Calendar.getInstance(esDO); > + cal.set(Calendar.DAY_OF_MONTH, 31); > + cal.set(Calendar.MONTH, Calendar.MARCH); > + cal.set(Calendar.YEAR, 2012); > + > + format = DateFormat.getDateInstance(DateFormat.SHORT, esDO); > + result = format.format(cal.getTime()); > + if (!expectedShort.equals(result)) { > + System.out.println(String.format("Short Date format for > es_DO is not as expected. Expected: [%s] Actual: [%s]", expectedShort, > result)); > + errors++; > + } > + > + format = DateFormat.getDateInstance(DateFormat.MEDIUM, esDO); > + result = format.format(cal.getTime()); > + if (!expectedMedium.equals(result)) { > + System.out.println(String.format("Medium Date format for > es_DO is not as expected. Expected: [%s] Actual: [%s]", > expectedMedium, result)); > + errors++; > + } > + > + if (errors> 0) { > + throw new RuntimeException(); > + } > + } > + > +} > > > > > > Sandipan Razzaque | www.sandipan.net > > > On Wed, May 21, 2014 at 8:06 AM, Sandipan Razzaque wrote: >> Hi all, >> >> Patch 8037343 has been reviewed and is ready for merge. Please find it >> attached to this email. >> >> Cheers, >> SR >> >> Sandipan Razzaque | www.sandipan.net From me at sandipan.net Wed May 21 18:53:27 2014 From: me at sandipan.net (Sandipan Razzaque) Date: Wed, 21 May 2014 14:53:27 -0400 Subject: 8037343 Ready for merge In-Reply-To: <537CEA1C.4030004@oracle.com> References: <537CEA1C.4030004@oracle.com> Message-ID: Thanks Michael & team! Cheers, SR Sandipan Razzaque | www.sandipan.net On Wed, May 21, 2014 at 2:02 PM, Michael Fang wrote: > Thanks Sandipan. > > I will work with our team to import, test, and push it to jdk9. > > thanks, > > -michael > > On 14?05?21? 06:18 ??, Sandipan Razzaque wrote: >> >> Hi all, >> >> Take 2 - inlined into the email this time. >> >> Cheers, >> SR >> >> --- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >> 2014-05-14 22:28:33.393717389 -0400 >> +++ new/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >> 2014-05-14 22:28:33.277717384 -0400 >> @@ -75,8 +75,8 @@ >> new String[] { >> "EEEE d' de 'MMMM' de 'yyyy", // full date pattern >> "d' de 'MMMM' de 'yyyy", // long date pattern >> - "MM/dd/yyyy", // medium date pattern >> - "MM/dd/yy", // short date pattern >> + "dd/MM/yyyy", // medium date pattern >> + "dd/MM/yy", // short date pattern >> } >> }, >> { "DateTimePatterns", >> --- /dev/null 2014-05-11 05:40:37.233580026 -0400 >> +++ new/test/sun/text/resources/Format/Bug8037343.java 2014-05-14 >> 22:28:33.713717403 -0400 >> @@ -0,0 +1,71 @@ >> +/* >> + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. >> + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> + * >> + * This code is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License version 2 only, as >> + * published by the Free Software Foundation. >> + * >> + * This code is distributed in the hope that it will be useful, but >> WITHOUT >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License >> + * version 2 for more details (a copy is included in the LICENSE file >> that >> + * accompanied this code). >> + * >> + * You should have received a copy of the GNU General Public License >> version >> + * 2 along with this work; if not, write to the Free Software Foundation, >> + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >> + * >> + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 >> USA >> + * or visit www.oracle.com if you need additional information or have any >> + * questions. >> + */ >> + >> +/* >> + * @test >> + * @bug 8037343 >> + * @summary updating dateformat for es_DO >> + */ >> + >> +import java.text.DateFormat; >> +import java.util.Calendar; >> +import java.util.Locale; >> + >> +public class Bug8037343 >> +{ >> + >> + public static void main(String[] arg) >> + { >> + final Locale esDO = new Locale("es", "DO"); >> + final String expectedShort = "31/03/12"; >> + final String expectedMedium = "31/03/2012"; >> + >> + int errors = 0; >> + DateFormat format; >> + String result; >> + >> + Calendar cal = Calendar.getInstance(esDO); >> + cal.set(Calendar.DAY_OF_MONTH, 31); >> + cal.set(Calendar.MONTH, Calendar.MARCH); >> + cal.set(Calendar.YEAR, 2012); >> + >> + format = DateFormat.getDateInstance(DateFormat.SHORT, esDO); >> + result = format.format(cal.getTime()); >> + if (!expectedShort.equals(result)) { >> + System.out.println(String.format("Short Date format for >> es_DO is not as expected. Expected: [%s] Actual: [%s]", expectedShort, >> result)); >> + errors++; >> + } >> + >> + format = DateFormat.getDateInstance(DateFormat.MEDIUM, esDO); >> + result = format.format(cal.getTime()); >> + if (!expectedMedium.equals(result)) { >> + System.out.println(String.format("Medium Date format for >> es_DO is not as expected. Expected: [%s] Actual: [%s]", >> expectedMedium, result)); >> + errors++; >> + } >> + >> + if (errors> 0) { >> + throw new RuntimeException(); >> + } >> + } >> + >> +} >> >> >> >> >> >> Sandipan Razzaque | www.sandipan.net >> >> >> On Wed, May 21, 2014 at 8:06 AM, Sandipan Razzaque >> wrote: >>> >>> Hi all, >>> >>> Patch 8037343 has been reviewed and is ready for merge. Please find it >>> attached to this email. >>> >>> Cheers, >>> SR >>> >>> Sandipan Razzaque | www.sandipan.net From michael.fang at oracle.com Wed May 21 19:15:01 2014 From: michael.fang at oracle.com (Michael Fang) Date: Wed, 21 May 2014 12:15:01 -0700 Subject: 8037343 Ready for merge In-Reply-To: References: <537CEA1C.4030004@oracle.com> Message-ID: <537CFB35.6050409@oracle.com> You are welcome, Sandipan. Thanks for your contribution. -michael On 14?05?21? 11:53 ??, Sandipan Razzaque wrote: > Thanks Michael& team! > > Cheers, > SR > Sandipan Razzaque | www.sandipan.net > > > On Wed, May 21, 2014 at 2:02 PM, Michael Fang wrote: >> Thanks Sandipan. >> >> I will work with our team to import, test, and push it to jdk9. >> >> thanks, >> >> -michael >> >> On 14?05?21? 06:18 ??, Sandipan Razzaque wrote: >>> Hi all, >>> >>> Take 2 - inlined into the email this time. >>> >>> Cheers, >>> SR >>> >>> --- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >>> 2014-05-14 22:28:33.393717389 -0400 >>> +++ new/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >>> 2014-05-14 22:28:33.277717384 -0400 >>> @@ -75,8 +75,8 @@ >>> new String[] { >>> "EEEE d' de 'MMMM' de 'yyyy", // full date pattern >>> "d' de 'MMMM' de 'yyyy", // long date pattern >>> - "MM/dd/yyyy", // medium date pattern >>> - "MM/dd/yy", // short date pattern >>> + "dd/MM/yyyy", // medium date pattern >>> + "dd/MM/yy", // short date pattern >>> } >>> }, >>> { "DateTimePatterns", >>> --- /dev/null 2014-05-11 05:40:37.233580026 -0400 >>> +++ new/test/sun/text/resources/Format/Bug8037343.java 2014-05-14 >>> 22:28:33.713717403 -0400 >>> @@ -0,0 +1,71 @@ >>> +/* >>> + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. >>> + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >>> + * >>> + * This code is free software; you can redistribute it and/or modify it >>> + * under the terms of the GNU General Public License version 2 only, as >>> + * published by the Free Software Foundation. >>> + * >>> + * This code is distributed in the hope that it will be useful, but >>> WITHOUT >>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License >>> + * version 2 for more details (a copy is included in the LICENSE file >>> that >>> + * accompanied this code). >>> + * >>> + * You should have received a copy of the GNU General Public License >>> version >>> + * 2 along with this work; if not, write to the Free Software Foundation, >>> + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >>> + * >>> + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 >>> USA >>> + * or visit www.oracle.com if you need additional information or have any >>> + * questions. >>> + */ >>> + >>> +/* >>> + * @test >>> + * @bug 8037343 >>> + * @summary updating dateformat for es_DO >>> + */ >>> + >>> +import java.text.DateFormat; >>> +import java.util.Calendar; >>> +import java.util.Locale; >>> + >>> +public class Bug8037343 >>> +{ >>> + >>> + public static void main(String[] arg) >>> + { >>> + final Locale esDO = new Locale("es", "DO"); >>> + final String expectedShort = "31/03/12"; >>> + final String expectedMedium = "31/03/2012"; >>> + >>> + int errors = 0; >>> + DateFormat format; >>> + String result; >>> + >>> + Calendar cal = Calendar.getInstance(esDO); >>> + cal.set(Calendar.DAY_OF_MONTH, 31); >>> + cal.set(Calendar.MONTH, Calendar.MARCH); >>> + cal.set(Calendar.YEAR, 2012); >>> + >>> + format = DateFormat.getDateInstance(DateFormat.SHORT, esDO); >>> + result = format.format(cal.getTime()); >>> + if (!expectedShort.equals(result)) { >>> + System.out.println(String.format("Short Date format for >>> es_DO is not as expected. Expected: [%s] Actual: [%s]", expectedShort, >>> result)); >>> + errors++; >>> + } >>> + >>> + format = DateFormat.getDateInstance(DateFormat.MEDIUM, esDO); >>> + result = format.format(cal.getTime()); >>> + if (!expectedMedium.equals(result)) { >>> + System.out.println(String.format("Medium Date format for >>> es_DO is not as expected. Expected: [%s] Actual: [%s]", >>> expectedMedium, result)); >>> + errors++; >>> + } >>> + >>> + if (errors> 0) { >>> + throw new RuntimeException(); >>> + } >>> + } >>> + >>> +} >>> >>> >>> >>> >>> >>> Sandipan Razzaque | www.sandipan.net >>> >>> >>> On Wed, May 21, 2014 at 8:06 AM, Sandipan Razzaque >>> wrote: >>>> Hi all, >>>> >>>> Patch 8037343 has been reviewed and is ready for merge. Please find it >>>> attached to this email. >>>> >>>> Cheers, >>>> SR >>>> >>>> Sandipan Razzaque | www.sandipan.net From michael.fang at oracle.com Thu May 22 00:13:40 2014 From: michael.fang at oracle.com (Michael Fang) Date: Wed, 21 May 2014 17:13:40 -0700 Subject: 8037343 Ready for merge In-Reply-To: <537CFB35.6050409@oracle.com> References: <537CEA1C.4030004@oracle.com> <537CFB35.6050409@oracle.com> Message-ID: <537D4134.7030807@oracle.com> Hi all, I created a test build and ran regression tests. LocaleDataTest failed. I have updated the test data related to this bug fix. Please review the changes related to LocaleDataTest. http://cr.openjdk.java.net/~mfang/8037343/webrev.00/ thanks, -michael On 14?05?21? 12:15 ??, Michael Fang wrote: > You are welcome, Sandipan. > > Thanks for your contribution. > > -michael > > On 14?05?21? 11:53 ??, Sandipan Razzaque wrote: >> Thanks Michael& team! >> >> Cheers, >> SR >> Sandipan Razzaque | www.sandipan.net >> >> >> On Wed, May 21, 2014 at 2:02 PM, Michael >> Fang wrote: >>> Thanks Sandipan. >>> >>> I will work with our team to import, test, and push it to jdk9. >>> >>> thanks, >>> >>> -michael >>> >>> On 14?05?21? 06:18 ??, Sandipan Razzaque wrote: >>>> Hi all, >>>> >>>> Take 2 - inlined into the email this time. >>>> >>>> Cheers, >>>> SR >>>> >>>> --- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >>>> 2014-05-14 22:28:33.393717389 -0400 >>>> +++ new/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >>>> 2014-05-14 22:28:33.277717384 -0400 >>>> @@ -75,8 +75,8 @@ >>>> new String[] { >>>> "EEEE d' de 'MMMM' de 'yyyy", // full date >>>> pattern >>>> "d' de 'MMMM' de 'yyyy", // long date pattern >>>> - "MM/dd/yyyy", // medium date pattern >>>> - "MM/dd/yy", // short date pattern >>>> + "dd/MM/yyyy", // medium date pattern >>>> + "dd/MM/yy", // short date pattern >>>> } >>>> }, >>>> { "DateTimePatterns", >>>> --- /dev/null 2014-05-11 05:40:37.233580026 -0400 >>>> +++ new/test/sun/text/resources/Format/Bug8037343.java 2014-05-14 >>>> 22:28:33.713717403 -0400 >>>> @@ -0,0 +1,71 @@ >>>> +/* >>>> + * Copyright (c) 2014, Oracle and/or its affiliates. All rights >>>> reserved. >>>> + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >>>> + * >>>> + * This code is free software; you can redistribute it and/or >>>> modify it >>>> + * under the terms of the GNU General Public License version 2 >>>> only, as >>>> + * published by the Free Software Foundation. >>>> + * >>>> + * This code is distributed in the hope that it will be useful, but >>>> WITHOUT >>>> + * ANY WARRANTY; without even the implied warranty of >>>> MERCHANTABILITY or >>>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public >>>> License >>>> + * version 2 for more details (a copy is included in the LICENSE file >>>> that >>>> + * accompanied this code). >>>> + * >>>> + * You should have received a copy of the GNU General Public License >>>> version >>>> + * 2 along with this work; if not, write to the Free Software >>>> Foundation, >>>> + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >>>> + * >>>> + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA >>>> 94065 >>>> USA >>>> + * or visit www.oracle.com if you need additional information or >>>> have any >>>> + * questions. >>>> + */ >>>> + >>>> +/* >>>> + * @test >>>> + * @bug 8037343 >>>> + * @summary updating dateformat for es_DO >>>> + */ >>>> + >>>> +import java.text.DateFormat; >>>> +import java.util.Calendar; >>>> +import java.util.Locale; >>>> + >>>> +public class Bug8037343 >>>> +{ >>>> + >>>> + public static void main(String[] arg) >>>> + { >>>> + final Locale esDO = new Locale("es", "DO"); >>>> + final String expectedShort = "31/03/12"; >>>> + final String expectedMedium = "31/03/2012"; >>>> + >>>> + int errors = 0; >>>> + DateFormat format; >>>> + String result; >>>> + >>>> + Calendar cal = Calendar.getInstance(esDO); >>>> + cal.set(Calendar.DAY_OF_MONTH, 31); >>>> + cal.set(Calendar.MONTH, Calendar.MARCH); >>>> + cal.set(Calendar.YEAR, 2012); >>>> + >>>> + format = DateFormat.getDateInstance(DateFormat.SHORT, esDO); >>>> + result = format.format(cal.getTime()); >>>> + if (!expectedShort.equals(result)) { >>>> + System.out.println(String.format("Short Date format for >>>> es_DO is not as expected. Expected: [%s] Actual: [%s]", expectedShort, >>>> result)); >>>> + errors++; >>>> + } >>>> + >>>> + format = DateFormat.getDateInstance(DateFormat.MEDIUM, esDO); >>>> + result = format.format(cal.getTime()); >>>> + if (!expectedMedium.equals(result)) { >>>> + System.out.println(String.format("Medium Date format for >>>> es_DO is not as expected. Expected: [%s] Actual: [%s]", >>>> expectedMedium, result)); >>>> + errors++; >>>> + } >>>> + >>>> + if (errors> 0) { >>>> + throw new RuntimeException(); >>>> + } >>>> + } >>>> + >>>> +} >>>> >>>> >>>> >>>> >>>> >>>> Sandipan Razzaque | www.sandipan.net >>>> >>>> >>>> On Wed, May 21, 2014 at 8:06 AM, Sandipan Razzaque >>>> wrote: >>>>> Hi all, >>>>> >>>>> Patch 8037343 has been reviewed and is ready for merge. Please >>>>> find it >>>>> attached to this email. >>>>> >>>>> Cheers, >>>>> SR >>>>> >>>>> Sandipan Razzaque | www.sandipan.net From masayoshi.okutsu at oracle.com Thu May 22 00:23:26 2014 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Thu, 22 May 2014 09:23:26 +0900 Subject: 8037343 Ready for merge In-Reply-To: <537D4134.7030807@oracle.com> References: <537CEA1C.4030004@oracle.com> <537CFB35.6050409@oracle.com> <537D4134.7030807@oracle.com> Message-ID: <537D437E.6040906@oracle.com> Sorry, I forgot about LocaleDataTest. The fix looks good to me. Masayoshi On 5/22/2014 9:13 AM, Michael Fang wrote: > Hi all, > > I created a test build and ran regression tests. LocaleDataTest > failed. I have updated the test data related to this bug fix. Please > review the changes related to LocaleDataTest. > > http://cr.openjdk.java.net/~mfang/8037343/webrev.00/ > > thanks, > > -michael > > On 14?05?21? 12:15 ??, Michael Fang wrote: >> You are welcome, Sandipan. >> >> Thanks for your contribution. >> >> -michael >> >> On 14?05?21? 11:53 ??, Sandipan Razzaque wrote: >>> Thanks Michael& team! >>> >>> Cheers, >>> SR >>> Sandipan Razzaque | www.sandipan.net >>> >>> >>> On Wed, May 21, 2014 at 2:02 PM, Michael >>> Fang wrote: >>>> Thanks Sandipan. >>>> >>>> I will work with our team to import, test, and push it to jdk9. >>>> >>>> thanks, >>>> >>>> -michael >>>> >>>> On 14?05?21? 06:18 ??, Sandipan Razzaque wrote: >>>>> Hi all, >>>>> >>>>> Take 2 - inlined into the email this time. >>>>> >>>>> Cheers, >>>>> SR >>>>> >>>>> --- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >>>>> 2014-05-14 22:28:33.393717389 -0400 >>>>> +++ new/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >>>>> 2014-05-14 22:28:33.277717384 -0400 >>>>> @@ -75,8 +75,8 @@ >>>>> new String[] { >>>>> "EEEE d' de 'MMMM' de 'yyyy", // full date >>>>> pattern >>>>> "d' de 'MMMM' de 'yyyy", // long date pattern >>>>> - "MM/dd/yyyy", // medium date pattern >>>>> - "MM/dd/yy", // short date pattern >>>>> + "dd/MM/yyyy", // medium date pattern >>>>> + "dd/MM/yy", // short date pattern >>>>> } >>>>> }, >>>>> { "DateTimePatterns", >>>>> --- /dev/null 2014-05-11 05:40:37.233580026 -0400 >>>>> +++ new/test/sun/text/resources/Format/Bug8037343.java 2014-05-14 >>>>> 22:28:33.713717403 -0400 >>>>> @@ -0,0 +1,71 @@ >>>>> +/* >>>>> + * Copyright (c) 2014, Oracle and/or its affiliates. All rights >>>>> reserved. >>>>> + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >>>>> + * >>>>> + * This code is free software; you can redistribute it and/or >>>>> modify it >>>>> + * under the terms of the GNU General Public License version 2 >>>>> only, as >>>>> + * published by the Free Software Foundation. >>>>> + * >>>>> + * This code is distributed in the hope that it will be useful, but >>>>> WITHOUT >>>>> + * ANY WARRANTY; without even the implied warranty of >>>>> MERCHANTABILITY or >>>>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public >>>>> License >>>>> + * version 2 for more details (a copy is included in the LICENSE >>>>> file >>>>> that >>>>> + * accompanied this code). >>>>> + * >>>>> + * You should have received a copy of the GNU General Public License >>>>> version >>>>> + * 2 along with this work; if not, write to the Free Software >>>>> Foundation, >>>>> + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >>>>> + * >>>>> + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA >>>>> 94065 >>>>> USA >>>>> + * or visit www.oracle.com if you need additional information or >>>>> have any >>>>> + * questions. >>>>> + */ >>>>> + >>>>> +/* >>>>> + * @test >>>>> + * @bug 8037343 >>>>> + * @summary updating dateformat for es_DO >>>>> + */ >>>>> + >>>>> +import java.text.DateFormat; >>>>> +import java.util.Calendar; >>>>> +import java.util.Locale; >>>>> + >>>>> +public class Bug8037343 >>>>> +{ >>>>> + >>>>> + public static void main(String[] arg) >>>>> + { >>>>> + final Locale esDO = new Locale("es", "DO"); >>>>> + final String expectedShort = "31/03/12"; >>>>> + final String expectedMedium = "31/03/2012"; >>>>> + >>>>> + int errors = 0; >>>>> + DateFormat format; >>>>> + String result; >>>>> + >>>>> + Calendar cal = Calendar.getInstance(esDO); >>>>> + cal.set(Calendar.DAY_OF_MONTH, 31); >>>>> + cal.set(Calendar.MONTH, Calendar.MARCH); >>>>> + cal.set(Calendar.YEAR, 2012); >>>>> + >>>>> + format = DateFormat.getDateInstance(DateFormat.SHORT, esDO); >>>>> + result = format.format(cal.getTime()); >>>>> + if (!expectedShort.equals(result)) { >>>>> + System.out.println(String.format("Short Date format for >>>>> es_DO is not as expected. Expected: [%s] Actual: [%s]", >>>>> expectedShort, >>>>> result)); >>>>> + errors++; >>>>> + } >>>>> + >>>>> + format = DateFormat.getDateInstance(DateFormat.MEDIUM, >>>>> esDO); >>>>> + result = format.format(cal.getTime()); >>>>> + if (!expectedMedium.equals(result)) { >>>>> + System.out.println(String.format("Medium Date format for >>>>> es_DO is not as expected. Expected: [%s] Actual: [%s]", >>>>> expectedMedium, result)); >>>>> + errors++; >>>>> + } >>>>> + >>>>> + if (errors> 0) { >>>>> + throw new RuntimeException(); >>>>> + } >>>>> + } >>>>> + >>>>> +} >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> Sandipan Razzaque | www.sandipan.net >>>>> >>>>> >>>>> On Wed, May 21, 2014 at 8:06 AM, Sandipan Razzaque >>>>> wrote: >>>>>> Hi all, >>>>>> >>>>>> Patch 8037343 has been reviewed and is ready for merge. Please >>>>>> find it >>>>>> attached to this email. >>>>>> >>>>>> Cheers, >>>>>> SR >>>>>> >>>>>> Sandipan Razzaque | www.sandipan.net From michael.fang at oracle.com Thu May 22 01:25:25 2014 From: michael.fang at oracle.com (Michael Fang) Date: Wed, 21 May 2014 18:25:25 -0700 Subject: 8037343 Ready for merge In-Reply-To: <537D437E.6040906@oracle.com> References: <537CEA1C.4030004@oracle.com> <537CFB35.6050409@oracle.com> <537D4134.7030807@oracle.com> <537D437E.6040906@oracle.com> Message-ID: Thanks Masayoshi. Regards, Michael Sent from my iPhone > Masayoshi Okutsu ? May 21, 2014 5:23 PM ??? > > Sorry, I forgot about LocaleDataTest. The fix looks good to me. > > Masayoshi > >> On 5/22/2014 9:13 AM, Michael Fang wrote: >> Hi all, >> >> I created a test build and ran regression tests. LocaleDataTest failed. I have updated the test data related to this bug fix. Please review the changes related to LocaleDataTest. >> >> http://cr.openjdk.java.net/~mfang/8037343/webrev.00/ >> >> thanks, >> >> -michael >> >>> On 14?05?21? 12:15 ??, Michael Fang wrote: >>> You are welcome, Sandipan. >>> >>> Thanks for your contribution. >>> >>> -michael >>> >>>> On 14?05?21? 11:53 ??, Sandipan Razzaque wrote: >>>> Thanks Michael& team! >>>> >>>> Cheers, >>>> SR >>>> Sandipan Razzaque | www.sandipan.net >>>> >>>> >>>>> On Wed, May 21, 2014 at 2:02 PM, Michael Fang wrote: >>>>> Thanks Sandipan. >>>>> >>>>> I will work with our team to import, test, and push it to jdk9. >>>>> >>>>> thanks, >>>>> >>>>> -michael >>>>> >>>>>> On 14?05?21? 06:18 ??, Sandipan Razzaque wrote: >>>>>> Hi all, >>>>>> >>>>>> Take 2 - inlined into the email this time. >>>>>> >>>>>> Cheers, >>>>>> SR >>>>>> >>>>>> --- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >>>>>> 2014-05-14 22:28:33.393717389 -0400 >>>>>> +++ new/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >>>>>> 2014-05-14 22:28:33.277717384 -0400 >>>>>> @@ -75,8 +75,8 @@ >>>>>> new String[] { >>>>>> "EEEE d' de 'MMMM' de 'yyyy", // full date pattern >>>>>> "d' de 'MMMM' de 'yyyy", // long date pattern >>>>>> - "MM/dd/yyyy", // medium date pattern >>>>>> - "MM/dd/yy", // short date pattern >>>>>> + "dd/MM/yyyy", // medium date pattern >>>>>> + "dd/MM/yy", // short date pattern >>>>>> } >>>>>> }, >>>>>> { "DateTimePatterns", >>>>>> --- /dev/null 2014-05-11 05:40:37.233580026 -0400 >>>>>> +++ new/test/sun/text/resources/Format/Bug8037343.java 2014-05-14 >>>>>> 22:28:33.713717403 -0400 >>>>>> @@ -0,0 +1,71 @@ >>>>>> +/* >>>>>> + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. >>>>>> + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >>>>>> + * >>>>>> + * This code is free software; you can redistribute it and/or modify it >>>>>> + * under the terms of the GNU General Public License version 2 only, as >>>>>> + * published by the Free Software Foundation. >>>>>> + * >>>>>> + * This code is distributed in the hope that it will be useful, but >>>>>> WITHOUT >>>>>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >>>>>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License >>>>>> + * version 2 for more details (a copy is included in the LICENSE file >>>>>> that >>>>>> + * accompanied this code). >>>>>> + * >>>>>> + * You should have received a copy of the GNU General Public License >>>>>> version >>>>>> + * 2 along with this work; if not, write to the Free Software Foundation, >>>>>> + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >>>>>> + * >>>>>> + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 >>>>>> USA >>>>>> + * or visit www.oracle.com if you need additional information or have any >>>>>> + * questions. >>>>>> + */ >>>>>> + >>>>>> +/* >>>>>> + * @test >>>>>> + * @bug 8037343 >>>>>> + * @summary updating dateformat for es_DO >>>>>> + */ >>>>>> + >>>>>> +import java.text.DateFormat; >>>>>> +import java.util.Calendar; >>>>>> +import java.util.Locale; >>>>>> + >>>>>> +public class Bug8037343 >>>>>> +{ >>>>>> + >>>>>> + public static void main(String[] arg) >>>>>> + { >>>>>> + final Locale esDO = new Locale("es", "DO"); >>>>>> + final String expectedShort = "31/03/12"; >>>>>> + final String expectedMedium = "31/03/2012"; >>>>>> + >>>>>> + int errors = 0; >>>>>> + DateFormat format; >>>>>> + String result; >>>>>> + >>>>>> + Calendar cal = Calendar.getInstance(esDO); >>>>>> + cal.set(Calendar.DAY_OF_MONTH, 31); >>>>>> + cal.set(Calendar.MONTH, Calendar.MARCH); >>>>>> + cal.set(Calendar.YEAR, 2012); >>>>>> + >>>>>> + format = DateFormat.getDateInstance(DateFormat.SHORT, esDO); >>>>>> + result = format.format(cal.getTime()); >>>>>> + if (!expectedShort.equals(result)) { >>>>>> + System.out.println(String.format("Short Date format for >>>>>> es_DO is not as expected. Expected: [%s] Actual: [%s]", expectedShort, >>>>>> result)); >>>>>> + errors++; >>>>>> + } >>>>>> + >>>>>> + format = DateFormat.getDateInstance(DateFormat.MEDIUM, esDO); >>>>>> + result = format.format(cal.getTime()); >>>>>> + if (!expectedMedium.equals(result)) { >>>>>> + System.out.println(String.format("Medium Date format for >>>>>> es_DO is not as expected. Expected: [%s] Actual: [%s]", >>>>>> expectedMedium, result)); >>>>>> + errors++; >>>>>> + } >>>>>> + >>>>>> + if (errors> 0) { >>>>>> + throw new RuntimeException(); >>>>>> + } >>>>>> + } >>>>>> + >>>>>> +} >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Sandipan Razzaque | www.sandipan.net >>>>>> >>>>>> >>>>>> On Wed, May 21, 2014 at 8:06 AM, Sandipan Razzaque >>>>>> wrote: >>>>>>> Hi all, >>>>>>> >>>>>>> Patch 8037343 has been reviewed and is ready for merge. Please find it >>>>>>> attached to this email. >>>>>>> >>>>>>> Cheers, >>>>>>> SR >>>>>>> >>>>>>> Sandipan Razzaque | www.sandipan.net > From michael.fang at oracle.com Thu May 22 18:27:11 2014 From: michael.fang at oracle.com (Michael Fang) Date: Thu, 22 May 2014 11:27:11 -0700 Subject: 8037343 Ready for merge In-Reply-To: <537D437E.6040906@oracle.com> References: <537CEA1C.4030004@oracle.com> <537CFB35.6050409@oracle.com> <537D4134.7030807@oracle.com> <537D437E.6040906@oracle.com> Message-ID: <537E417F.7040206@oracle.com> Thanks Masayoshi. I have pushed the changeset to jdk9/dev. thanks, -michael On 14?05?21? 05:23 ??, Masayoshi Okutsu wrote: > Sorry, I forgot about LocaleDataTest. The fix looks good to me. > > Masayoshi > > On 5/22/2014 9:13 AM, Michael Fang wrote: >> Hi all, >> >> I created a test build and ran regression tests. LocaleDataTest >> failed. I have updated the test data related to this bug fix. Please >> review the changes related to LocaleDataTest. >> >> http://cr.openjdk.java.net/~mfang/8037343/webrev.00/ >> >> thanks, >> >> -michael >> >> On 14?05?21? 12:15 ??, Michael Fang wrote: >>> You are welcome, Sandipan. >>> >>> Thanks for your contribution. >>> >>> -michael >>> >>> On 14?05?21? 11:53 ??, Sandipan Razzaque wrote: >>>> Thanks Michael& team! >>>> >>>> Cheers, >>>> SR >>>> Sandipan Razzaque | www.sandipan.net >>>> >>>> >>>> On Wed, May 21, 2014 at 2:02 PM, Michael >>>> Fang wrote: >>>>> Thanks Sandipan. >>>>> >>>>> I will work with our team to import, test, and push it to jdk9. >>>>> >>>>> thanks, >>>>> >>>>> -michael >>>>> >>>>> On 14?05?21? 06:18 ??, Sandipan Razzaque wrote: >>>>>> Hi all, >>>>>> >>>>>> Take 2 - inlined into the email this time. >>>>>> >>>>>> Cheers, >>>>>> SR >>>>>> >>>>>> --- >>>>>> old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >>>>>> 2014-05-14 22:28:33.393717389 -0400 >>>>>> +++ >>>>>> new/src/share/classes/sun/text/resources/es/FormatData_es_DO.java >>>>>> 2014-05-14 22:28:33.277717384 -0400 >>>>>> @@ -75,8 +75,8 @@ >>>>>> new String[] { >>>>>> "EEEE d' de 'MMMM' de 'yyyy", // full date >>>>>> pattern >>>>>> "d' de 'MMMM' de 'yyyy", // long date pattern >>>>>> - "MM/dd/yyyy", // medium date pattern >>>>>> - "MM/dd/yy", // short date pattern >>>>>> + "dd/MM/yyyy", // medium date pattern >>>>>> + "dd/MM/yy", // short date pattern >>>>>> } >>>>>> }, >>>>>> { "DateTimePatterns", >>>>>> --- /dev/null 2014-05-11 05:40:37.233580026 -0400 >>>>>> +++ new/test/sun/text/resources/Format/Bug8037343.java 2014-05-14 >>>>>> 22:28:33.713717403 -0400 >>>>>> @@ -0,0 +1,71 @@ >>>>>> +/* >>>>>> + * Copyright (c) 2014, Oracle and/or its affiliates. All rights >>>>>> reserved. >>>>>> + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >>>>>> + * >>>>>> + * This code is free software; you can redistribute it and/or >>>>>> modify it >>>>>> + * under the terms of the GNU General Public License version 2 >>>>>> only, as >>>>>> + * published by the Free Software Foundation. >>>>>> + * >>>>>> + * This code is distributed in the hope that it will be useful, but >>>>>> WITHOUT >>>>>> + * ANY WARRANTY; without even the implied warranty of >>>>>> MERCHANTABILITY or >>>>>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public >>>>>> License >>>>>> + * version 2 for more details (a copy is included in the LICENSE >>>>>> file >>>>>> that >>>>>> + * accompanied this code). >>>>>> + * >>>>>> + * You should have received a copy of the GNU General Public >>>>>> License >>>>>> version >>>>>> + * 2 along with this work; if not, write to the Free Software >>>>>> Foundation, >>>>>> + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >>>>>> + * >>>>>> + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA >>>>>> 94065 >>>>>> USA >>>>>> + * or visit www.oracle.com if you need additional information or >>>>>> have any >>>>>> + * questions. >>>>>> + */ >>>>>> + >>>>>> +/* >>>>>> + * @test >>>>>> + * @bug 8037343 >>>>>> + * @summary updating dateformat for es_DO >>>>>> + */ >>>>>> + >>>>>> +import java.text.DateFormat; >>>>>> +import java.util.Calendar; >>>>>> +import java.util.Locale; >>>>>> + >>>>>> +public class Bug8037343 >>>>>> +{ >>>>>> + >>>>>> + public static void main(String[] arg) >>>>>> + { >>>>>> + final Locale esDO = new Locale("es", "DO"); >>>>>> + final String expectedShort = "31/03/12"; >>>>>> + final String expectedMedium = "31/03/2012"; >>>>>> + >>>>>> + int errors = 0; >>>>>> + DateFormat format; >>>>>> + String result; >>>>>> + >>>>>> + Calendar cal = Calendar.getInstance(esDO); >>>>>> + cal.set(Calendar.DAY_OF_MONTH, 31); >>>>>> + cal.set(Calendar.MONTH, Calendar.MARCH); >>>>>> + cal.set(Calendar.YEAR, 2012); >>>>>> + >>>>>> + format = DateFormat.getDateInstance(DateFormat.SHORT, >>>>>> esDO); >>>>>> + result = format.format(cal.getTime()); >>>>>> + if (!expectedShort.equals(result)) { >>>>>> + System.out.println(String.format("Short Date format for >>>>>> es_DO is not as expected. Expected: [%s] Actual: [%s]", >>>>>> expectedShort, >>>>>> result)); >>>>>> + errors++; >>>>>> + } >>>>>> + >>>>>> + format = DateFormat.getDateInstance(DateFormat.MEDIUM, >>>>>> esDO); >>>>>> + result = format.format(cal.getTime()); >>>>>> + if (!expectedMedium.equals(result)) { >>>>>> + System.out.println(String.format("Medium Date format >>>>>> for >>>>>> es_DO is not as expected. Expected: [%s] Actual: [%s]", >>>>>> expectedMedium, result)); >>>>>> + errors++; >>>>>> + } >>>>>> + >>>>>> + if (errors> 0) { >>>>>> + throw new RuntimeException(); >>>>>> + } >>>>>> + } >>>>>> + >>>>>> +} >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Sandipan Razzaque | www.sandipan.net >>>>>> >>>>>> >>>>>> On Wed, May 21, 2014 at 8:06 AM, Sandipan Razzaque >>>>>> wrote: >>>>>>> Hi all, >>>>>>> >>>>>>> Patch 8037343 has been reviewed and is ready for merge. Please >>>>>>> find it >>>>>>> attached to this email. >>>>>>> >>>>>>> Cheers, >>>>>>> SR >>>>>>> >>>>>>> Sandipan Razzaque | www.sandipan.net > From masayoshi.okutsu at oracle.com Fri May 23 08:37:53 2014 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Fri, 23 May 2014 17:37:53 +0900 Subject: [9] RFR: 8033627: UTC+02:00 time zones are not detected correctly on Windows Message-ID: <537F08E1.8000107@oracle.com> Hello, Could you please review the fix for JDK-8033627? This is lib/tzmappings update due to the Windows KB2794119 update. JBS: https://bugs.openjdk.java.net/browse/JDK-8033627 Webrev: http://cr.openjdk.java.net/~okutsu/9/8033627/webrev.00/ Thanks, Masayoshi From yuka.kamiya at oracle.com Mon May 26 04:46:56 2014 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Mon, 26 May 2014 13:46:56 +0900 Subject: [9] RFR: 8033627: UTC+02:00 time zones are not detected correctly on Windows In-Reply-To: <537F08E1.8000107@oracle.com> References: <537F08E1.8000107@oracle.com> Message-ID: <5382C740.4020504@oracle.com> Hi, The fix looks good to me. Thanks, -- Yuka (5/23/14, 17:37), Masayoshi Okutsu wrote: > Hello, > > Could you please review the fix for JDK-8033627? This is lib/tzmappings update due to the Windows KB2794119 update. > > JBS: > https://bugs.openjdk.java.net/browse/JDK-8033627 > > Webrev: > http://cr.openjdk.java.net/~okutsu/9/8033627/webrev.00/ > > Thanks, > Masayoshi >