From aleksej.efimov at oracle.com Sat Nov 1 22:19:26 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Sun, 02 Nov 2014 01:19:26 +0300 Subject: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i Message-ID: <54555C6E.80907@oracle.com> Hello, Please, approve a JDK 7u-dev backport of tzdata2014i integration fix. The fix is almost identical to JDK8 with one difference: there is no generic names in JDK7 and changes related to them are not applicable. The JPRT build and all related timezone tests passes, JTREG tests also shows no failure. Thank you, Aleksej JDK7 changes: http://cr.openjdk.java.net/~aefimov/8059206/7/webrev.00 JDK9 chageset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/539a30f006f3 Review thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2014-October/001566.html JBS bug: https://bugs.openjdk.java.net/browse/JDK-8059206 From sean.coffey at oracle.com Mon Nov 3 09:14:23 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 03 Nov 2014 09:14:23 +0000 Subject: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i In-Reply-To: <54555C6E.80907@oracle.com> References: <54555C6E.80907@oracle.com> Message-ID: <5457476F.5050902@oracle.com> Approved pending a peer review of the JDK7u changes. regards, Sean. On 01/11/2014 22:19, Aleksej Efimov wrote: > Hello, > > Please, approve a JDK 7u-dev backport of tzdata2014i integration fix. > The fix is almost identical to JDK8 with one difference: there is no > generic names in JDK7 and changes related to them are not applicable. > The JPRT build and all related timezone tests passes, JTREG tests also > shows no failure. > > Thank you, > Aleksej > > JDK7 changes: http://cr.openjdk.java.net/~aefimov/8059206/7/webrev.00 > JDK9 chageset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/539a30f006f3 > Review thread: > http://mail.openjdk.java.net/pipermail/i18n-dev/2014-October/001566.html > JBS bug: https://bugs.openjdk.java.net/browse/JDK-8059206 From aleksej.efimov at oracle.com Tue Nov 4 20:23:50 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Tue, 04 Nov 2014 23:23:50 +0300 Subject: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i In-Reply-To: <5457476F.5050902@oracle.com> References: <54555C6E.80907@oracle.com> <5457476F.5050902@oracle.com> Message-ID: <545935D6.2010100@oracle.com> Hi, Can I ask for the review of this almost-unaltered JDK7 backport? With Best Regards, Aleksej On 03.11.2014 12:14, Se?n Coffey wrote: > Approved pending a peer review of the JDK7u changes. > > regards, > Sean. > > On 01/11/2014 22:19, Aleksej Efimov wrote: >> Hello, >> >> Please, approve a JDK 7u-dev backport of tzdata2014i integration fix. >> The fix is almost identical to JDK8 with one difference: there is no >> generic names in JDK7 and changes related to them are not applicable. >> The JPRT build and all related timezone tests passes, JTREG tests >> also shows no failure. >> >> Thank you, >> Aleksej >> >> JDK7 changes: http://cr.openjdk.java.net/~aefimov/8059206/7/webrev.00 >> JDK9 chageset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/539a30f006f3 >> Review thread: >> http://mail.openjdk.java.net/pipermail/i18n-dev/2014-October/001566.html >> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8059206 > From yuka.kamiya at oracle.com Wed Nov 5 02:56:05 2014 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Wed, 05 Nov 2014 11:56:05 +0900 Subject: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i In-Reply-To: <545935D6.2010100@oracle.com> References: <54555C6E.80907@oracle.com> <5457476F.5050902@oracle.com> <545935D6.2010100@oracle.com> Message-ID: <545991C5.1000907@oracle.com> Hi, The fix for 7u looks ok to me. Thanks, -- Yuka On 2014/11/05 5:23, Aleksej Efimov wrote: > Hi, > > Can I ask for the review of this almost-unaltered JDK7 backport? > > With Best Regards, > Aleksej > > On 03.11.2014 12:14, Se?n Coffey wrote: >> Approved pending a peer review of the JDK7u changes. >> >> regards, >> Sean. >> >> On 01/11/2014 22:19, Aleksej Efimov wrote: >>> Hello, >>> >>> Please, approve a JDK 7u-dev backport of tzdata2014i integration >>> fix. The fix is almost identical to JDK8 with one difference: there >>> is no generic names in JDK7 and changes related to them are not >>> applicable. >>> The JPRT build and all related timezone tests passes, JTREG tests >>> also shows no failure. >>> >>> Thank you, >>> Aleksej >>> >>> JDK7 changes: http://cr.openjdk.java.net/~aefimov/8059206/7/webrev.00 >>> JDK9 chageset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/539a30f006f3 >>> Review thread: >>> http://mail.openjdk.java.net/pipermail/i18n-dev/2014-October/001566.html >>> >>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8059206 >> > From aleksej.efimov at oracle.com Wed Nov 5 10:13:52 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Wed, 05 Nov 2014 13:13:52 +0300 Subject: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i In-Reply-To: <545991C5.1000907@oracle.com> References: <54555C6E.80907@oracle.com> <5457476F.5050902@oracle.com> <545935D6.2010100@oracle.com> <545991C5.1000907@oracle.com> Message-ID: <5459F860.1050507@oracle.com> Yuka, Thank you for reviewing this fix. Best Regards, Aleksej On 11/05/2014 05:56 AM, Yuka Kamiya wrote: > Hi, > > The fix for 7u looks ok to me. > > Thanks, > -- > Yuka > > On 2014/11/05 5:23, Aleksej Efimov wrote: >> Hi, >> >> Can I ask for the review of this almost-unaltered JDK7 backport? >> >> With Best Regards, >> Aleksej >> >> On 03.11.2014 12:14, Se?n Coffey wrote: >>> Approved pending a peer review of the JDK7u changes. >>> >>> regards, >>> Sean. >>> >>> On 01/11/2014 22:19, Aleksej Efimov wrote: >>>> Hello, >>>> >>>> Please, approve a JDK 7u-dev backport of tzdata2014i integration >>>> fix. The fix is almost identical to JDK8 with one difference: there >>>> is no generic names in JDK7 and changes related to them are not >>>> applicable. >>>> The JPRT build and all related timezone tests passes, JTREG tests >>>> also shows no failure. >>>> >>>> Thank you, >>>> Aleksej >>>> >>>> JDK7 changes: http://cr.openjdk.java.net/~aefimov/8059206/7/webrev.00 >>>> JDK9 chageset: >>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/539a30f006f3 >>>> Review thread: >>>> http://mail.openjdk.java.net/pipermail/i18n-dev/2014-October/001566.html >>>> >>>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8059206 >>> >> > From mark.reinhold at oracle.com Wed Nov 12 23:47:43 2014 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 12 Nov 2014 15:47:43 -0800 (PST) Subject: JEP 226: UTF-8 Property Files Message-ID: <20141112234743.946524207D@eggemoggin.niobe.net> New JEP Candidate: http://openjdk.java.net/jeps/226 - Mark From mark.reinhold at oracle.com Thu Nov 13 00:13:50 2014 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 12 Nov 2014 16:13:50 -0800 (PST) Subject: JEP 227: Unicode 7.0 Message-ID: <20141113001350.D58B54207F@eggemoggin.niobe.net> New JEP Candidate: http://openjdk.java.net/jeps/227 - Mark From steven.loomis at oracle.com Thu Nov 13 04:38:19 2014 From: steven.loomis at oracle.com (Steven R. Loomis) Date: Wed, 12 Nov 2014 20:38:19 -0800 Subject: JEP 227: Unicode 7.0 In-Reply-To: <20141113001350.D58B54207F@eggemoggin.niobe.net> References: <20141113001350.D58B54207F@eggemoggin.niobe.net> Message-ID: <546435BB.5010609@oracle.com> Very good! There's one Unicode release a year, so they are a bit more predictable. -s On 11/12/2014 4:13 PM, mark.reinhold at oracle.com wrote: > New JEP Candidate: http://openjdk.java.net/jeps/227 > > - Mark From martijnverburg at gmail.com Fri Nov 14 14:29:05 2014 From: martijnverburg at gmail.com (Martijn Verburg) Date: Fri, 14 Nov 2014 15:29:05 +0100 Subject: JEP 226: UTF-8 Property Files In-Reply-To: <20141112234743.946524207D@eggemoggin.niobe.net> References: <20141112234743.946524207D@eggemoggin.niobe.net> Message-ID: Totally looking forward to using this - language property files will become so much easier! Cheers, Martijn On 13 November 2014 00:47, wrote: > New JEP Candidate: http://openjdk.java.net/jeps/226 > > - Mark > From aleksej.efimov at oracle.com Mon Nov 17 00:11:01 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Mon, 17 Nov 2014 03:11:01 +0300 Subject: RFR: 8064914: tzdb.dat compilation failure when using tzdata2014j Message-ID: <54693D15.5040204@oracle.com> Hello, During the latest tzdata (2014j) integration the tzdb.dat build failure was observed - details can be found in JBS [1]. The proposed [2] fix resolves time zones double link problem and JDK compilation is succedded. Can I ask a review for this fix, please? Thank you, Aleksej [1] Bug URL: https://bugs.openjdk.java.net/browse/JDK-8064914 [2] Webrev: http://cr.openjdk.java.net/~aefimov/8064914/9/webrev.00 From aleksej.efimov at oracle.com Mon Nov 17 00:13:23 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Mon, 17 Nov 2014 03:13:23 +0300 Subject: RFR: 8064560: (tz) Support tzdata2014j Message-ID: <54693DA3.30908@oracle.com> Hi, Please, review [1] tzdata2014j integration to JDK9 [2]. It is a straight-forward tzdata update, but new data caused a tzdb.dat build failure. It was reported under different bugId [3], there is a possible fix for that and request for review was sent [4]. Testing: JPRT: jdk_other jdk_util jdk_text jdk_time JTREG tests: test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/sun/util/calendar test/java/util/TimeZone test/java/time test/java/util/Formatter test/closed/java/util/Calendar test/closed/java/util/TimeZone test/closed/java/text/Format/DateFormat Thank you, Aleksej [1] Webrev: http://cr.openjdk.java.net/~aefimov/8064560/9/webrev.00/ [2] Bug URL: https://bugs.openjdk.java.net/browse/JDK-8064560 [3] Build failure bug: https://bugs.openjdk.java.net/browse/JDK-8064914 [4] Build failure RFR: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029677.html From masayoshi.okutsu at oracle.com Mon Nov 17 02:45:19 2014 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Mon, 17 Nov 2014 11:45:19 +0900 Subject: RFR: 8064560: (tz) Support tzdata2014j In-Reply-To: <54693DA3.30908@oracle.com> References: <54693DA3.30908@oracle.com> Message-ID: <5469613F.7000903@oracle.com> Looks good to me. Masayoshi On 11/17/2014 9:13 AM, Aleksej Efimov wrote: > Hi, > > Please, review [1] tzdata2014j integration to JDK9 [2]. It is a > straight-forward tzdata update, but new data caused a tzdb.dat build > failure. > It was reported under different bugId [3], there is a possible fix for > that and request for review was sent [4]. > Testing: > JPRT: jdk_other jdk_util jdk_text jdk_time > JTREG tests: test/sun/util/calendar test/java/util/Calendar > test/sun/util/resources/TimeZone test/sun/util/calendar > test/java/util/TimeZone test/java/time test/java/util/Formatter > test/closed/java/util/Calendar test/closed/java/util/TimeZone > test/closed/java/text/Format/DateFormat > > Thank you, > Aleksej > > [1] Webrev: http://cr.openjdk.java.net/~aefimov/8064560/9/webrev.00/ > [2] Bug URL: https://bugs.openjdk.java.net/browse/JDK-8064560 > [3] Build failure bug: https://bugs.openjdk.java.net/browse/JDK-8064914 > [4] Build failure RFR: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029677.html > From sean.coffey at oracle.com Mon Nov 17 09:39:32 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 17 Nov 2014 09:39:32 +0000 Subject: RFR: 8064914: tzdb.dat compilation failure when using tzdata2014j In-Reply-To: <54693D15.5040204@oracle.com> References: <54693D15.5040204@oracle.com> Message-ID: <5469C254.30109@oracle.com> Looks fine. Thanks for handling. regards, Sean. On 17/11/2014 00:11, Aleksej Efimov wrote: > Hello, > > During the latest tzdata (2014j) integration the tzdb.dat build > failure was observed - details can be found in JBS [1]. > The proposed [2] fix resolves time zones double link problem and JDK > compilation is succedded. > Can I ask a review for this fix, please? > > Thank you, > Aleksej > > [1] Bug URL: https://bugs.openjdk.java.net/browse/JDK-8064914 > [2] Webrev: http://cr.openjdk.java.net/~aefimov/8064914/9/webrev.00 From michael.fang at oracle.com Tue Nov 18 03:31:17 2014 From: michael.fang at oracle.com (Michael Fang) Date: Mon, 17 Nov 2014 19:31:17 -0800 Subject: [9] Review request for 8055798: Japanese translation for a warning from javac looks incorrect. Message-ID: <546ABD85.7060304@oracle.com> Hi, Please help to code review the changes for the following CR for jdk9: 8055798: Japanese translation for a warning from javac looks incorrect. https://bugs.openjdk.java.net/browse/JDK-8055798 The webrev is located at: http://cr.openjdk.java.net/~mfang/8055798/webrev.9/ thanks, -michael From yuka.kamiya at oracle.com Tue Nov 18 04:35:01 2014 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Tue, 18 Nov 2014 13:35:01 +0900 Subject: [9] Review request for 8055798: Japanese translation for a warning from javac looks incorrect. In-Reply-To: <546ABD85.7060304@oracle.com> References: <546ABD85.7060304@oracle.com> Message-ID: <546ACC75.1040609@oracle.com> Hi Michael, The fix looks good to me. Thanks, -- Yuka On 2014/11/18 12:31, Michael Fang wrote: > Hi, > > Please help to code review the changes for the following CR for jdk9: > 8055798: Japanese translation for a warning from javac looks incorrect. > https://bugs.openjdk.java.net/browse/JDK-8055798 > > The webrev is located at: > http://cr.openjdk.java.net/~mfang/8055798/webrev.9/ > > thanks, > > -michael From michael.fang at oracle.com Tue Nov 18 04:40:00 2014 From: michael.fang at oracle.com (Michael Fang) Date: Mon, 17 Nov 2014 20:40:00 -0800 Subject: [9] Review request for 8055798: Japanese translation for a warning from javac looks incorrect. In-Reply-To: <546ACC75.1040609@oracle.com> References: <546ABD85.7060304@oracle.com> <546ACC75.1040609@oracle.com> Message-ID: <546ACDA0.1010801@oracle.com> Thanks Yuka. -michael On 14?11?17? 08:35 ??, Yuka Kamiya wrote: > Hi Michael, > > The fix looks good to me. > > Thanks, > -- > Yuka > > > On 2014/11/18 12:31, Michael Fang wrote: >> Hi, >> >> Please help to code review the changes for the following CR for jdk9: >> 8055798: Japanese translation for a warning from javac looks incorrect. >> https://bugs.openjdk.java.net/browse/JDK-8055798 >> >> The webrev is located at: >> http://cr.openjdk.java.net/~mfang/8055798/webrev.9/ >> >> thanks, >> >> -michael > From michael.fang at oracle.com Tue Nov 25 19:20:47 2014 From: michael.fang at oracle.com (Michael Fang) Date: Tue, 25 Nov 2014 11:20:47 -0800 Subject: [8u40] Review request for 8065069: jdk8u40 l10n resource file translation update 2 Message-ID: <5474D68F.8030701@oracle.com> Hi, Please help to code review the changes for the following CR: 8065069: jdk8u40 l10n resource file translation update 2 https://bugs.openjdk.java.net/browse/JDK-8065069 The webrev is located at: http://cr.openjdk.java.net/~mfang/8065069/ thanks, -michael From masayoshi.okutsu at oracle.com Wed Nov 26 05:19:47 2014 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Wed, 26 Nov 2014 14:19:47 +0900 Subject: [8u40] Review request for 8065069: jdk8u40 l10n resource file translation update 2 In-Reply-To: <5474D68F.8030701@oracle.com> References: <5474D68F.8030701@oracle.com> Message-ID: <547562F3.2040106@oracle.com> Hi Michael, What's the reason to make the change? A drawback of the change would be that the Chinese locale names are no longer grouped together when the locale names are sorted in ja locale. The following are the old and new names sorted in ja locale. old: ??? ??? ???(???) ???(???) ??? new: ?????? ??? ??? ??? ?????? Masayoshi On 11/26/2014 4:20 AM, Michael Fang wrote: > Hi, > > Please help to code review the changes for the following CR: > 8065069: jdk8u40 l10n resource file translation update 2 > https://bugs.openjdk.java.net/browse/JDK-8065069 > > The webrev is located at: > http://cr.openjdk.java.net/~mfang/8065069/ > > thanks, > > -michael From michael.fang at oracle.com Wed Nov 26 17:21:49 2014 From: michael.fang at oracle.com (Michael Fang) Date: Wed, 26 Nov 2014 09:21:49 -0800 Subject: [8u40] Review request for 8065069: jdk8u40 l10n resource file translation update 2 In-Reply-To: <547562F3.2040106@oracle.com> References: <5474D68F.8030701@oracle.com> <547562F3.2040106@oracle.com> Message-ID: <54760C2D.6040903@oracle.com> Hi Masayoshi, Thank you for your review comment. This was a regular translation update from translation team for each release. Typically if they change the translation, it's either to improve glossary consistency or improve translation quality/accuracy. I am discussing with translation team whether we should keep existing translation. thanks, -michael On 14?11?25? 09:19 ??, Masayoshi Okutsu wrote: > Hi Michael, > > What's the reason to make the change? A drawback of the change would > be that the Chinese locale names are no longer grouped together when > the locale names are sorted in ja locale. The following are the old > and new names sorted in ja locale. > > old: > ??? > ??? > ???(???) > ???(???) > ??? > > new: > ?????? > ??? > ??? > ??? > ?????? > > Masayoshi > > On 11/26/2014 4:20 AM, Michael Fang wrote: >> Hi, >> >> Please help to code review the changes for the following CR: >> 8065069: jdk8u40 l10n resource file translation update 2 >> https://bugs.openjdk.java.net/browse/JDK-8065069 >> >> The webrev is located at: >> http://cr.openjdk.java.net/~mfang/8065069/ >> >> thanks, >> >> -michael >