From erik.joelsson at oracle.com Wed Apr 8 08:32:24 2015 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 08 Apr 2015 10:32:24 +0200 Subject: native2ascii be removed from JDK? In-Reply-To: <5519C1FC.6010303@oracle.com> References: <5519C1FC.6010303@oracle.com> Message-ID: <5524E798.1080301@oracle.com> Note that the JDK build itself uses native2ascii for the man pages. I have no idea why or if this is actually necessary. Here is the code: define install-ja-manpage $(MKDIR) -p $(@D) $(CAT) $< \ | $(NATIVE2ASCII) -encoding eucJP \ | $(SED) 's/@@VERSION@@/$(THIS_JDK_VERSION)/g' \ | $(NATIVE2ASCII) -reverse -encoding $1 \ > $@ endef /Erik On 2015-03-30 23:37, Mandy Chung wrote: > There are several existing ways to do native to ascii conversion. For > example, IDEs like NetBeans and IntelliJ support the transparent > native-to-ascii conversion. There is also maven native 2 ascii plugin. > > JEP 226 proposes to support UTF Properties file that will address the > original motivation of creating the native2ascii tool. > > While native2ascii used to be a convenient tool for some developers to > use, it may be time to remove it in JDK 9 and developers can use IDEs > and Maven plugin and other build tools. > > Any thought? > > Mandy From masayoshi.okutsu at oracle.com Thu Apr 16 05:37:53 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Thu, 16 Apr 2015 14:37:53 +0900 Subject: [9] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session Message-ID: <552F4AB1.2050000@oracle.com> Hello, Please review the fix for JDK-7044727. This fix supports time zone redirection for Windows terminal sessions. (There are still obsolete code for NT/86. But it's a lot of work to eliminate them.) issue: https://bugs.openjdk.java.net/browse/JDK-7044727 webrev: http://cr.openjdk.java.net/~okutsu/9/7044727/webrev.00/ Thanks, Masayoshi From yuka.kamiya at oracle.com Fri Apr 17 05:10:47 2015 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Fri, 17 Apr 2015 14:10:47 +0900 Subject: [9] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session In-Reply-To: <552F4AB1.2050000@oracle.com> References: <552F4AB1.2050000@oracle.com> Message-ID: <553095D7.4060604@oracle.com> Hi, The fix looks good to me. Thanks, -- Yuka On 2015/04/16 14:37, Masayoshi Okutsu wrote: > Hello, > > Please review the fix for JDK-7044727. This fix supports time zone > redirection for Windows terminal sessions. (There are still obsolete > code for NT/86. But it's a lot of work to eliminate them.) > > issue: https://bugs.openjdk.java.net/browse/JDK-7044727 > webrev: http://cr.openjdk.java.net/~okutsu/9/7044727/webrev.00/ > > Thanks, > Masayoshi > From masayoshi.okutsu at oracle.com Fri Apr 17 08:16:52 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Fri, 17 Apr 2015 17:16:52 +0900 Subject: [8u60] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session Message-ID: <5530C174.3000505@oracle.com> Hello, Please review and approve the 8u version of the fix for JDK-7044727. This fix is different from the jdk9 one to be buildable and runnable on Windows XP. issue: https://bugs.openjdk.java.net/browse/JDK-7044727 8u webrev: http://cr.openjdk.java.net/~okutsu/8u/7044727/webrev.00/ jdk9 review thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2015-April/001665.html jdk9 webrev: http://cr.openjdk.java.net/~okutsu/9/7044727/webrev.00/ jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ff7cdc646abd Thanks, Masayoshi From naoto.sato at oracle.com Fri Apr 17 23:05:55 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Fri, 17 Apr 2015 16:05:55 -0700 Subject: [8u60] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session In-Reply-To: <5530C174.3000505@oracle.com> References: <5530C174.3000505@oracle.com> Message-ID: <553191D3.1050406@oracle.com> My only comment is that it could be confusing to use the same name "getDynamicTimeZoneInfo" for the function name and the proc address variable name (initially I thought if it were a recursive call). Otherwise it looks good to me. Also approving the backport to 8u. Naoto On 4/17/15 1:16 AM, Masayoshi Okutsu wrote: > Hello, > > Please review and approve the 8u version of the fix for JDK-7044727. > This fix is different from the jdk9 one to be buildable and runnable on > Windows XP. > > issue: https://bugs.openjdk.java.net/browse/JDK-7044727 > 8u webrev: http://cr.openjdk.java.net/~okutsu/8u/7044727/webrev.00/ > > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/i18n-dev/2015-April/001665.html > jdk9 webrev: http://cr.openjdk.java.net/~okutsu/9/7044727/webrev.00/ > jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ff7cdc646abd > > Thanks, > Masayoshi > From rob.mckenna at oracle.com Fri Apr 17 23:40:16 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Sat, 18 Apr 2015 00:40:16 +0100 Subject: [8u60] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session In-Reply-To: <553191D3.1050406@oracle.com> References: <5530C174.3000505@oracle.com> <553191D3.1050406@oracle.com> Message-ID: <553199E0.7070505@oracle.com> Approved for push. -Rob On 18/04/15 00:05, Naoto Sato wrote: > My only comment is that it could be confusing to use the same name > "getDynamicTimeZoneInfo" for the function name and the proc address > variable name (initially I thought if it were a recursive call). > Otherwise it looks good to me. > > Also approving the backport to 8u. > > Naoto > > On 4/17/15 1:16 AM, Masayoshi Okutsu wrote: >> Hello, >> >> Please review and approve the 8u version of the fix for JDK-7044727. >> This fix is different from the jdk9 one to be buildable and runnable on >> Windows XP. >> >> issue: https://bugs.openjdk.java.net/browse/JDK-7044727 >> 8u webrev: http://cr.openjdk.java.net/~okutsu/8u/7044727/webrev.00/ >> >> jdk9 review thread: >> http://mail.openjdk.java.net/pipermail/i18n-dev/2015-April/001665.html >> jdk9 webrev: http://cr.openjdk.java.net/~okutsu/9/7044727/webrev.00/ >> jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ff7cdc646abd >> >> Thanks, >> Masayoshi >> From masayoshi.okutsu at oracle.com Mon Apr 20 06:27:46 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Mon, 20 Apr 2015 16:27:46 +1000 Subject: [8u60] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session In-Reply-To: <553191D3.1050406@oracle.com> References: <5530C174.3000505@oracle.com> <553191D3.1050406@oracle.com> Message-ID: <55349C62.2010604@oracle.com> I've changed the variable name to getDynamicTimeZoneInfoFunc to avoid that confusion. http://cr.openjdk.java.net/~okutsu/8u/7044727/webrev.01/ I will push the changed one. Thanks, Masayoshi On 4/18/2015 9:05 AM, Naoto Sato wrote: > My only comment is that it could be confusing to use the same name > "getDynamicTimeZoneInfo" for the function name and the proc address > variable name (initially I thought if it were a recursive call). > Otherwise it looks good to me. > > Also approving the backport to 8u. > > Naoto > > On 4/17/15 1:16 AM, Masayoshi Okutsu wrote: >> Hello, >> >> Please review and approve the 8u version of the fix for JDK-7044727. >> This fix is different from the jdk9 one to be buildable and runnable on >> Windows XP. >> >> issue: https://bugs.openjdk.java.net/browse/JDK-7044727 >> 8u webrev: http://cr.openjdk.java.net/~okutsu/8u/7044727/webrev.00/ >> >> jdk9 review thread: >> http://mail.openjdk.java.net/pipermail/i18n-dev/2015-April/001665.html >> jdk9 webrev: http://cr.openjdk.java.net/~okutsu/9/7044727/webrev.00/ >> jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ff7cdc646abd >> >> Thanks, >> Masayoshi >> From mail at alexkasko.com Mon Apr 20 17:19:17 2015 From: mail at alexkasko.com (Alex Kashchenko) Date: Mon, 20 Apr 2015 18:19:17 +0100 Subject: [PATCH] preserve records order in generated tzdb.dat Message-ID: <55353515.100@alexkasko.com> Hi, I noticed that "not-linked" HashSet and HashMap are used during the compilation of zone info data into tzdb.dat. This causes non-deterministic order of records in tzdb.dat. While order there is not important for java.util.TimeZone I thought that deterministic order will be better. I prepared webrevs for jdk9: - http://cr.openjdk.java.net/~akasko/jdk9/tzdbgen_linked/webrev.00/ - http://cr.openjdk.java.net/~akasko/jdk9/tzdbgen_linked/webrev.00.zip and jdk8u: - http://cr.openjdk.java.net/~akasko/jdk8u/tzdbgen_linked/webrev.00/ - http://cr.openjdk.java.net/~akasko/jdk8u/tzdbgen_linked/webrev.00.zip The actual different order is quite hard to reproduce, I spotted this running TzdbZoneRulesCompiler on different versions of OpenJDK. So there is no test. Please let me know, if JBS bug should be created (have access as an Author but never did it before), if jdk8u change should be posted separately and later etc. Thanks. -- -Alex From naoto.sato at oracle.com Tue Apr 28 21:59:19 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Tue, 28 Apr 2015 14:59:19 -0700 Subject: [9] RFR: 8075545: Add permission check for locale service provider implementations Message-ID: <554002B7.3040507@oracle.com> Hi, Please review the changes for the following bug: https://bugs.openjdk.java.net/browse/JDK-8075545 The fix is to check the RuntimePermission target "localeServiceProvider" on instance creation. The fix is located at: http://cr.openjdk.java.net/~naoto/8075545/ Naoto From mandy.chung at oracle.com Wed Apr 29 05:08:21 2015 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 28 Apr 2015 22:08:21 -0700 Subject: [9] RFR: 8075545: Add permission check for locale service provider implementations In-Reply-To: <554002B7.3040507@oracle.com> References: <554002B7.3040507@oracle.com> Message-ID: <55406745.5060700@oracle.com> On 4/28/2015 2:59 PM, Naoto Sato wrote: > Hi, > > Please review the changes for the following bug: > > https://bugs.openjdk.java.net/browse/JDK-8075545 > > The fix is to check the RuntimePermission target > "localeServiceProvider" on instance creation. The fix is located at: > > http://cr.openjdk.java.net/~naoto/8075545/ Looks good. Mandy From Alan.Bateman at oracle.com Wed Apr 29 07:03:28 2015 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 29 Apr 2015 08:03:28 +0100 Subject: [9] RFR: 8075545: Add permission check for locale service provider implementations In-Reply-To: <554002B7.3040507@oracle.com> References: <554002B7.3040507@oracle.com> Message-ID: <55408240.2090209@oracle.com> On 28/04/2015 22:59, Naoto Sato wrote: > Hi, > > Please review the changes for the following bug: > > https://bugs.openjdk.java.net/browse/JDK-8075545 > > The fix is to check the RuntimePermission target > "localeServiceProvider" on instance creation. The fix is located at: > > http://cr.openjdk.java.net/~naoto/8075545/ This looks okay to me too. -Alan From aleksej.efimov at oracle.com Wed Apr 29 14:37:29 2015 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Wed, 29 Apr 2015 17:37:29 +0300 Subject: RFR: 8077685: (tz) Support tzdata2015d Message-ID: <5540ECA9.5040504@oracle.com> Hi, Please, review the fix for adding the latest tzdata2015d to JDK9. The JTREG and JPRT tests were executed. No failures were observed. Thank you, Aleksej [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8077685 [2] Webrev: http://cr.openjdk.java.net/~aefimov/tzdata/2015d/9/00 From masayoshi.okutsu at oracle.com Thu Apr 30 06:50:06 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Thu, 30 Apr 2015 15:50:06 +0900 Subject: RFR: 8077685: (tz) Support tzdata2015d In-Reply-To: <5540ECA9.5040504@oracle.com> References: <5540ECA9.5040504@oracle.com> Message-ID: <5541D09E.4050904@oracle.com> Looks good to me. Masayoshi On 4/29/2015 11:37 PM, Aleksej Efimov wrote: > Hi, > > Please, review the fix for adding the latest tzdata2015d to JDK9. > The JTREG and JPRT tests were executed. > No failures were observed. > > Thank you, > Aleksej > > [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8077685 > [2] Webrev: http://cr.openjdk.java.net/~aefimov/tzdata/2015d/9/00