From naoto.sato at oracle.com  Mon Aug  3 22:10:09 2015
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 03 Aug 2015 15:10:09 -0700
Subject: <i18n dev> [9] RFR: 8129881, 8130845, 8132125
Message-ID: <55BFE6C1.3000401@oracle.com>

Hello,

Please review the changes for the following issues that are the 
regressions for fixing 8008577:

8129881: 8008577 breaks Nashorn test 
(https://bugs.openjdk.java.net/browse/JDK-8129881)
8130845: Change to CLDR Locale data in JDK 9 b71 causes SimpleDateFormat 
parsing errors (https://bugs.openjdk.java.net/browse/JDK-8130845)
8132125: German (Switzerland) formatting broken if CLDR Locale Data is 
used (https://bugs.openjdk.java.net/browse/JDK-8132125)

The proposed fixes are located at:

http://cr.openjdk.java.net/~naoto/8129881.8130845.8132125/webrev.00/

Since this changeset inculudes build changes, I'd like the build group 
to review those makefile changes.

Naoto

From tim.bell at oracle.com  Mon Aug  3 23:43:47 2015
From: tim.bell at oracle.com (Tim Bell)
Date: Mon, 03 Aug 2015 16:43:47 -0700
Subject: <i18n dev> [9] RFR: 8129881, 8130845, 8132125
In-Reply-To: <55BFE6C1.3000401@oracle.com>
References: <55BFE6C1.3000401@oracle.com>
Message-ID: <55BFFCB3.7020302@oracle.com>

Hello Naoto:

> Please review the changes for the following issues that are the 
> regressions for fixing 8008577:
>
> 8129881: 8008577 breaks Nashorn test 
> (https://bugs.openjdk.java.net/browse/JDK-8129881)
> 8130845: Change to CLDR Locale data in JDK 9 b71 causes 
> SimpleDateFormat parsing errors 
> (https://bugs.openjdk.java.net/browse/JDK-8130845)
> 8132125: German (Switzerland) formatting broken if CLDR Locale Data is 
> used (https://bugs.openjdk.java.net/browse/JDK-8132125)
>
> The proposed fixes are located at:
>
> http://cr.openjdk.java.net/~naoto/8129881.8130845.8132125/webrev.00/
>
> Since this changeset inculudes build changes, I'd like the build group 
> to review those makefile changes.

The build changes look fine.

Tim


From masayoshi.okutsu at oracle.com  Tue Aug  4 02:04:43 2015
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Tue, 4 Aug 2015 11:04:43 +0900
Subject: <i18n dev> [9] RFR: 8129881, 8130845, 8132125
In-Reply-To: <55BFE6C1.3000401@oracle.com>
References: <55BFE6C1.3000401@oracle.com>
Message-ID: <55C01DBB.6080501@oracle.com>

The i18n changes look good to me.

Masayoshi

On 8/4/2015 7:10 AM, Naoto Sato wrote:
> Hello,
>
> Please review the changes for the following issues that are the 
> regressions for fixing 8008577:
>
> 8129881: 8008577 breaks Nashorn test 
> (https://bugs.openjdk.java.net/browse/JDK-8129881)
> 8130845: Change to CLDR Locale data in JDK 9 b71 causes 
> SimpleDateFormat parsing errors 
> (https://bugs.openjdk.java.net/browse/JDK-8130845)
> 8132125: German (Switzerland) formatting broken if CLDR Locale Data is 
> used (https://bugs.openjdk.java.net/browse/JDK-8132125)
>
> The proposed fixes are located at:
>
> http://cr.openjdk.java.net/~naoto/8129881.8130845.8132125/webrev.00/
>
> Since this changeset inculudes build changes, I'd like the build group 
> to review those makefile changes.
>
> Naoto


From naoto.sato at oracle.com  Tue Aug  4 20:31:11 2015
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 04 Aug 2015 13:31:11 -0700
Subject: <i18n dev> [9] RFR: 8132494: Wrong CLDR resource bundle names for
 legacy ISO language codes
Message-ID: <55C1210F.9010005@oracle.com>

Hello,

Please review the changes for the following issue:

https://bugs.openjdk.java.net/browse/JDK-8132494

The proposed fix is located at:

http://cr.openjdk.java.net/~naoto/8132494/webrev.00/

Naoto

From masayoshi.okutsu at oracle.com  Wed Aug  5 08:57:29 2015
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Wed, 5 Aug 2015 17:57:29 +0900
Subject: <i18n dev> [9] RFR: 8132494: Wrong CLDR resource bundle names
 for legacy ISO language codes
In-Reply-To: <55C1210F.9010005@oracle.com>
References: <55C1210F.9010005@oracle.com>
Message-ID: <55C1CFF9.1080009@oracle.com>

Looks good to me.

Masayoshi

On 8/5/2015 5:31 AM, Naoto Sato wrote:
> Hello,
>
> Please review the changes for the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8132494
>
> The proposed fix is located at:
>
> http://cr.openjdk.java.net/~naoto/8132494/webrev.00/
>
> Naoto


From naoto.sato at oracle.com  Thu Aug  6 23:37:29 2015
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 06 Aug 2015 16:37:29 -0700
Subject: <i18n dev> [9] RFR: 8133044: [TESTBUG] CLDRDisplayNameTest uses
 deprecated API, fails
Message-ID: <55C3EFB9.4060300@oracle.com>

Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8133044

The fix is to just remove the offending test cases which don't always 
correct. It is located at:

http://cr.openjdk.java.net/~naoto/8133044/webrev.00/

Naoto

From masayoshi.okutsu at oracle.com  Fri Aug  7 00:00:03 2015
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Fri, 7 Aug 2015 09:00:03 +0900
Subject: <i18n dev> [9] RFR: 8133044: [TESTBUG] CLDRDisplayNameTest uses
 deprecated API, fails
In-Reply-To: <55C3EFB9.4060300@oracle.com>
References: <55C3EFB9.4060300@oracle.com>
Message-ID: <55C3F503.4000009@oracle.com>

Looks good to me.

Masayoshi

On 8/7/2015 8:37 AM, Naoto Sato wrote:
> Hello,
>
> Please review the fix to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8133044
>
> The fix is to just remove the offending test cases which don't always 
> correct. It is located at:
>
> http://cr.openjdk.java.net/~naoto/8133044/webrev.00/
>
> Naoto


From aleksej.efimov at oracle.com  Thu Aug 13 13:54:11 2015
From: aleksej.efimov at oracle.com (Aleksej Efimov)
Date: Thu, 13 Aug 2015 16:54:11 +0300
Subject: <i18n dev> [9] RFR: 8133321: (tz) Support tzdata2015f
Message-ID: <55CCA183.7010203@oracle.com>

Hello,

Please review latest tzdata (2015f)  integration into JDK9:
http://cr.openjdk.java.net/~aefimov/tzdata/2015f/9/00

Testing shows no TZ related failures on all platforms.

Thanks,
Aleksej

JBS: https://bugs.openjdk.java.net/browse/JDK-8133321


From masayoshi.okutsu at oracle.com  Thu Aug 13 22:46:33 2015
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Fri, 14 Aug 2015 07:46:33 +0900
Subject: <i18n dev> [9] RFR: 8133321: (tz) Support tzdata2015f
In-Reply-To: <55CCA183.7010203@oracle.com>
References: <55CCA183.7010203@oracle.com>
Message-ID: <55CD1E49.5000701@oracle.com>

Looks good to me.

Masayoshi

On 8/13/2015 10:54 PM, Aleksej Efimov wrote:
> Hello,
>
> Please review latest tzdata (2015f)  integration into JDK9:
> http://cr.openjdk.java.net/~aefimov/tzdata/2015f/9/00
>
> Testing shows no TZ related failures on all platforms.
>
> Thanks,
> Aleksej
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8133321
>


From christoph.langer at sap.com  Mon Aug 24 09:24:14 2015
From: christoph.langer at sap.com (Langer, Christoph)
Date: Mon, 24 Aug 2015 09:24:14 +0000
Subject: <i18n dev> FW: RFR(XS): 8133830: [solaris] Fix for potential memory
 leak in TimeZone_md.c, function findJavaTZ_md()
Message-ID: <0DFD2E72402C9243A8630A7759B27E4338EF34AD@DEWDFEMB12B.global.corp.sap>

Hi,

I'm also posting this RFR here.

Is this the right place for my change? Is anyone willing to sponsor this?

Thanks a lot in advance
Christoph

From: Langer, Christoph
Sent: Donnerstag, 20. August 2015 12:22
To: 'core-libs-dev at openjdk.java.net' <core-libs-dev at openjdk.java.net>
Subject: RFR(XS): 8133830: [solaris] Fix for potential memory leak in TimeZone_md.c, function findJavaTZ_md()

Hi all,

as per the discussion in thread "Fix for small leak in TimeZone_md.c" in jdk9-dev, I would like to get the following tiny change reviewed:

Bug: https://bugs.openjdk.java.net/browse/JDK-8133830
Webrev: http://cr.openjdk.java.net/~asiebenborn/christoph/webrev/

I also need a sponsor since I can't commit yet.

Thanks
Christoph


From aleksej.efimov at oracle.com  Mon Aug 24 16:27:22 2015
From: aleksej.efimov at oracle.com (Aleksej Efimov)
Date: Mon, 24 Aug 2015 19:27:22 +0300
Subject: <i18n dev> FW: RFR(XS): 8133830: [solaris] Fix for potential
 memory leak in TimeZone_md.c, function findJavaTZ_md()
In-Reply-To: <0DFD2E72402C9243A8630A7759B27E4338EF34AD@DEWDFEMB12B.global.corp.sap>
References: <0DFD2E72402C9243A8630A7759B27E4338EF34AD@DEWDFEMB12B.global.corp.sap>
Message-ID: <55DB45EA.6070303@oracle.com>

Hi Christoph,
I can sponsor your change. Fix looks good to me (but I'm not a reviewer).

With Best Regards,
Aleksej

On 08/24/2015 12:24 PM, Langer, Christoph wrote:
> Hi,
>
> I'm also posting this RFR here.
>
> Is this the right place for my change? Is anyone willing to sponsor this?
>
> Thanks a lot in advance
> Christoph
>
> From: Langer, Christoph
> Sent: Donnerstag, 20. August 2015 12:22
> To: 'core-libs-dev at openjdk.java.net' <core-libs-dev at openjdk.java.net>
> Subject: RFR(XS): 8133830: [solaris] Fix for potential memory leak in TimeZone_md.c, function findJavaTZ_md()
>
> Hi all,
>
> as per the discussion in thread "Fix for small leak in TimeZone_md.c" in jdk9-dev, I would like to get the following tiny change reviewed:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8133830
> Webrev: http://cr.openjdk.java.net/~asiebenborn/christoph/webrev/
>
> I also need a sponsor since I can't commit yet.
>
> Thanks
> Christoph
>


From naoto.sato at oracle.com  Mon Aug 24 22:18:20 2015
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 24 Aug 2015 15:18:20 -0700
Subject: <i18n dev> [9] RFR: 8134250: Create unit tests for CLDR unique
	features
Message-ID: <55DB982C.6090101@oracle.com>

Hello,

Please review the changes for the following issue:

https://bugs.openjdk.java.net/browse/JDK-8134250

It is just adding more unit testcases for the JEP 252. The proposed 
changeset is located at:

http://cr.openjdk.java.net/~naoto/8134250/webrev.00/

Naoto

From masayoshi.okutsu at oracle.com  Mon Aug 24 23:31:30 2015
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Tue, 25 Aug 2015 08:31:30 +0900
Subject: <i18n dev> [9] RFR: 8134250: Create unit tests for CLDR unique
 features
In-Reply-To: <55DB982C.6090101@oracle.com>
References: <55DB982C.6090101@oracle.com>
Message-ID: <55DBA952.2020804@oracle.com>

Looks good to me. Thanks for adding this unit test.

Masayoshi

On 8/25/2015 7:18 AM, Naoto Sato wrote:
> Hello,
>
> Please review the changes for the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8134250
>
> It is just adding more unit testcases for the JEP 252. The proposed 
> changeset is located at:
>
> http://cr.openjdk.java.net/~naoto/8134250/webrev.00/
>
> Naoto


From naoto.sato at oracle.com  Tue Aug 25 01:57:16 2015
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 24 Aug 2015 18:57:16 -0700
Subject: <i18n dev> [9] RFR: 8134250: Create unit tests for CLDR unique
 features
In-Reply-To: <55DBA952.2020804@oracle.com>
References: <55DB982C.6090101@oracle.com> <55DBA952.2020804@oracle.com>
Message-ID: <55DBCB7C.30506@oracle.com>

Thanks. I found that the error message in the second RuntimeException 
was somewhat incorrect, so will correct it before pushing the changeset.

Naoto

On 8/24/15 4:31 PM, Masayoshi Okutsu wrote:
> Looks good to me. Thanks for adding this unit test.
>
> Masayoshi
>
> On 8/25/2015 7:18 AM, Naoto Sato wrote:
>> Hello,
>>
>> Please review the changes for the following issue:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8134250
>>
>> It is just adding more unit testcases for the JEP 252. The proposed
>> changeset is located at:
>>
>> http://cr.openjdk.java.net/~naoto/8134250/webrev.00/
>>
>> Naoto
>

From masayoshi.okutsu at oracle.com  Tue Aug 25 02:58:25 2015
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Tue, 25 Aug 2015 11:58:25 +0900
Subject: <i18n dev> FW: RFR(XS): 8133830: [solaris] Fix for potential
 memory leak in TimeZone_md.c, function findJavaTZ_md()
In-Reply-To: <55DB45EA.6070303@oracle.com>
References: <0DFD2E72402C9243A8630A7759B27E4338EF34AD@DEWDFEMB12B.global.corp.sap>
	<55DB45EA.6070303@oracle.com>
Message-ID: <55DBD9D1.4010502@oracle.com>

Looks good to me too. Thank you for fixing this bug.

Aleksej, it's great if you can sponsor this fix.

Thanks,
Masayoshi

On 8/25/2015 1:27 AM, Aleksej Efimov wrote:
> Hi Christoph,
> I can sponsor your change. Fix looks good to me (but I'm not a reviewer).
>
> With Best Regards,
> Aleksej
>
> On 08/24/2015 12:24 PM, Langer, Christoph wrote:
>> Hi,
>>
>> I'm also posting this RFR here.
>>
>> Is this the right place for my change? Is anyone willing to sponsor 
>> this?
>>
>> Thanks a lot in advance
>> Christoph
>>
>> From: Langer, Christoph
>> Sent: Donnerstag, 20. August 2015 12:22
>> To: 'core-libs-dev at openjdk.java.net' <core-libs-dev at openjdk.java.net>
>> Subject: RFR(XS): 8133830: [solaris] Fix for potential memory leak in 
>> TimeZone_md.c, function findJavaTZ_md()
>>
>> Hi all,
>>
>> as per the discussion in thread "Fix for small leak in TimeZone_md.c" 
>> in jdk9-dev, I would like to get the following tiny change reviewed:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8133830
>> Webrev: http://cr.openjdk.java.net/~asiebenborn/christoph/webrev/
>>
>> I also need a sponsor since I can't commit yet.
>>
>> Thanks
>> Christoph
>>
>


From christoph.langer at sap.com  Tue Aug 25 14:04:28 2015
From: christoph.langer at sap.com (Langer, Christoph)
Date: Tue, 25 Aug 2015 14:04:28 +0000
Subject: <i18n dev> FW: RFR(XS): 8133830: [solaris] Fix for potential
 memory leak in TimeZone_md.c, function findJavaTZ_md()
In-Reply-To: <55DBD9D1.4010502@oracle.com>
References: <0DFD2E72402C9243A8630A7759B27E4338EF34AD@DEWDFEMB12B.global.corp.sap>
	<55DB45EA.6070303@oracle.com> <55DBD9D1.4010502@oracle.com>
Message-ID: <0DFD2E72402C9243A8630A7759B27E4338EF42F7@DEWDFEMB12B.global.corp.sap>

Hi Aleksej,

I guess you can push the change now as this fix was reviewed by andrew (Hughes) and goetz (Lindenmaier) in mailing list jdk9-dev, already. So there are enough reviewers :-)

Thanks a lot
Christoph


-----Original Message-----
From: Masayoshi Okutsu [mailto:masayoshi.okutsu at oracle.com] 
Sent: Dienstag, 25. August 2015 04:58
To: Aleksej Efimov <aleksej.efimov at oracle.com>; Langer, Christoph <christoph.langer at sap.com>; i18n-dev at openjdk.java.net
Subject: Re: <i18n dev> FW: RFR(XS): 8133830: [solaris] Fix for potential memory leak in TimeZone_md.c, function findJavaTZ_md()

Looks good to me too. Thank you for fixing this bug.

Aleksej, it's great if you can sponsor this fix.

Thanks,
Masayoshi

On 8/25/2015 1:27 AM, Aleksej Efimov wrote:
> Hi Christoph,
> I can sponsor your change. Fix looks good to me (but I'm not a reviewer).
>
> With Best Regards,
> Aleksej
>
> On 08/24/2015 12:24 PM, Langer, Christoph wrote:
>> Hi,
>>
>> I'm also posting this RFR here.
>>
>> Is this the right place for my change? Is anyone willing to sponsor 
>> this?
>>
>> Thanks a lot in advance
>> Christoph
>>
>> From: Langer, Christoph
>> Sent: Donnerstag, 20. August 2015 12:22
>> To: 'core-libs-dev at openjdk.java.net' <core-libs-dev at openjdk.java.net>
>> Subject: RFR(XS): 8133830: [solaris] Fix for potential memory leak in 
>> TimeZone_md.c, function findJavaTZ_md()
>>
>> Hi all,
>>
>> as per the discussion in thread "Fix for small leak in TimeZone_md.c" 
>> in jdk9-dev, I would like to get the following tiny change reviewed:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8133830
>> Webrev: http://cr.openjdk.java.net/~asiebenborn/christoph/webrev/
>>
>> I also need a sponsor since I can't commit yet.
>>
>> Thanks
>> Christoph
>>
>


From christoph.langer at sap.com  Wed Aug 26 14:34:02 2015
From: christoph.langer at sap.com (Langer, Christoph)
Date: Wed, 26 Aug 2015 14:34:02 +0000
Subject: <i18n dev> RFR: 8134505: Cleanup of "TimeZone_md.c"
Message-ID: <0DFD2E72402C9243A8630A7759B27E4338EF53BE@DEWDFEMB12B.global.corp.sap>

Hi,

when working on TimeZone_md.c lately, I found it worthwhile to do some cleanup on it. Please review my changes.
Bug: https://bugs.openjdk.java.net/browse/JDK-8134505
Webrev: http://cr.openjdk.java.net/~goetz/webrevs/8134505-timeZone/webrev.01/

I basically did the following things:
- clean up some typos and comment errors
- added #include "TimeZone_md.h"
- split up the platform specific define sections into an #ifdef <platform1> #elif <platform2> #elif ... #endif construct
- moved some AIX coding from the #ifdef block at the bottom of the file into the first AIX specific block
- AIX function "mapPlatformToJavaTimezone": use a dynamic malloced buffer instead of a fixed length buffer
- refactor function "findJavaTZ_md" to make it more straightforward and to avoid unnecessary mallocs and don't forget necessary frees

I'm also wondering if the "if (tz == NULL || *tz == '\0') {" of line 770 could be used for all platforms instead of Solaris and AIX only. The other platforms will only do a check if TZ is NULL but not if it is an empty string.

Thanks and best regards
Christoph


From naoto.sato at oracle.com  Wed Aug 26 16:52:20 2015
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 26 Aug 2015 09:52:20 -0700
Subject: <i18n dev> [9] RFR: 8134520: Bug8134250 test fails in en_IE locale
Message-ID: <55DDEEC4.9060400@oracle.com>

Hello,

Please review a simple fix for the following issue:

https://bugs.openjdk.java.net/browse/JDK-8134520

The proposed change is located at:

http://cr.openjdk.java.net/~naoto/8134520/webrev.00/

The fix is to simply set the en_US locale to the formatter.

Naoto

From lance.andersen at oracle.com  Wed Aug 26 17:24:45 2015
From: lance.andersen at oracle.com (Lance Andersen)
Date: Wed, 26 Aug 2015 13:24:45 -0400
Subject: <i18n dev> [9] RFR: 8134520: Bug8134250 test fails in en_IE
	locale
In-Reply-To: <55DDEEC4.9060400@oracle.com>
References: <55DDEEC4.9060400@oracle.com>
Message-ID: <BF7A6B41-B40E-453E-8C14-E2DA4B457D4F@oracle.com>

Looks OK Naoto

Best
Lnace
On Aug 26, 2015, at 12:52 PM, Naoto Sato <naoto.sato at oracle.com> wrote:

> Hello,
> 
> Please review a simple fix for the following issue:
> 
> https://bugs.openjdk.java.net/browse/JDK-8134520
> 
> The proposed change is located at:
> 
> http://cr.openjdk.java.net/~naoto/8134520/webrev.00/
> 
> The fix is to simply set the en_US locale to the formatter.
> 
> Naoto



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com