From yuka.kamiya at oracle.com Mon Jul 13 08:20:13 2015 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Mon, 13 Jul 2015 17:20:13 +0900 Subject: RFR: 8032446: Support Unicode 7.0.0 in JDK 9 Message-ID: <55A374BD.6090807@oracle.com> Hello, Please review the fix for 8032446 to support Unicode 7 in JDK 9. https://bugs.openjdk.java.net/browse/JDK-8032446 http://cr.openjdk.java.net/~peytoia/8032446/webrev.00/ - Internal review for both open & closed parts has been completed. - Changes in sun.text.* packages are mostly porting from ICU4J. (Thank you very much, ICU4J project.) - Because Unicode 8 was released last month, this fix will be overwritten (partially) in near future. Thanks, -- Yuka From naoto.sato at oracle.com Tue Jul 14 23:16:16 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Tue, 14 Jul 2015 16:16:16 -0700 Subject: RFR: 8032446: Support Unicode 7.0.0 in JDK 9 In-Reply-To: <55A374BD.6090807@oracle.com> References: <55A374BD.6090807@oracle.com> Message-ID: <55A59840.2050301@oracle.com> Looks good to me. Naoto On 7/13/15 1:20 AM, Yuka Kamiya wrote: > Hello, > > Please review the fix for 8032446 to support Unicode 7 in JDK 9. > > https://bugs.openjdk.java.net/browse/JDK-8032446 > http://cr.openjdk.java.net/~peytoia/8032446/webrev.00/ > > - Internal review for both open & closed parts has been completed. > - Changes in sun.text.* packages are mostly porting from ICU4J. (Thank > you very much, ICU4J project.) > - Because Unicode 8 was released last month, this fix will be > overwritten (partially) in near future. > > Thanks, > -- > Yuka > From masayoshi.okutsu at oracle.com Wed Jul 15 03:09:57 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Wed, 15 Jul 2015 12:09:57 +0900 Subject: RFR: 8032446: Support Unicode 7.0.0 in JDK 9 In-Reply-To: <55A59840.2050301@oracle.com> References: <55A374BD.6090807@oracle.com> <55A59840.2050301@oracle.com> Message-ID: <55A5CF05.1030909@oracle.com> Looks OK to me too. Masayoshi On 7/15/2015 8:16 AM, Naoto Sato wrote: > Looks good to me. > > Naoto > > On 7/13/15 1:20 AM, Yuka Kamiya wrote: >> Hello, >> >> Please review the fix for 8032446 to support Unicode 7 in JDK 9. >> >> https://bugs.openjdk.java.net/browse/JDK-8032446 >> http://cr.openjdk.java.net/~peytoia/8032446/webrev.00/ >> >> - Internal review for both open & closed parts has been completed. >> - Changes in sun.text.* packages are mostly porting from ICU4J. (Thank >> you very much, ICU4J project.) >> - Because Unicode 8 was released last month, this fix will be >> overwritten (partially) in near future. >> >> Thanks, >> -- >> Yuka >> From yong.huang at oracle.com Wed Jul 22 06:27:37 2015 From: yong.huang at oracle.com (Yong Huang) Date: Wed, 22 Jul 2015 14:27:37 +0800 Subject: [9] Review Request - JDK-8129361: ISO 4217 amendment 160 Message-ID: <55AF37D9.9010806@oracle.com> Hello, This is the review request for https://bugs.openjdk.java.net/browse/JDK-8029361 webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ In Amendment 160, two currency names are changed, but in JDK 9, the name of RON is already Romanian Leu. So, only name of HRK is changed to Kuna in 8129361. thanks, Yong From yong.huang at oracle.com Wed Jul 22 06:30:48 2015 From: yong.huang at oracle.com (Yong Huang) Date: Wed, 22 Jul 2015 14:30:48 +0800 Subject: [9] Review Request - JDK-8129361: ISO 4217 amendment 160 In-Reply-To: <55AF37D9.9010806@oracle.com> References: <55AF37D9.9010806@oracle.com> Message-ID: <55AF3898.6000209@oracle.com> Sorry that, there is typo in bug link. It's https://bugs.openjdk.java.net/browse/JDK-8129361 webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ thanks, Yong On 2015/7/22 14:27, Yong Huang wrote: > Hello, > > This is the review request for > https://bugs.openjdk.java.net/browse/JDK-8029361 > > webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ > > In Amendment 160, two currency names are changed, but in JDK 9, the > name of RON is already Romanian Leu. So, only name of HRK is changed > to Kuna in 8129361. > > thanks, > Yong From naoto.sato at oracle.com Wed Jul 22 23:08:11 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 22 Jul 2015 16:08:11 -0700 Subject: [9] Review Request - JDK-8129361: ISO 4217 amendment 160 In-Reply-To: <55AF3898.6000209@oracle.com> References: <55AF37D9.9010806@oracle.com> <55AF3898.6000209@oracle.com> Message-ID: <55B0225B.1010503@oracle.com> Hi Yong, I think we should update the amendment number from 159 to 160, as well as the entity name changes in - jdk/make/data/currency/CurrencyData.properties - jdk/test/java/util/Currency/tablea1.txt Naoto On 7/21/15 11:30 PM, Yong Huang wrote: > Sorry that, there is typo in bug link. > > It's https://bugs.openjdk.java.net/browse/JDK-8129361 > > webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ > > thanks, > Yong > > On 2015/7/22 14:27, Yong Huang wrote: >> Hello, >> >> This is the review request for >> https://bugs.openjdk.java.net/browse/JDK-8029361 >> >> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >> >> In Amendment 160, two currency names are changed, but in JDK 9, the >> name of RON is already Romanian Leu. So, only name of HRK is changed >> to Kuna in 8129361. >> >> thanks, >> Yong > From naoto.sato at oracle.com Fri Jul 24 21:32:13 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Fri, 24 Jul 2015 14:32:13 -0700 Subject: [9] RFR: JDK-8027607, (rb) Provide UTF-8 based properties resource bundles (JEP-226) Message-ID: <55B2AEDD.6060802@oracle.com> Hello, Please review the changes for the following issue, which is the implementation part of the JEP-226 (https://bugs.openjdk.java.net/browse/JDK-8043553) https://bugs.openjdk.java.net/browse/JDK-8027607 The webrev is located at: http://cr.openjdk.java.net/~naoto/8027607/webrev.00/ Naoto From yong.huang at oracle.com Mon Jul 27 03:07:47 2015 From: yong.huang at oracle.com (Yong Huang) Date: Mon, 27 Jul 2015 11:07:47 +0800 Subject: [9] Review Request - JDK-8129361: ISO 4217 amendment 160 In-Reply-To: <55B0225B.1010503@oracle.com> References: <55AF37D9.9010806@oracle.com> <55AF3898.6000209@oracle.com> <55B0225B.1010503@oracle.com> Message-ID: <55B5A083.9030807@oracle.com> Hi Naoto and All, The modified webrev is at http://cr.openjdk.java.net/~yhuang/8129361/webrev.01/ Amendment number information is changed in - jdk/make/data/currency/CurrencyData.properties - jdk/test/java/util/Currency/tablea1.txt Text "# Generated automatically from the Common Locale Data Repository. DO NOT EDIT!" is removed in src/java.base/share/classes/sun/util/resources/CurrencyNames.properties. The data are maintained manually now. thanks, Yong On 2015/7/23 7:08, Naoto Sato wrote: > Hi Yong, > > I think we should update the amendment number from 159 to 160, as well > as the entity name changes in > > - jdk/make/data/currency/CurrencyData.properties > - jdk/test/java/util/Currency/tablea1.txt > > Naoto > > On 7/21/15 11:30 PM, Yong Huang wrote: >> Sorry that, there is typo in bug link. >> >> It's https://bugs.openjdk.java.net/browse/JDK-8129361 >> >> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >> >> thanks, >> Yong >> >> On 2015/7/22 14:27, Yong Huang wrote: >>> Hello, >>> >>> This is the review request for >>> https://bugs.openjdk.java.net/browse/JDK-8029361 >>> >>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >>> >>> In Amendment 160, two currency names are changed, but in JDK 9, the >>> name of RON is already Romanian Leu. So, only name of HRK is changed >>> to Kuna in 8129361. >>> >>> thanks, >>> Yong >> From naoto.sato at oracle.com Mon Jul 27 16:19:46 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Mon, 27 Jul 2015 09:19:46 -0700 Subject: [9] Review Request - JDK-8129361: ISO 4217 amendment 160 In-Reply-To: <55B5A083.9030807@oracle.com> References: <55AF37D9.9010806@oracle.com> <55AF3898.6000209@oracle.com> <55B0225B.1010503@oracle.com> <55B5A083.9030807@oracle.com> Message-ID: <55B65A22.6050606@oracle.com> Hmm, looks like you haven't updated the "DATAVERSION" in tablea1.txt, I am just wondering whether the test actually succeeds with your modification? Have you run tests? Another comment is that it's still lacking the updates in the amendment 160 which I pointed out before - entity name changes. It will not affect the behavior, but I would align the entity names in CurrencyData.properties, i.e., "BAHAMAS" to "BAHAMAS (THE)" Naoto On 7/26/15 8:07 PM, Yong Huang wrote: > Hi Naoto and All, > > The modified webrev is at > http://cr.openjdk.java.net/~yhuang/8129361/webrev.01/ > > Amendment number information is changed in > > - jdk/make/data/currency/CurrencyData.properties > - jdk/test/java/util/Currency/tablea1.txt > > Text "# Generated automatically from the Common Locale Data Repository. > DO NOT EDIT!" is removed in > src/java.base/share/classes/sun/util/resources/CurrencyNames.properties. > The data are maintained manually now. > > thanks, > Yong > > On 2015/7/23 7:08, Naoto Sato wrote: >> Hi Yong, >> >> I think we should update the amendment number from 159 to 160, as well >> as the entity name changes in >> >> - jdk/make/data/currency/CurrencyData.properties >> - jdk/test/java/util/Currency/tablea1.txt >> >> Naoto >> >> On 7/21/15 11:30 PM, Yong Huang wrote: >>> Sorry that, there is typo in bug link. >>> >>> It's https://bugs.openjdk.java.net/browse/JDK-8129361 >>> >>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >>> >>> thanks, >>> Yong >>> >>> On 2015/7/22 14:27, Yong Huang wrote: >>>> Hello, >>>> >>>> This is the review request for >>>> https://bugs.openjdk.java.net/browse/JDK-8029361 >>>> >>>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >>>> >>>> In Amendment 160, two currency names are changed, but in JDK 9, the >>>> name of RON is already Romanian Leu. So, only name of HRK is changed >>>> to Kuna in 8129361. >>>> >>>> thanks, >>>> Yong >>> > From yong.huang at oracle.com Tue Jul 28 06:54:48 2015 From: yong.huang at oracle.com (Yong Huang) Date: Tue, 28 Jul 2015 14:54:48 +0800 Subject: [9] Review Request - JDK-8129361: ISO 4217 amendment 160 In-Reply-To: <55B65A22.6050606@oracle.com> References: <55AF37D9.9010806@oracle.com> <55AF3898.6000209@oracle.com> <55B0225B.1010503@oracle.com> <55B5A083.9030807@oracle.com> <55B65A22.6050606@oracle.com> Message-ID: <55B72738.8070602@oracle.com> Hi Naoto, Sorry that I did not check the test in jdk_util this time. I will modify the data version in tablea1.txt and the entity names in CurrencyData.properties. I will check text and util test results before sending the new webrev. thanks, Yong On 2015/7/28 0:19, Naoto Sato wrote: > Hmm, looks like you haven't updated the "DATAVERSION" in tablea1.txt, > I am just wondering whether the test actually succeeds with your > modification? Have you run tests? > > Another comment is that it's still lacking the updates in the > amendment 160 which I pointed out before - entity name changes. It > will not affect the behavior, but I would align the entity names in > CurrencyData.properties, i.e., "BAHAMAS" to "BAHAMAS (THE)" > > Naoto > > On 7/26/15 8:07 PM, Yong Huang wrote: >> Hi Naoto and All, >> >> The modified webrev is at >> http://cr.openjdk.java.net/~yhuang/8129361/webrev.01/ >> >> Amendment number information is changed in >> >> - jdk/make/data/currency/CurrencyData.properties >> - jdk/test/java/util/Currency/tablea1.txt >> >> Text "# Generated automatically from the Common Locale Data Repository. >> DO NOT EDIT!" is removed in >> src/java.base/share/classes/sun/util/resources/CurrencyNames.properties. >> The data are maintained manually now. >> >> thanks, >> Yong >> >> On 2015/7/23 7:08, Naoto Sato wrote: >>> Hi Yong, >>> >>> I think we should update the amendment number from 159 to 160, as well >>> as the entity name changes in >>> >>> - jdk/make/data/currency/CurrencyData.properties >>> - jdk/test/java/util/Currency/tablea1.txt >>> >>> Naoto >>> >>> On 7/21/15 11:30 PM, Yong Huang wrote: >>>> Sorry that, there is typo in bug link. >>>> >>>> It's https://bugs.openjdk.java.net/browse/JDK-8129361 >>>> >>>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >>>> >>>> thanks, >>>> Yong >>>> >>>> On 2015/7/22 14:27, Yong Huang wrote: >>>>> Hello, >>>>> >>>>> This is the review request for >>>>> https://bugs.openjdk.java.net/browse/JDK-8029361 >>>>> >>>>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >>>>> >>>>> In Amendment 160, two currency names are changed, but in JDK 9, the >>>>> name of RON is already Romanian Leu. So, only name of HRK is changed >>>>> to Kuna in 8129361. >>>>> >>>>> thanks, >>>>> Yong >>>> >> From yong.huang at oracle.com Wed Jul 29 02:06:45 2015 From: yong.huang at oracle.com (Yong Huang) Date: Wed, 29 Jul 2015 10:06:45 +0800 Subject: [9] Review Request - JDK-8129361: ISO 4217 amendment 160 In-Reply-To: <55B72738.8070602@oracle.com> References: <55AF37D9.9010806@oracle.com> <55AF3898.6000209@oracle.com> <55B0225B.1010503@oracle.com> <55B5A083.9030807@oracle.com> <55B65A22.6050606@oracle.com> <55B72738.8070602@oracle.com> Message-ID: <55B83535.7050608@oracle.com> Hi Naoto and All, The modified webrev is at http://cr.openjdk.java.net/~yhuang/8129361/webrev.02/ It passed test of jdk_text and jdk_util this time. DATAVERSION in tablea1.txt is modified and the entity names in CurrencyData.properties are updated according to amendment 160. thanks, Yong On 2015/7/28 14:54, Yong Huang wrote: > Hi Naoto, > > Sorry that I did not check the test in jdk_util this time. I will > modify the data version in tablea1.txt and the entity names in > CurrencyData.properties. > > I will check text and util test results before sending the new webrev. > > thanks, > Yong > > On 2015/7/28 0:19, Naoto Sato wrote: >> Hmm, looks like you haven't updated the "DATAVERSION" in tablea1.txt, >> I am just wondering whether the test actually succeeds with your >> modification? Have you run tests? >> >> Another comment is that it's still lacking the updates in the >> amendment 160 which I pointed out before - entity name changes. It >> will not affect the behavior, but I would align the entity names in >> CurrencyData.properties, i.e., "BAHAMAS" to "BAHAMAS (THE)" >> >> Naoto >> >> On 7/26/15 8:07 PM, Yong Huang wrote: >>> Hi Naoto and All, >>> >>> The modified webrev is at >>> http://cr.openjdk.java.net/~yhuang/8129361/webrev.01/ >>> >>> Amendment number information is changed in >>> >>> - jdk/make/data/currency/CurrencyData.properties >>> - jdk/test/java/util/Currency/tablea1.txt >>> >>> Text "# Generated automatically from the Common Locale Data Repository. >>> DO NOT EDIT!" is removed in >>> src/java.base/share/classes/sun/util/resources/CurrencyNames.properties. >>> >>> The data are maintained manually now. >>> >>> thanks, >>> Yong >>> >>> On 2015/7/23 7:08, Naoto Sato wrote: >>>> Hi Yong, >>>> >>>> I think we should update the amendment number from 159 to 160, as well >>>> as the entity name changes in >>>> >>>> - jdk/make/data/currency/CurrencyData.properties >>>> - jdk/test/java/util/Currency/tablea1.txt >>>> >>>> Naoto >>>> >>>> On 7/21/15 11:30 PM, Yong Huang wrote: >>>>> Sorry that, there is typo in bug link. >>>>> >>>>> It's https://bugs.openjdk.java.net/browse/JDK-8129361 >>>>> >>>>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >>>>> >>>>> thanks, >>>>> Yong >>>>> >>>>> On 2015/7/22 14:27, Yong Huang wrote: >>>>>> Hello, >>>>>> >>>>>> This is the review request for >>>>>> https://bugs.openjdk.java.net/browse/JDK-8029361 >>>>>> >>>>>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >>>>>> >>>>>> In Amendment 160, two currency names are changed, but in JDK 9, the >>>>>> name of RON is already Romanian Leu. So, only name of HRK is changed >>>>>> to Kuna in 8129361. >>>>>> >>>>>> thanks, >>>>>> Yong >>>>> >>> > From masayoshi.okutsu at oracle.com Wed Jul 29 06:33:41 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Wed, 29 Jul 2015 15:33:41 +0900 Subject: [9] RFR: JDK-8027607, (rb) Provide UTF-8 based properties resource bundles (JEP-226) In-Reply-To: <55B2AEDD.6060802@oracle.com> References: <55B2AEDD.6060802@oracle.com> Message-ID: <55B873C5.8070806@oracle.com> Looks good to me. Masayoshi On 7/25/2015 6:32 AM, Naoto Sato wrote: > Hello, > > Please review the changes for the following issue, which is the > implementation part of the JEP-226 > (https://bugs.openjdk.java.net/browse/JDK-8043553) > > https://bugs.openjdk.java.net/browse/JDK-8027607 > > The webrev is located at: > > http://cr.openjdk.java.net/~naoto/8027607/webrev.00/ > > Naoto From naoto.sato at oracle.com Wed Jul 29 21:28:20 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 29 Jul 2015 14:28:20 -0700 Subject: [9] Review Request - JDK-8129361: ISO 4217 amendment 160 In-Reply-To: <55B83535.7050608@oracle.com> References: <55AF37D9.9010806@oracle.com> <55AF3898.6000209@oracle.com> <55B0225B.1010503@oracle.com> <55B5A083.9030807@oracle.com> <55B65A22.6050606@oracle.com> <55B72738.8070602@oracle.com> <55B83535.7050608@oracle.com> Message-ID: <55B94574.7060409@oracle.com> +1 Naoto On 7/28/15 7:06 PM, Yong Huang wrote: > Hi Naoto and All, > > The modified webrev is at > http://cr.openjdk.java.net/~yhuang/8129361/webrev.02/ > > It passed test of jdk_text and jdk_util this time. DATAVERSION in > tablea1.txt is modified and the entity names in CurrencyData.properties > are updated according to amendment 160. > > thanks, > Yong > > On 2015/7/28 14:54, Yong Huang wrote: >> Hi Naoto, >> >> Sorry that I did not check the test in jdk_util this time. I will >> modify the data version in tablea1.txt and the entity names in >> CurrencyData.properties. >> >> I will check text and util test results before sending the new webrev. >> >> thanks, >> Yong >> >> On 2015/7/28 0:19, Naoto Sato wrote: >>> Hmm, looks like you haven't updated the "DATAVERSION" in tablea1.txt, >>> I am just wondering whether the test actually succeeds with your >>> modification? Have you run tests? >>> >>> Another comment is that it's still lacking the updates in the >>> amendment 160 which I pointed out before - entity name changes. It >>> will not affect the behavior, but I would align the entity names in >>> CurrencyData.properties, i.e., "BAHAMAS" to "BAHAMAS (THE)" >>> >>> Naoto >>> >>> On 7/26/15 8:07 PM, Yong Huang wrote: >>>> Hi Naoto and All, >>>> >>>> The modified webrev is at >>>> http://cr.openjdk.java.net/~yhuang/8129361/webrev.01/ >>>> >>>> Amendment number information is changed in >>>> >>>> - jdk/make/data/currency/CurrencyData.properties >>>> - jdk/test/java/util/Currency/tablea1.txt >>>> >>>> Text "# Generated automatically from the Common Locale Data Repository. >>>> DO NOT EDIT!" is removed in >>>> src/java.base/share/classes/sun/util/resources/CurrencyNames.properties. >>>> >>>> The data are maintained manually now. >>>> >>>> thanks, >>>> Yong >>>> >>>> On 2015/7/23 7:08, Naoto Sato wrote: >>>>> Hi Yong, >>>>> >>>>> I think we should update the amendment number from 159 to 160, as well >>>>> as the entity name changes in >>>>> >>>>> - jdk/make/data/currency/CurrencyData.properties >>>>> - jdk/test/java/util/Currency/tablea1.txt >>>>> >>>>> Naoto >>>>> >>>>> On 7/21/15 11:30 PM, Yong Huang wrote: >>>>>> Sorry that, there is typo in bug link. >>>>>> >>>>>> It's https://bugs.openjdk.java.net/browse/JDK-8129361 >>>>>> >>>>>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >>>>>> >>>>>> thanks, >>>>>> Yong >>>>>> >>>>>> On 2015/7/22 14:27, Yong Huang wrote: >>>>>>> Hello, >>>>>>> >>>>>>> This is the review request for >>>>>>> https://bugs.openjdk.java.net/browse/JDK-8029361 >>>>>>> >>>>>>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/ >>>>>>> >>>>>>> In Amendment 160, two currency names are changed, but in JDK 9, the >>>>>>> name of RON is already Romanian Leu. So, only name of HRK is changed >>>>>>> to Kuna in 8129361. >>>>>>> >>>>>>> thanks, >>>>>>> Yong >>>>>> >>>> >> >