<i18n dev> [9] Review Request - JDK-8129361: ISO 4217 amendment 160

[Naoto Sato]

Hmm, looks like you haven't updated the "DATAVERSION" in tablea1.txt, I 
am just wondering whether the test actually succeeds with your 
modification? Have you run tests?

Another comment is that it's still lacking the updates in the amendment 
160 which I pointed out before - entity name changes. It will not affect 
the behavior, but I would align the entity names in 
CurrencyData.properties, i.e., "BAHAMAS" to "BAHAMAS (THE)"

Naoto

On 7/26/15 8:07 PM, Yong Huang wrote:
> Hi Naoto and All,
>
> The modified webrev is at
> http://cr.openjdk.java.net/~yhuang/8129361/webrev.01/
>
> Amendment number information is changed in
>
> - jdk/make/data/currency/CurrencyData.properties
> - jdk/test/java/util/Currency/tablea1.txt
>
> Text "# Generated automatically from the Common Locale Data Repository.
> DO NOT EDIT!" is removed in
> src/java.base/share/classes/sun/util/resources/CurrencyNames.properties.
> The data are maintained manually now.
>
> thanks,
> Yong
>
> On 2015/7/23 7:08, Naoto Sato wrote:
>> Hi Yong,
>>
>> I think we should update the amendment number from 159 to 160, as well
>> as the entity name changes in
>>
>> - jdk/make/data/currency/CurrencyData.properties
>> - jdk/test/java/util/Currency/tablea1.txt
>>
>> Naoto
>>
>> On 7/21/15 11:30 PM, Yong Huang wrote:
>>> Sorry that, there is typo in bug link.
>>>
>>> It's https://bugs.openjdk.java.net/browse/JDK-8129361
>>>
>>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/
>>>
>>> thanks,
>>> Yong
>>>
>>> On 2015/7/22 14:27, Yong Huang wrote:
>>>> Hello,
>>>>
>>>> This is the review request for
>>>> https://bugs.openjdk.java.net/browse/JDK-8029361
>>>>
>>>> webrev: http://cr.openjdk.java.net/~yhuang/8129361/webrev.00/
>>>>
>>>> In Amendment 160, two currency names are changed, but in JDK 9, the
>>>> name of RON is already Romanian Leu. So, only name of HRK is changed
>>>> to Kuna in 8129361.
>>>>
>>>> thanks,
>>>> Yong
>>>
>