<i18n dev> RFR: 8080774: DateFormat for Singapore/English locale (en_SG) is M/d/yy instead of d/M/yy

Naoto Sato naoto.sato at oracle.com
Thu Jun 4 20:10:39 UTC 2015


Hi Aleksej,

I'd move the line 5423 in LocaleData (new) up before your change lines 
as it was meant for the original 6498742 regression test. Other than 
that it looks good to me.

Naoto

On 6/4/15 8:47 AM, Aleksej Efimov wrote:
> Hi,
>
> Please review an English Singapore (en_SG) date formats fix [2] in JRE
> locale provider.
> According to the latest CLDR data (27.0.1) [3] day should precede month
> in all date formats.
> JRE locale provider has different formats that should be fixed
> accordingly - changes in FormatData_en_SG.java.
> Existing test case was updated with new date formats for en_SG locale -
> test/sun/text/resources/LocaleData changes.
> New regression test was also created for this issue - it tests the JRE
> locale provider and en_SG locale date formats. When jdk9 will start use
> CLDR as a default locale data provider [4] this test might be useful to
> test the old provider. But the addition of this test to test repository
> is a topic for discussion.
>
> Thanks,
> Aleksej
>
> [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8080774
> [2] Webrev: http://cr.openjdk.java.net/~aefimov/8080774/9/00/
> [3] CLDR data (search for en_SG):
> http://www.unicode.org/cldr/charts/27/by_type/date_&_time.generic.html
> [4] JEP 252: Use CLDR Locale Data by Default:
> http://openjdk.java.net/jeps/252


More information about the i18n-dev mailing list