From masayoshi.okutsu at oracle.com Thu Oct 1 09:23:40 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Thu, 1 Oct 2015 18:23:40 +0900 Subject: [9] RFR: 8138663: Missing @build in test/java/text/Format/DecimalFormat/RoundingAndPropertyTest.java Message-ID: <560CFB9C.5020608@oracle.com> Hello, Please review this simple fix for 8138663. RoundingAndPropertyTest.java uses golden data classes which are not recomplied when updated. Bug: https://bugs.openjdk.java.net/browse/JDK-8138663 Webrev: http://cr.openjdk.java.net/~okutsu/9/8138663/webrev.00 Thanks, Masayoshi From Naoto.Sato at Oracle.COM Thu Oct 1 16:53:03 2015 From: Naoto.Sato at Oracle.COM (Naoto Sato) Date: Thu, 1 Oct 2015 09:53:03 -0700 Subject: [9] RFR: 8138663: Missing @build in test/java/text/Format/DecimalFormat/RoundingAndPropertyTest.java In-Reply-To: <560CFB9C.5020608@oracle.com> References: <560CFB9C.5020608@oracle.com> Message-ID: <560D64EF.8070204@Oracle.COM> Looks good. Naoto On 10/1/2015 2:23 AM, Masayoshi Okutsu wrote: > Hello, > > Please review this simple fix for 8138663. > RoundingAndPropertyTest.java uses golden data classes which are not > recomplied when updated. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8138663 > Webrev: http://cr.openjdk.java.net/~okutsu/9/8138663/webrev.00 > > Thanks, > Masayoshi > -- Naoto Sato From aleksej.efimov at oracle.com Fri Oct 2 17:47:56 2015 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Fri, 2 Oct 2015 20:47:56 +0300 Subject: RFR: 8138716: (tz) Support tzdata2015g Message-ID: <560EC34C.6060100@oracle.com> Hi, Please, help to review the latest tzdata integration [1] fix to JDK9: http://cr.openjdk.java.net/~aefimov/tzdata/2015g/9/00/index.html Testing shows no failures in time zones related tests. With Best Regards, Aleksej [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8138716 From rachna.goel at oracle.com Fri Oct 2 17:50:13 2015 From: rachna.goel at oracle.com (Rachna Goel) Date: Fri, 2 Oct 2015 23:20:13 +0530 Subject: Review Request:JDK-8075315:Change in API doc Message-ID: <560EC3D5.6070000@oracle.com> Hi All, Please review the following fix in API doc for jdk9. Reference to Bug: https://bugs.openjdk.java.net/browse/JDK-8075315 Webrev: http://cr.openjdk.java.net/~naoto/rachna/8075315/webrev.00/ Description: The API doc of Currency.getInstance(Locale) specifies NullPointerException to be thrown if locale's country is null. However, Locale.getCountry() never returns null. So, I have changed this doc (/NullPointerException - if locale or its country code is null/ ) to (/NullPointerException - if locale is null/ ). Thanks, Rachna From naoto.sato at oracle.com Fri Oct 2 18:41:09 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Fri, 2 Oct 2015 11:41:09 -0700 Subject: Review Request:JDK-8075315:Change in API doc In-Reply-To: <560EC3D5.6070000@oracle.com> References: <560EC3D5.6070000@oracle.com> Message-ID: <560ECFC5.5080908@oracle.com> Looks good to me. Naoto On 10/2/15 10:50 AM, Rachna Goel wrote: > Hi All, > > Please review the following fix in API doc for jdk9. > > Reference to Bug: https://bugs.openjdk.java.net/browse/JDK-8075315 > > Webrev: http://cr.openjdk.java.net/~naoto/rachna/8075315/webrev.00/ > > Description: > > The API doc of Currency.getInstance(Locale) specifies > NullPointerException to be thrown if locale's country is null. However, > Locale.getCountry() never returns null. > > So, I have changed this doc (/NullPointerException - if locale or its > country code is null/ ) to (/NullPointerException - if locale is null/ ). > > Thanks, > > Rachna > From naoto.sato at oracle.com Fri Oct 2 22:48:50 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Fri, 2 Oct 2015 15:48:50 -0700 Subject: [9] RFR: 8138613: Remove SPI locale provider adapter from the default provider list Message-ID: <560F09D2.3000908@oracle.com> Hello, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8138613 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8138613/webrev.00/ Naoto From yuka.kamiya at oracle.com Sat Oct 3 00:38:32 2015 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Sat, 3 Oct 2015 09:38:32 +0900 Subject: Review Request:JDK-8075315:Change in API doc In-Reply-To: <560EC3D5.6070000@oracle.com> References: <560EC3D5.6070000@oracle.com> Message-ID: <560F2388.10201@oracle.com> Hi Rachna, Looks good to me. (We should solve the mixing of "" and "{@code }" in the future, though....) Thanks, -- Yuka On 2015/10/03 2:50, Rachna Goel wrote: > Hi All, > > Please review the following fix in API doc for jdk9. > > Reference to Bug: https://bugs.openjdk.java.net/browse/JDK-8075315 > > Webrev: http://cr.openjdk.java.net/~naoto/rachna/8075315/webrev.00/ > > Description: > > The API doc of Currency.getInstance(Locale) specifies > NullPointerException to be thrown if locale's country is null. > However, Locale.getCountry() never returns null. > > So, I have changed this doc (/NullPointerException - if locale or its > country code is null/ ) to (/NullPointerException - if locale is null/ ). > > Thanks, > > Rachna > From yuka.kamiya at oracle.com Sat Oct 3 00:43:14 2015 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Sat, 3 Oct 2015 09:43:14 +0900 Subject: RFR: 8138716: (tz) Support tzdata2015g In-Reply-To: <560EC34C.6060100@oracle.com> References: <560EC34C.6060100@oracle.com> Message-ID: <560F24A2.1060704@oracle.com> Hi Aleksej, Looks good to me. Thanks, -- Yuka On 2015/10/03 2:47, Aleksej Efimov wrote: > Hi, > > Please, help to review the latest tzdata integration [1] fix to JDK9: > http://cr.openjdk.java.net/~aefimov/tzdata/2015g/9/00/index.html > Testing shows no failures in time zones related tests. > > With Best Regards, > Aleksej > > [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8138716 From masayoshi.okutsu at oracle.com Sun Oct 4 04:37:43 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Sun, 4 Oct 2015 13:37:43 +0900 Subject: [9] RFR: 8138613: Remove SPI locale provider adapter from the default provider list In-Reply-To: <560F09D2.3000908@oracle.com> References: <560F09D2.3000908@oracle.com> Message-ID: <5610AD17.9020008@oracle.com> Looks good to me. Masayoshi On 10/3/2015 7:48 AM, Naoto Sato wrote: > Hello, > > Please review the fix for the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8138613 > > The proposed changeset is located at: > > http://cr.openjdk.java.net/~naoto/8138613/webrev.00/ > > Naoto From aleksej.efimov at oracle.com Fri Oct 9 16:23:57 2015 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Fri, 9 Oct 2015 19:23:57 +0300 Subject: RFR: 8139107: DateTimeFormatter with Locale.UK throw a NullPointerException when parsing zone Message-ID: <5617EA1D.70905@oracle.com> Hi, Please, review the JDK9 fix for 8139107 bug [1] that solves the possible NPE during zone parsing by DateTimeFormatter. The root cause of such behavior is that generic time zone names are absent in "TimeZoneNames_hi" and "TimeZoneNames_en_GB" classes. The proposed fix changes that: http://cr.openjdk.java.net/~aefimov/8139107/9/00 This bug can be reproduced only with JRE locale provider. Testing shows no failures with JDK regression tests. The new test also gives pass result. With Best Regards, Aleksej [1] https://bugs.openjdk.java.net/browse/JDK-8139107 From naoto.sato at oracle.com Fri Oct 9 18:37:35 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Fri, 9 Oct 2015 11:37:35 -0700 Subject: RFR: 8139107: DateTimeFormatter with Locale.UK throw a NullPointerException when parsing zone In-Reply-To: <5617EA1D.70905@oracle.com> References: <5617EA1D.70905@oracle.com> Message-ID: <5618096F.7050009@oracle.com> Hi Aleksej, Looks good to me. Looks like this is a regression caused by the fix to 8076287. Thanks for the fix! Naoto On 10/9/15 9:23 AM, Aleksej Efimov wrote: > Hi, > > Please, review the JDK9 fix for 8139107 bug [1] that solves the possible > NPE during zone parsing by DateTimeFormatter. > The root cause of such behavior is that generic time zone names are > absent in "TimeZoneNames_hi" and "TimeZoneNames_en_GB" classes. > The proposed fix changes that: > http://cr.openjdk.java.net/~aefimov/8139107/9/00 > This bug can be reproduced only with JRE locale provider. > Testing shows no failures with JDK regression tests. The new test also > gives pass result. > > With Best Regards, > Aleksej > > [1] https://bugs.openjdk.java.net/browse/JDK-8139107 From yuka.kamiya at oracle.com Fri Oct 16 12:41:33 2015 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Fri, 16 Oct 2015 21:41:33 +0900 Subject: [9] RFR: 8072600: Unicode 8 support Message-ID: <5620F07D.8030109@oracle.com> Hello, Please review a small change for 8072600: Unicode 8 support. Mainly date update from Unicode 7. JEP: http://openjdk.java.net/jeps/267 Issue: https://bugs.openjdk.java.net/browse/JDK-8072600 webrev: http://cr.openjdk.java.net/~peytoia/8072600/ Thanks, -- Yuka From masayoshi.okutsu at oracle.com Tue Oct 20 08:06:06 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Tue, 20 Oct 2015 17:06:06 +0900 Subject: [9] RFR: 8072600: Unicode 8 support In-Reply-To: <5620F07D.8030109@oracle.com> References: <5620F07D.8030109@oracle.com> Message-ID: <5625F5EE.7020203@oracle.com> Looks good to me. Masayoshi On 10/16/2015 9:41 PM, Yuka Kamiya wrote: > Hello, > > Please review a small change for 8072600: Unicode 8 support. > Mainly date update from Unicode 7. > > JEP: http://openjdk.java.net/jeps/267 > Issue: https://bugs.openjdk.java.net/browse/JDK-8072600 > webrev: http://cr.openjdk.java.net/~peytoia/8072600/ > > Thanks, > -- > Yuka From rachna.goel at oracle.com Wed Oct 21 18:00:55 2015 From: rachna.goel at oracle.com (Rachna Goel) Date: Wed, 21 Oct 2015 23:30:55 +0530 Subject: Review Request:JDK-8061287-Update i18n tests to remove references of jre dir Message-ID: <5627D2D7.7020706@oracle.com> Hi all, Please review a small change in PropertiesTest.sh. Please find attached diff generated from "hg diff". Thanks, Rachna -------------- next part -------------- diff -r b3d0002fde2a test/java/util/Currency/PropertiesTest.sh --- a/test/java/util/Currency/PropertiesTest.sh Thu Oct 08 22:31:42 2015 +0530 +++ b/test/java/util/Currency/PropertiesTest.sh Wed Oct 21 23:02:30 2015 +0530 @@ -101,11 +101,7 @@ # without disturbing other users, including concurrently executing tests. WRITABLEJDK=.${FS}testjava cp -H -R $TESTJAVA $WRITABLEJDK || exit 1 -if [ -d ${TESTJAVA}${FS}jre ]; then - PROPLOCATION=${WRITABLEJDK}${FS}jre${FS}lib -else - PROPLOCATION=${WRITABLEJDK}${FS}lib -fi +PROPLOCATION=${WRITABLEJDK}${FS}lib chmod -R +w $WRITABLEJDK || exit 1 cp ${PROPS} $PROPLOCATION || exit 1 echo "Properties location: ${PROPLOCATION}" From naoto.sato at oracle.com Wed Oct 21 18:03:22 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 21 Oct 2015 11:03:22 -0700 Subject: Review Request:JDK-8061287-Update i18n tests to remove references of jre dir In-Reply-To: <5627D2D7.7020706@oracle.com> References: <5627D2D7.7020706@oracle.com> Message-ID: <5627D36A.3010207@oracle.com> +1 Naoto On 10/21/15 11:00 AM, Rachna Goel wrote: > Hi all, > > Please review a small change in PropertiesTest.sh. > > Please find attached diff generated from "hg diff". > > Thanks, > Rachna From naoto.sato at oracle.com Thu Oct 22 16:27:24 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Thu, 22 Oct 2015 09:27:24 -0700 Subject: [9] RFR: 8136668: Default locale provider adapter incorrectly set to JRE Message-ID: <56290E6C.3030508@oracle.com> Hello, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8136668 The proposed change is located at: http://cr.openjdk.java.net/~naoto/8136668/webrev.00/ Naoto From naoto.sato at oracle.com Thu Oct 22 16:29:28 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Thu, 22 Oct 2015 09:29:28 -0700 Subject: [9] RFR: 8134720: Lazy initialization support for currency names in DecimalFormatSymbols Message-ID: <56290EE8.1050207@oracle.com> Hello, Please review yet another fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8134720 The proposed change is located at: http://cr.openjdk.java.net/~naoto/8134720/webrev.00/ The fix also includes some clean up. Naoto From masayoshi.okutsu at oracle.com Thu Oct 22 23:41:04 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Fri, 23 Oct 2015 08:41:04 +0900 Subject: [9] RFR: 8136668: Default locale provider adapter incorrectly set to JRE In-Reply-To: <56290E6C.3030508@oracle.com> References: <56290E6C.3030508@oracle.com> Message-ID: <56297410.1070205@oracle.com> Looks good to me. Masayoshi On 10/23/2015 1:27 AM, Naoto Sato wrote: > Hello, > > Please review the fix for the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8136668 > > The proposed change is located at: > > http://cr.openjdk.java.net/~naoto/8136668/webrev.00/ > > Naoto From masayoshi.okutsu at oracle.com Fri Oct 23 00:48:20 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Fri, 23 Oct 2015 09:48:20 +0900 Subject: [9] RFR: 8134720: Lazy initialization support for currency names in DecimalFormatSymbols In-Reply-To: <56290EE8.1050207@oracle.com> References: <56290EE8.1050207@oracle.com> Message-ID: <562983D4.3030405@oracle.com> Looks good to me. Masayoshi On 10/23/2015 1:29 AM, Naoto Sato wrote: > Hello, > > Please review yet another fix for the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8134720 > > The proposed change is located at: > > http://cr.openjdk.java.net/~naoto/8134720/webrev.00/ > > The fix also includes some clean up. > > Naoto From yuka.kamiya at oracle.com Mon Oct 26 02:36:33 2015 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Mon, 26 Oct 2015 11:36:33 +0900 Subject: Review Request:JDK-8061287-Update i18n tests to remove references of jre dir In-Reply-To: <5627D2D7.7020706@oracle.com> References: <5627D2D7.7020706@oracle.com> Message-ID: <562D91B1.6020203@oracle.com> Hi Rachna, The fix looks good to me. Thanks, -- Yuka On 2015/10/22 3:00, Rachna Goel wrote: > Hi all, > > Please review a small change in PropertiesTest.sh. > > Please find attached diff generated from "hg diff". > > Thanks, > Rachna From naoto.sato at oracle.com Fri Oct 30 19:00:40 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Fri, 30 Oct 2015 12:00:40 -0700 Subject: [9] RFR: 8062006: Add a new locale data name "COMPAT" for java.locale.providers system property to reduce ambiguity Message-ID: <5633BE58.80705@oracle.com> Hello, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8062006 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8062006/webrev.00/ Naoto From vincent at josm.openstreetmap.de Fri Oct 30 20:08:39 2015 From: vincent at josm.openstreetmap.de (Vincent Privat) Date: Fri, 30 Oct 2015 21:08:39 +0100 Subject: JOSM feedback on Java 7,8,9, including Jigsaw EA In-Reply-To: <5633A2A2.8070603@oracle.com> References: <5633A2A2.8070603@oracle.com> Message-ID: 2015-10-30 18:02 GMT+01:00 Alan Bateman : > > JDK-8138878 seems to be JSOM hacking into private field in > java.awt.Toolkit. It is possible to discuss the issue on awt-dev and > i18n-dev to see if the changing locale scenario is meant to work? > > Yes, this is a hack we found in the Sun bug database as a workaround to JDK-6292739. The bug describes the changing locale scenario: "If you change the default locale at runtime, the text displayed for accelerator keys doesn't change, e.g. if you start with default locale Locale.GERMAN an accelerator for "control I", which shows up as "Strg-I", doesn't change to "Ctrl-I" when changing the Locale to Locale.US." As JDK-6292739 is classified to "Bug" we assume it is meant to work. If this bug is resolved we can remove the hack from JOSM.