<i18n dev> Review request: JDK-8081794 ParsePosition getErrorIndex returns 0 for TimeZone parsing problem

Naveen Kumar naveen.ah.kumar at oracle.com
Tue Sep 29 10:12:09 UTC 2015


Hi,
       Please consider this updated webrev.01 for the review of bug 
JDK-8081794.

Bug: https://bugs.openjdk.java.net/browse/JDK-8081794
Webrev: http://cr.openjdk.java.net/~okutsu/naveen/8081794/webrev.01/

Updates in Fix:
                           Instead of removing "pos.index=-i" from 
subParse function, which was done in previous webrev version, the 
modifications is now done in subParseZoneString  functions to return 
"-start" at the end instead of current return value of 0. This will 
automatically allow "pos.index=-i" set the correct value for errorIndex 
update.

Updates in Test:
                            Corrected Copyright information.
                            Corrected Formatting issues

regards
Naveen Kumar


On 9/25/2015 4:38 PM, Naveen Kumar wrote:
> Hi,
>
>                 Please review the following fix for jdk9.
>
> Bug:https://bugs.openjdk.java.net/browse/JDK-8081794
> Webrev:http://cr.openjdk.java.net/~psadhukhan/naveen/webrev/
>
>
> Issue:
>           a malformed TimeZone will prevent parsing the date, but not 
> set the correct errorIndex in ParsePosition
>
> Fix:
>       remove incorrect update of "pos.index = -i" from subParse 
> function in SimpleDateFormat.java, which (pos.index) is later used to 
> update error index as "origPos.errorIndex = pos.index;"
>
>
> regards
> Naveen Kumar



More information about the i18n-dev mailing list