<i18n dev> RFR: 8151431: DateFormatSymbols triggers this.clone() in the constructor

Naoto Sato naoto.sato at oracle.com
Wed Apr 6 17:44:10 UTC 2016


Looks good overall. Here are my suggestions.

- DateFormatSymbols.java: We could cache all candidate locales, e.g., if 
the requested locale is ja_JP_JP, and the bundle locale is ja, we could 
also put ja_JP bundle in the cache.

- DateFormatSymbolsCloneTest.java: import sentence for the Locale class 
can be removed.

Naoto

On 4/6/16 2:10 AM, Masayoshi Okutsu wrote:
> Hi all,
>
> Please review the fix for JDK-8151431. clone() is no longer called to
> create a cache entry.
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8151431
> Webrev:
> http://cr.openjdk.java.net/~okutsu/9/8151431/webrev.00/
>
> Thanks,
> Masayoshi
>


More information about the i18n-dev mailing list