<i18n dev> RFR: 8054214: JapaneseEra.getDisplayName doesn't return names if it's an additional era
Masayoshi Okutsu
masayoshi.okutsu at oracle.com
Sun Dec 11 02:26:12 UTC 2016
Thank you for the review comments. I realized that only TextStyle.NARROW
and NARROW_STANDALONE should return the abbreviation to be consistent
with locale data. I've changed the implementation, which should have
"fixed" the NPE issue, and added more test cases.
Revised webrev:
http://cr.openjdk.java.net/~okutsu/9/8054214/webrev.01/
While I was testing more, I realized the default implementation of
Era.getDisplayName doesn't work with non-IsoChronology. I filed new bug
report JDK-8171049.
Thanks,
Masayoshi
On 12/8/2016 5:55 PM, Masayoshi Okutsu wrote:
> Hi,
>
> Please review the fix for JDK-8054214. It was necessary to override
> Era::getDisplayName to get era names from the specified property. This
> one fixes getAbbreviation() as well.
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8054214
>
> Webrev:
> http://cr.openjdk.java.net/~okutsu/9/8054214/webrev.00/
>
> Thanks,
> Masayoshi
>
More information about the i18n-dev
mailing list