<i18n dev> [OpenJDK 2D-Dev] RFR: 8039273: Font related files should not be modified in ${java.home}/lib
Phil Race
philip.race at oracle.com
Thu Dec 15 22:26:59 UTC 2016
This whole fontconfig lookup logic is in a doPrivileged.
And the code is already opening the directory in the findImpl method
called just below the new exists() call.
-phil.
On 12/15/2016 05:16 AM, Sergey Bylokhov wrote:
> Hi, Phil.
>
>> The fix has been updated.
>> http://cr.openjdk.java.net/~prr/8039273.1/
>> 2nd reviewer anyone ?
> Looks fine. I assume that SecurityException from File.exists() is expected, or the code is executed under doPriviliged() block.
>
>> -phil.
>>
>>
>> On 12/09/2016 09:44 AM, Naoto Sato wrote:
>>> Hi Phil,
>>>
>>> In FontConfiguration.java, line 193-195 can be inserted just after line 191, as fontConfigFile is guaranteed to be non-null if userConfigFile is non null. Otherwise it looks good to me.
>>>
>>> Naoto
>>>
>>> On 12/8/16 12:01 PM, Phil Race wrote:
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8039273
>>>> Webrev : http://cr.openjdk.java.net/~prr/8039273/
>>>>
>>>> A CCC request and documentation are being prepared.
>>>>
>>>> -phil
More information about the i18n-dev
mailing list