<i18n dev> [9] RFR: 8148346: Reduce number of packages in jdk.localedata module

Masayoshi Okutsu masayoshi.okutsu at oracle.com
Fri Feb 19 05:34:31 UTC 2016


This one is much easier to take a look than the previous webrevs. This 
time I've looked at all diffs while I did a sampling for our internal 
review.

Looks OK to me. I still prefer the per-language (not 
per-language.country) grouping, though.

Masayoshi

On 2/19/2016 2:50 AM, Naoto Sato wrote:
> Alan,
>
> I updated the webrev with the latest webrev tool on OpenJDK site. Here 
> is the revised one:
>
> http://cr.openjdk.java.net/~naoto/8148346/webrev.01/
>
> However, for some reason, the new webrev handles only .java files 
> shuffling correctly, not for .properties files. They still remain all 
> removed/created. Anyway what I did was to move all the resource files 
> to language/country independent locations, and changed the "package" 
> declarations in .java files.
>
> Naoto
>
> On 2/17/16 11:07 PM, Alan Bateman wrote:
>>
>> Naoto - I don't know if this is hg version or webrev related but the
>> moves aren't showing up correctly in the webrev so it's hard to see the
>> actual changes. Can you try a new recent webrev to see if that fixes it?
>>
>> -Alan
>>
>>
>> On 17/02/2016 21:28, Naoto Sato wrote:
>>> Hello,
>>>
>>> Please review the fix to the following issue:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8148346
>>>
>>> The proposed change is located at:
>>>
>>> http://cr.openjdk.java.net/~naoto/8148346/webrev.00/
>>>
>>> Vast majority of the changes are changing package names. They used to
>>> be lang/ctry structure, which bloats the number of locale data package
>>> names to hundreds. Now it comes down to 8 packages with this fix.
>>>
>>> Naoto
>>



More information about the i18n-dev mailing list