<i18n dev> RFR: JDK-8147912: test "parseWithZoneWithoutOffset" of java/time/tck/java/time/format/TCKDTFParsedInstant.java fail on de_DE locale

[Ramanand Patil]

Hi Masayoshi,

 

Thank you for review. This test was contributed by me for bug HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8066982"JDK-8066982.

Running this only in English should be Ok as per me, since this was added just to test one of the parsing scenario when Zone information is available without Offset.

Anyway, I will wait for java.time people to review this change.

 

Regards,

Ramanand.

 

-----Original Message-----
From: Masayoshi Okutsu 
Sent: Wednesday, January 27, 2016 11:23 AM
To: Ramanand Patil; i18n-dev at openjdk.java.net; core-libs-dev at openjdk.java.net
Subject: Re: <i18n dev>RFR: JDK-8147912: test "parseWithZoneWithoutOffset" of java/time/tck/java/time/format/TCKDTFParsedInstant.java fail on de_DE locale

 

Looks OK to me. But I'd like some java.time people to review this change to see if the intention of this test is to run only in English.

 

Thanks,

Masayoshi

 

On 1/27/2016 1:51 PM, Ramanand Patil wrote:

> Hi all,

> 

>   

> 

> Please help me in reviewing this test fix.

> 

>   

> 

> Regards,

> 

> Ramanand.

> 

> From: Ramanand Patil

> Sent: Monday, January 25, 2016 1:05 PM

> To: HYPERLINK "mailto:i18n-dev at openjdk.java.net"i18n-dev at openjdk.java.net

> Cc: HYPERLINK "mailto:core-libs-dev at openjdk.java.net"core-libs-dev at openjdk.java.net

> Subject: <i18n dev>RFR: JDK-8147912: test "parseWithZoneWithoutOffset" 

> of java/time/tck/java/time/format/TCKDTFParsedInstant.java fail on 

> de_DE locale

> 

>   

> 

> Hi all,

>   

> Please review the trivial test bug fix for: 

> https://bugs.openjdk.java.net/browse/JDK-8147912

>   

> Bug Description: Since the test case "parseWithZoneWithoutOffset" is using hard code as input data it will fail on some non-English locales (de_DE locale).

>   

> Webrev: http://cr.openjdk.java.net/~rpatil/8147912/webrev.00

>   

> Fix: Even though hardcoded data is not preferred in compatibility test cases, this case was exception. English is provided as the default locale data for DateTimeFormatter in this testcase.

>   

> Regards,

> Ramanand.