<i18n dev> Review Request : JDK-8066652 : Default TimeZone is GMT not local if user.timezone is invalid on Mac OS

[Langer, Christoph]

Hi Rachna,

In general, the fix looks good to me.

However, there are a few indentation flaws, in lines 830, 831 and 834 - 841. Please make sure you use 4 chars indentation.
And you should remove the blank between the cast to (time_t) and the variable in line 832.

Also, please note that I'm no reviewer.

Best regards,
Christoph

> -----Original Message-----
> From: i18n-dev [mailto:i18n-dev-bounces at openjdk.java.net] On Behalf Of
> Rachna Goel
> Sent: Freitag, 29. Juli 2016 08:17
> To: i18n-dev at openjdk.java.net
> Subject: <i18n dev> Review Request : JDK-8066652 : Default TimeZone is GMT
> not local if user.timezone is invalid on Mac OS
> 
> Hi,
> 
> Please review the fix for JDK-8066652.
> 
> Bug :  https://bugs.openjdk.java.net/browse/JDK-8066652
> 
> Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8066652/webrev.01/
> 
> Fix : 1. Used thread safe function localtime_r() to retrieve system
> timezone.
>           2. timezone retrieved should be "GMT" if system timezone is
> "GMT" and user specifies a fake timezone using user.timezone system
> property.
>                Earlier it used to be "GMT+00:00" which is wrong.
> 
> --
> Thanks,
> Rachna